From nobody Mon Feb 9 02:13:16 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1615831389; cv=none; d=zohomail.com; s=zohoarc; b=M1kDQtcKuBOFhLRBQEAA11Lt4mjPudgcLzlcgmK4P/eG6iBuijl59qcjro7cvCzX+HdRjD9PjuSfakcpgoWN3icRasYFf1EhfyeUyJlznr0zqg6S80md3BZI8grZudqHRt+2oJmRyC3gVrelDtn6vuckkYChqFwmjzPcph7J0AA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615831389; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=VfBRUwqCiQv4p1UR7m5zW9f9shYxpP7YYg6Wfun0ZnE=; b=CxD7rIZqa/wApf/9rDpHm6Gh6tNngXg9DqVvW4F/M5JNlZvKXj01KmbIyuhnyjtc0SVsaWjQ6bjCscSV0ZJbloX7k7oURJ9K7J5qbKIpMjc4csFO5VNT5qp1C4SBfG3KdBLVCp8lbxTC091tAfbEYfzYSkt01iQQrTxKUi1ZENA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1615831389471168.13816384504014; Mon, 15 Mar 2021 11:03:09 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-308-DuXK4V-sOcevu-3PhrW2OA-1; Mon, 15 Mar 2021 14:03:02 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3DEB581431F; Mon, 15 Mar 2021 18:02:57 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 03EFA1F050; Mon, 15 Mar 2021 18:02:57 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B7B3057DC4; Mon, 15 Mar 2021 18:02:56 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 12FI2oNc007488 for ; Mon, 15 Mar 2021 14:02:50 -0400 Received: by smtp.corp.redhat.com (Postfix) id 6409517C53; Mon, 15 Mar 2021 18:02:50 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-112-141.ams2.redhat.com [10.36.112.141]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A1E545D9C0; Mon, 15 Mar 2021 18:02:42 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 0EE9E1800636; Mon, 15 Mar 2021 19:02:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615831388; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=VfBRUwqCiQv4p1UR7m5zW9f9shYxpP7YYg6Wfun0ZnE=; b=M+AluzAiTBFApdjp02+gyEEquhfHle/ZbDJpGX4aC+HcP1JQIYUVX7vMdcBQGhwesohi+6 fL34NrVbjS84m4ERK9vvi1UM6orPab7rbw7lBOxZDrLAiBwFylELiTACyPqAy2qYiYbVff +CIxnVIXsSfEmost9KXOmdXKzZqzSyY= X-MC-Unique: DuXK4V-sOcevu-3PhrW2OA-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Subject: [PULL 01/13] hw/usb/bus: Remove the "full-path" property Date: Mon, 15 Mar 2021 19:02:28 +0100 Message-Id: <20210315180240.1597240-2-kraxel@redhat.com> In-Reply-To: <20210315180240.1597240-1-kraxel@redhat.com> References: <20210315180240.1597240-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com Cc: Thomas Huth , libvir-list@redhat.com, Huacai Chen , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Gerd Hoffmann , Paolo Bonzini , Samuel Thibault X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" From: Thomas Huth This property was only required for the pc-1.0 and earlier machine types. Since these have been removed now, we can delete the property as well. Signed-off-by: Thomas Huth Message-Id: <20210302120152.118042-1-thuth@redhat.com> Signed-off-by: Gerd Hoffmann --- include/hw/usb.h | 1 - hw/usb/bus.c | 7 +------ 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/include/hw/usb.h b/include/hw/usb.h index abfbfc5284c2..9f42394efaea 100644 --- a/include/hw/usb.h +++ b/include/hw/usb.h @@ -216,7 +216,6 @@ struct USBEndpoint { }; =20 enum USBDeviceFlags { - USB_DEV_FLAG_FULL_PATH, USB_DEV_FLAG_IS_HOST, USB_DEV_FLAG_MSOS_DESC_ENABLE, USB_DEV_FLAG_MSOS_DESC_IN_USE, diff --git a/hw/usb/bus.c b/hw/usb/bus.c index 064f94e9c3cc..df7411fea8e4 100644 --- a/hw/usb/bus.c +++ b/hw/usb/bus.c @@ -19,8 +19,6 @@ static void usb_qdev_unrealize(DeviceState *qdev); static Property usb_props[] =3D { DEFINE_PROP_STRING("port", USBDevice, port_path), DEFINE_PROP_STRING("serial", USBDevice, serial), - DEFINE_PROP_BIT("full-path", USBDevice, flags, - USB_DEV_FLAG_FULL_PATH, true), DEFINE_PROP_BIT("msos-desc", USBDevice, flags, USB_DEV_FLAG_MSOS_DESC_ENABLE, true), DEFINE_PROP_STRING("pcap", USBDevice, pcap_filename), @@ -596,11 +594,8 @@ static char *usb_get_dev_path(DeviceState *qdev) { USBDevice *dev =3D USB_DEVICE(qdev); DeviceState *hcd =3D qdev->parent_bus->parent; - char *id =3D NULL; + char *id =3D qdev_get_dev_path(hcd); =20 - if (dev->flags & (1 << USB_DEV_FLAG_FULL_PATH)) { - id =3D qdev_get_dev_path(hcd); - } if (id) { char *ret =3D g_strdup_printf("%s/%s", id, dev->port->path); g_free(id); --=20 2.29.2