From nobody Sun Feb 8 12:37:28 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1615463106; cv=none; d=zohomail.com; s=zohoarc; b=DZx9FTf0Itc1spqhDQDPVske+uI5qHgJJvLWT++nbvsDypLJI5jpDUdfKlBCu1oJQ+Jjm05YdVc2xKgHs8sR0qJnxzJcp2ZNmEAIjqEU8bV0flVOl05dyJBZ07hNot10zB4oSwypu4NynclN/7DInAjXczZ/DMEWnv7IYT0agl8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615463106; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=UPKVZUDm59nOyHgfstHTf3KS/nqwcbJYL53kaAQc4mk=; b=UobtsFnRXw4djx+P/Jr3wURr671QWhq+4TxTfc2pJsdR31KASqbPkJSgf1tvPe6J6kx3dTH6lxgD1Yy7jcq/IDBFTDLp9FycjaWIqO1FRqhLxAzDBBV55cU3elw6cUSpl+fHkGy/r6/2nuLXGE5/6YYm3gudZGeSpWoaqE3a+NA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1615463106912468.9215087179491; Thu, 11 Mar 2021 03:45:06 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-5-bgptL9bnOA2eQ9DviY9dKw-1; Thu, 11 Mar 2021 06:44:06 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1E70F803F50; Thu, 11 Mar 2021 11:44:00 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EFB605D6D1; Thu, 11 Mar 2021 11:43:59 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B7B2918006D9; Thu, 11 Mar 2021 11:43:59 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 12BBhw06025018 for ; Thu, 11 Mar 2021 06:43:58 -0500 Received: by smtp.corp.redhat.com (Postfix) id 8F4D060C5D; Thu, 11 Mar 2021 11:43:58 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-115-85.ams2.redhat.com [10.36.115.85]) by smtp.corp.redhat.com (Postfix) with ESMTP id E26D360875; Thu, 11 Mar 2021 11:43:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615463105; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=UPKVZUDm59nOyHgfstHTf3KS/nqwcbJYL53kaAQc4mk=; b=PwG1KI58BKShF84GrsB/QNAvabBVQjJjlCUDVEBbbC+ZW2ynPisvK7OEmmXKpvihO9CWzI JWk3D+Y1rjA6BSD/h2dplJx0irZlGgVm3lGldRA2KYSpsfMhvKLLXyQllXyi7rxYprCLe/ 9+orpGa3PN4al4w93ezoSa1qs5PI9jQ= X-MC-Unique: bgptL9bnOA2eQ9DviY9dKw-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v2 3/3] ui: deprecate "password" option for SPICE server Date: Thu, 11 Mar 2021 11:43:43 +0000 Message-Id: <20210311114343.439820-4-berrange@redhat.com> In-Reply-To: <20210311114343.439820-1-berrange@redhat.com> References: <20210311114343.439820-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Cc: libvir-list@redhat.com, Gerd Hoffmann , "Dr. David Alan Gilbert" X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) With the new "password-secret" option, there is no reason to use the old inecure "password" option with -spice, so it can be deprecated. Signed-off-by: Daniel P. Berrang=C3=A9 --- docs/system/deprecated.rst | 8 ++++++++ qemu-options.hx | 4 ++++ ui/spice-core.c | 2 ++ 3 files changed, 14 insertions(+) diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst index 241b28a521..e742c8d311 100644 --- a/docs/system/deprecated.rst +++ b/docs/system/deprecated.rst @@ -166,6 +166,14 @@ Using ``-M kernel-irqchip=3Doff`` with x86 machine typ= es that include a local APIC is deprecated. The ``split`` setting is supported, as is using ``-M kernel-irqchip=3Doff`` with the ISA PC machine type. =20 +``-spice password=3Dstring`` (since 6.0) +'''''''''''''''''''''''''''''''''''''' + +This option is insecure because the SPICE password remains visible in +the process listing. This is replaced by the new ``password-secret`` +option which lets the password be securely provided on the command +line using a ``secret`` object instance. + QEMU Machine Protocol (QMP) commands ------------------------------------ =20 diff --git a/qemu-options.hx b/qemu-options.hx index 77bb834e37..48382a8a2a 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -1928,6 +1928,10 @@ SRST ``password=3D`` Set the password you need to authenticate. =20 + This option is deprecated and insecure because it leaves the + password visible in the process listing. Use ``password-secret`` + instead. + ``password-secret=3D`` Set the ID of the ``secret`` object containing the password you need to authenticate. diff --git a/ui/spice-core.c b/ui/spice-core.c index 7f0e005ca9..235d61f0c1 100644 --- a/ui/spice-core.c +++ b/ui/spice-core.c @@ -686,6 +686,8 @@ static void qemu_spice_init(void) } else { str =3D qemu_opt_get(opts, "password"); if (str) { + warn_report("'password' option is deprecated and insecure, " + "use 'password-secret' instead"); password =3D g_strdup(str); } } --=20 2.29.2