From nobody Mon Feb 9 16:50:53 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1614846959; cv=none; d=zohomail.com; s=zohoarc; b=exsH/MSjZ6wxoGUicWYirRIcvhZuy1diQS7wSgD3lTwPUzXmmKPNCgRKf8038x5MvpfJWTrxjXpgRdTyJDi8vaJiz2/3/aZoT4xrH2d/0xom2ayIl99QQyXinOUwnoNM0v3ldEuwlPBLBnBOJmg3FogB3PmRRl3dXP1GDDJQizk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614846959; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=lNkTHzRNImbdgNcEch7RxOmwSBrULDHLiGFctZjn+7o=; b=BobufkeQHDhk27gfy+DOkHFaLj1TESUDgRoeogEfSxipYvM0kYT5gxtQl+vYFKPmGCkGKUyUw9iI5UyE/7jjew9Z4x2pbA1yPuZhp9IC4GSfY49uwb7fpOCfGes1ZXX1XdZTVLlCU44mqvu3fo9mh1Tcs5mMiPyhlyO/027MOXg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1614846959850188.71328119735324; Thu, 4 Mar 2021 00:35:59 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-342-G2JWQtuPMU6NGJKTsBvORg-1; Thu, 04 Mar 2021 03:35:56 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7C4631005D51; Thu, 4 Mar 2021 08:35:51 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 567C212BF3; Thu, 4 Mar 2021 08:35:51 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 17EA218077CC; Thu, 4 Mar 2021 08:35:51 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1248Zda1001439 for ; Thu, 4 Mar 2021 03:35:39 -0500 Received: by smtp.corp.redhat.com (Postfix) id C587F226FB; Thu, 4 Mar 2021 08:35:39 +0000 (UTC) Received: from work.redhat.com (ovpn-112-142.ams2.redhat.com [10.36.112.142]) by smtp.corp.redhat.com (Postfix) with ESMTP id 15910226E9; Thu, 4 Mar 2021 08:35:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614846958; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=lNkTHzRNImbdgNcEch7RxOmwSBrULDHLiGFctZjn+7o=; b=cmkWbi2pFDLTN8B6uay1JjEGT+uI4Y4iYKSkwET4PWTTZRrqZ1Pa7OM3oA0YqmsVXQkMc5 R7yEyhRu7XwZcWL/JRWrntcKYTxnSoJzzyRsZ8YOXT/E47sO5qZanSS0GFATuE47vfxEyJ ExKISB+0rsUDGPAtos8I5k+WSB94ghc= X-MC-Unique: G2JWQtuPMU6NGJKTsBvORg-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH 3/5] domain_conf: Reduce scope of node in virDomainFeaturesDefParse Date: Thu, 4 Mar 2021 09:35:29 +0100 Message-Id: <20210304083531.9690-4-twiederh@redhat.com> In-Reply-To: <20210304083531.9690-1-twiederh@redhat.com> References: <20210304083531.9690-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index f73814f3c7..4bc82b69fc 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -18156,7 +18156,6 @@ virDomainFeaturesDefParse(virDomainDefPtr def, xmlXPathContextPtr ctxt) { g_autofree xmlNodePtr *nodes =3D NULL; - xmlNodePtr node =3D NULL; size_t i; int n; =20 @@ -18356,7 +18355,7 @@ virDomainFeaturesDefParse(virDomainDefPtr def, if (def->features[VIR_DOMAIN_FEATURE_HYPERV] =3D=3D VIR_TRISTATE_SWITC= H_ON) { int feature; int value; - node =3D ctxt->node; + xmlNodePtr node =3D ctxt->node; if ((n =3D virXPathNodeSet("./features/hyperv/*", ctxt, &nodes)) <= 0) return -1; =20 @@ -18630,6 +18629,7 @@ virDomainFeaturesDefParse(virDomainDefPtr def, =20 if (def->features[VIR_DOMAIN_FEATURE_MSRS] =3D=3D VIR_TRISTATE_SWITCH_= ON) { g_autofree char *tmp =3D NULL; + xmlNodePtr node =3D NULL; if ((node =3D virXPathNode("./features/msrs", ctxt)) =3D=3D NULL) return -1; =20 --=20 2.26.2