From nobody Mon Feb 9 13:01:03 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1614795555; cv=none; d=zohomail.com; s=zohoarc; b=nhIBK5xWmrgvGx/DWNsrPToGDF5Fc/mUZ8k7vs/jWkvHvPgfgwGaU63bnEs/37G65ZFvfshs72KsS/vuKA1WYh9XXJd6W7EB0bhyY19bTk1T/Cs1X9fvvecA9LVX6WT4s9auEpXA8j+YMWlQDsm/gtrVzOmIO0574DQeP4bIuQc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614795555; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=BQ3x9q1zQph2EonY5FHsMjDjVJjDbwXnbWKEH/LQ1Qo=; b=ac1b6fYZafBd9I/aUdoGLFkHyY1cchjA+gDizQPBsveyTfcdm7Amcx3yHYvbGRAn7tLIWV0j4XtRpW1S8RueOGKzUNNiPzvbaaaUMQK5l2e+6H8o7jFM16Si1mA+TwQP5wps+KwupUlutFIgGM5PlM1W98Xw1DDuZcN/dXxWopo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1614795555754371.72064919585773; Wed, 3 Mar 2021 10:19:15 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-344-XNYWBkOPO-yCTNsZyWPn-Q-1; Wed, 03 Mar 2021 13:19:12 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5440918C35C4; Wed, 3 Mar 2021 18:19:06 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 032476F45C; Wed, 3 Mar 2021 18:19:06 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id BAC8C5002E; Wed, 3 Mar 2021 18:19:05 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 123IIl7X032347 for ; Wed, 3 Mar 2021 13:18:47 -0500 Received: by smtp.corp.redhat.com (Postfix) id 8D3D860C15; Wed, 3 Mar 2021 18:18:47 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-115-145.ams2.redhat.com [10.36.115.145]) by smtp.corp.redhat.com (Postfix) with ESMTP id C4D3460BFA; Wed, 3 Mar 2021 18:18:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614795554; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=BQ3x9q1zQph2EonY5FHsMjDjVJjDbwXnbWKEH/LQ1Qo=; b=KgzpjboCPjOjvt4pUX1fbXDrD3PXdRZ9yW5QkcpvYOwHQj2YGdX46Aaub1bIVVCShMAd39 ouv1Spw7kq+fO1s+CAku/ENKSUJE70M4YMHw4WYw/dYcaSNaLFYT6dHq2CJfz+5Zl9ngMC DvviowhAfekjEWSphc/jdFa0DkaRLxQ= X-MC-Unique: XNYWBkOPO-yCTNsZyWPn-Q-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Subject: [libvirt PATCH 01/18] config: cleanup some typos / baggage wrt compiler checks Date: Wed, 3 Mar 2021 18:18:17 +0000 Message-Id: <20210303181834.1578756-2-berrange@redhat.com> In-Reply-To: <20210303181834.1578756-1-berrange@redhat.com> References: <20210303181834.1578756-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) We had a copy and paste mistake from code we mirrored from QEMU, as well as failing to remove an earlier redundant check. Signed-off-by: Daniel P. Berrang=C3=A9 --- config.h | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/config.h b/config.h index 2ee7f7bff6..ca6720f37d 100644 --- a/config.h +++ b/config.h @@ -25,10 +25,6 @@ # define _FORTIFY_SOURCE 2 #endif =20 -#ifndef __GNUC__ -# error "Libvirt requires GCC >=3D 4.8, or Clang" -#endif - /* * Define __GNUC_PREREQ to a sane default if it isn't yet defined. * This is done here so that it's included as early as possible; @@ -41,16 +37,16 @@ #if defined(__clang_major__) && defined(__clang_minor__) # ifdef __apple_build_version__ # if __clang_major__ < 5 || (__clang_major__ =3D=3D 5 && __clang_minor__ = < 1) -# error You need at least XCode Clang v5.1 to compile QEMU +# error You need at least XCode Clang v5.1 to compile libvirt # endif # else # if __clang_major__ < 3 || (__clang_major__ =3D=3D 3 && __clang_minor__ = < 4) -# error You need at least Clang v3.4 to compile QEMU +# error You need at least Clang v3.4 to compile libvirt # endif # endif #elif defined(__GNUC__) && defined(__GNUC_MINOR__) # if __GNUC__ < 4 || (__GNUC__ =3D=3D 4 && __GNUC_MINOR__ < 8) -# error You need at least GCC v4.8 to compile QEMU +# error You need at least GCC v4.8 to compile libvirt # endif #else # error You either need at least GCC 4.8 or Clang 3.4 or XCode Clang 5.1 t= o compile libvirt --=20 2.29.2