From nobody Sat May 4 10:53:29 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1614744760; cv=none; d=zohomail.com; s=zohoarc; b=MNcJIDouIbQvUNSdBrwqzpaFuw1K8z0Lqmp3Agrw2Mzb/+iaMoXEjp88UErkYeKVffwOEVQgm+cz2txezvFbkrtHImdRHIHPym4SACKv3CSpMsRzYmL0wjrHgLa4+K8KvpIskk3M3s9PQYxwpTGTVnKj/cOONMaqyJQ2wzeLeEw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614744760; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=nTl+AxXx5jkHVZ1ESuvHGQ0IOUKu2XWThFtPUHROEGU=; b=eG5AM2YAB2gw3qOtjYD5vlyYeJ3UfMJQuIVndVgR49EGyEf5Lz3kcztnOAi1psbXElIunYwqJL48Oq2r1l00LOZOY1uROa+FFxKnKuB80dP90Qg1U0EmFAmsM8jC734QZGbayHoiYpZZsJ/8CoUYoMGnWzoXproSpoAcqedcwCA= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1614744760347353.8725100763362; Tue, 2 Mar 2021 20:12:40 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-254-a80ME_NkNGe59Giw3Ui6Dw-1; Tue, 02 Mar 2021 23:12:37 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C7C3B50742; Wed, 3 Mar 2021 04:12:29 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C6D4F5D9C2; Wed, 3 Mar 2021 04:12:26 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 7ABC74E58D; Wed, 3 Mar 2021 04:12:22 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1234CJUC011467 for ; Tue, 2 Mar 2021 23:12:20 -0500 Received: by smtp.corp.redhat.com (Postfix) id D99F611F4A4; Wed, 3 Mar 2021 04:12:19 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast06.extmail.prod.ext.rdu2.redhat.com [10.11.55.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D442C11E5A4 for ; Wed, 3 Mar 2021 04:12:17 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 945F518039C0 for ; Wed, 3 Mar 2021 04:12:17 +0000 (UTC) Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-588-CINYQ201NqqndLlygZJEXQ-1; Tue, 02 Mar 2021 23:12:15 -0500 Received: by mail-lj1-f169.google.com with SMTP id h4so26687711ljl.0 for ; Tue, 02 Mar 2021 20:12:14 -0800 (PST) Received: from kloomba.my.domain ([31.29.242.166]) by smtp.gmail.com with ESMTPSA id d8sm2812165lfg.96.2021.03.02.20.12.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Mar 2021 20:12:12 -0800 (PST) X-MC-Unique: a80ME_NkNGe59Giw3Ui6Dw-1 X-MC-Unique: CINYQ201NqqndLlygZJEXQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=nTl+AxXx5jkHVZ1ESuvHGQ0IOUKu2XWThFtPUHROEGU=; b=EYagwNvD5gybTnXepIoHeg4pIWdKHGQKR2Fb5gxpjAbNYyQ5jwd5175Tf1bGH8hGhr Nv9xPH02EyS7/225hlsKkrFK+QYqdlPGZyStf0wVV3mnuJHMHSJnYrYtZGBwK9SHY0zO YcBMaqLpvm37PikzMRIXksIGNmZb56w7wRt3ui87ytnoojupGVV0l7tOa5fXYYlr1FbZ azqIJ7O1T44fQUnRYsXzX+JQfvVdFE+bnLC0QwFIsIeRS7OMbNMAHxYXOKiR9uNSsdzr O4kGBPFcK/tqRieSvMnU8V8FxjOxb7JDTvNQptZbeivKwwb24hWRnU9CV3stdy/pUAgx 3ZpQ== X-Gm-Message-State: AOAM530/0bVcsbnLSY50KZccje9W8kNJxf802obQbXXf2wCwgXfHZCn9 LFcfoBbptOngvTAVTgWcyNEzzmc+aUYn0w== X-Google-Smtp-Source: ABdhPJxRAuMU7H7jk+AqOsts42k8T3Fe03PXNoU22TUF4xQ/vTKgWZHC0OG6D2IIZgTaAcUbJAJ2zw== X-Received: by 2002:a2e:5841:: with SMTP id x1mr14015971ljd.473.1614744733448; Tue, 02 Mar 2021 20:12:13 -0800 (PST) From: Roman Bogorodskiy To: libvir-list@redhat.com Subject: [PATCH] meson: tools: depend on keycode generated sources Date: Wed, 3 Mar 2021 08:12:05 +0400 Message-Id: <20210303041205.98159-1-bogorodskiy@gmail.com> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-loop: libvir-list@redhat.com Cc: Roman Bogorodskiy X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Tools depend on keycode generated sources, so declare that as an explicit dependency, otherwise it might fail with: ../tools/virsh-completer-domain.c:35:10: fatal error: 'virkeynametable_linu= x.h' file not found ^~~~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Roman Bogorodskiy Reviewed-by: J=C3=A1n Tomko --- I noticed that build failure on FreeBSD 11.x. For some reason, it doesn't show up on newer versions. This is strange, but as the fix appears to be straight-forward, I didn't spend much time figuring out the reason. In case you're interested, a full failing build log is here: https://people.freebsd.org/~novel/misc/libvirt-7.1.0.log It doesn't seem to even try to generate these files. When I inspected filesystem state, these files were missing. src/util/meson.build | 2 ++ tools/meson.build | 1 + 2 files changed, 3 insertions(+) diff --git a/src/util/meson.build b/src/util/meson.build index 0080825bd0..cd3fe18524 100644 --- a/src/util/meson.build +++ b/src/util/meson.build @@ -168,6 +168,8 @@ foreach name : keyname_list ) endforeach =20 +keycode_dep =3D declare_dependency(sources: keycode_gen_sources) + io_helper_sources =3D [ 'iohelper.c', ] diff --git a/tools/meson.build b/tools/meson.build index b8c6802f0a..42dc609439 100644 --- a/tools/meson.build +++ b/tools/meson.build @@ -186,6 +186,7 @@ executable( tools_dep, readline_dep, thread_dep, + keycode_dep, ], link_args: [ coverage_flags, --=20 2.30.0