[PATCH] build-aux: increase tests timeout

Roman Bogorodskiy posted 1 patch 3 years ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20210228042458.27326-1-bogorodskiy@gmail.com
build-aux/meson.build | 1 +
1 file changed, 1 insertion(+)
[PATCH] build-aux: increase tests timeout
Posted by Roman Bogorodskiy 3 years ago
Meson default timeout for test() is 30 seconds. This may be not enough
for some tests like sc_prohibit_nonreentrant or
sc_libvirt_unmarked_diagnostics, so set it to 60 seconds.

Signed-off-by: Roman Bogorodskiy <bogorodskiy@gmail.com>
---
On my system these two tests always timeout with the default value.
That's what I have after increasing timeout:

157/288 libvirt:syntax-check / sc_prohibit_nonreentrant                          OK             52.18s
183/288 libvirt:syntax-check / sc_libvirt_unmarked_diagnostics                   OK             31.48s

 build-aux/meson.build | 1 +
 1 file changed, 1 insertion(+)

diff --git a/build-aux/meson.build b/build-aux/meson.build
index c506feefd2..4acd5e16c1 100644
--- a/build-aux/meson.build
+++ b/build-aux/meson.build
@@ -44,6 +44,7 @@ if git
         potfiles_dep,
       ],
       suite: 'syntax-check',
+      timeout: 60,
     )
   endforeach
 endif
-- 
2.30.0

Re: [PATCH] build-aux: increase tests timeout
Posted by Peter Krempa 3 years ago
On Sun, Feb 28, 2021 at 08:24:58 +0400, Roman Bogorodskiy wrote:
> Meson default timeout for test() is 30 seconds. This may be not enough
> for some tests like sc_prohibit_nonreentrant or
> sc_libvirt_unmarked_diagnostics, so set it to 60 seconds.

Recently [1] we've established that we'll not be raising the timeout
arbitrarily to compensate for a possibly slow hardware unless it's a
widespread problem.

The tests you are complaining about are pretty fast on my system:

203/334 libvirt:syntax-check / sc_prohibit_nonreentrant                          OK             0.23s
315/334 libvirt:syntax-check / sc_unmarked_diagnostics                           OK             0.63s

On a laptop:
204/335 libvirt:syntax-check / sc_prohibit_nonreentrant                          OK             0.44s
316/335 libvirt:syntax-check / sc_unmarked_diagnostics                           OK             0.78s

And on a random sample from our (linux) CI runs:
53/158 libvirt:syntax-check / sc_libvirt_unmarked_diagnostics  OK      0.6185753345489502 s
27/158 libvirt:syntax-check / sc_prohibit_nonreentrant  OK      0.2680661678314209 s 

Given the almost 2 orders of magnitude difference, I think something is
broken on your system and should be investigated first before attempting
to increase the timeout.

> Signed-off-by: Roman Bogorodskiy <bogorodskiy@gmail.com>
> ---
> On my system these two tests always timeout with the default value.
> That's what I have after increasing timeout:
> 
> 157/288 libvirt:syntax-check / sc_prohibit_nonreentrant                          OK             52.18s
> 183/288 libvirt:syntax-check / sc_libvirt_unmarked_diagnostics                   OK             31.48s

[1] thread start: https://listman.redhat.com/archives/libvir-list/2021-January/msg01148.html
https://listman.redhat.com/archives/libvir-list/2021-January/msg01219.html