From nobody Sun Feb 8 19:54:57 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1613480281; cv=none; d=zohomail.com; s=zohoarc; b=EqfmUy/W+pvibkGrPQ9Q+Cr0plUCkJabeK8NcyMR+Y5K2bo0rtAIkug351LcpWwEi+HFDe10XbjGrOhTJVuUt6BdbwCzGzEGkyyeLsHnIO52UbPT8ZRb3dATLt/ic1LD30ALUgqxq19JYjfoxmcbHPeWIgr3sb+f08FA1S6aV0g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1613480281; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=8JLZaM711ulPZeBMHEdxC2ap1/AfBC9YtNW5TJ5G1KI=; b=ZxU+03qtdIn/csbnX/J7Y+aiRDWhsxfGdsncIhEnm7g9abh+vLSw4nDc3RxRYTTKE0jJSoDZ4XFtbsNiLPIEn9E+xP8iIAPLE9NtERDpgpMYTNIy1GbyyfvMHY2V38AGBtZAgnLO+lqor0HCkZ45NCnhsfZqVK8TKakeXA+nkg8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1613480281192863.6662253337788; Tue, 16 Feb 2021 04:58:01 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-440-r8zfwhBFNK6PZ3NQC9eAGg-1; Tue, 16 Feb 2021 07:57:55 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 60A00801AB1; Tue, 16 Feb 2021 12:57:50 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 36C4760937; Tue, 16 Feb 2021 12:57:50 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id EB09157DFD; Tue, 16 Feb 2021 12:57:49 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 11GCvmqc002345 for ; Tue, 16 Feb 2021 07:57:48 -0500 Received: by smtp.corp.redhat.com (Postfix) id EA86E60C5F; Tue, 16 Feb 2021 12:57:48 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-112-215.ams2.redhat.com [10.36.112.215]) by smtp.corp.redhat.com (Postfix) with ESMTP id 28208619CA; Tue, 16 Feb 2021 12:57:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613480280; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=8JLZaM711ulPZeBMHEdxC2ap1/AfBC9YtNW5TJ5G1KI=; b=Bxfzn2pxQMNyf2Pj+ZlUWvsmVipSPGl5qMcNPIZ0OgOBqR/drTLQgVRKjg6u+qQ/PP2lex tIeUukuwvbFyrd0Mgc3WJ2YAETvK71MVbp2MNiDVKZoWNGzbYjVOkTOK77PVjHh25PAfJi CQ05h2f0JMi/jXvRGUds1d2i3cUSDoU= X-MC-Unique: r8zfwhBFNK6PZ3NQC9eAGg-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Subject: [libvirt PATCH 4/5] qemu: use on|off instead of yes|no for -drive boolean properties Date: Tue, 16 Feb 2021 12:57:04 +0000 Message-Id: <20210216125705.275788-5-berrange@redhat.com> In-Reply-To: <20210216125705.275788-1-berrange@redhat.com> References: <20210216125705.275788-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) QEMU has long accepted many different values for boolean properties, but set accepted has been different depending on which QEMU parser you hit. The on|off values were supported by all QEMU parsers. The yes|no, y|n, true|false values were only partially supported: https://lists.gnu.org/archive/html/qemu-devel/2020-11/msg01012.html Thus we should standardize on on|off everywhere since that is most widely supported in QEMU. Signed-off-by: Daniel P. Berrang=C3=A9 --- src/util/virqemu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virqemu.c b/src/util/virqemu.c index 4136012c70..5b0dc25bc1 100644 --- a/src/util/virqemu.c +++ b/src/util/virqemu.c @@ -362,7 +362,7 @@ virQEMUBuildDriveCommandlineFromJSON(virJSONValuePtr sr= cdef) { g_auto(virBuffer) buf =3D VIR_BUFFER_INITIALIZER; =20 - if (virQEMUBuildCommandLineJSON(srcdef, &buf, NULL, false, + if (virQEMUBuildCommandLineJSON(srcdef, &buf, NULL, true, virQEMUBuildCommandLineJSONArrayNumber= ed) < 0) return NULL; =20 --=20 2.29.2