From nobody Mon Feb 9 15:09:35 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1612183362; cv=none; d=zohomail.com; s=zohoarc; b=oFKt4M2AN3v6pLb7yhYSWBMeh5D6Jk6FZ87HpqenmEVhMZYR86FMtgOWxcFNgUWHAyjPamNBobr3rjLyv2R9YQD1PM03PQRsi6CuFwqq89/bBoV/1rNSvupxkOQcOmSifedwhipL+oa3Z+zEPeQqQU0qhew69Gnd335kt9enbD4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612183362; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Qa124Ry/yNFFGDpuUZkxQrYujNTwsuqy7Iks8se8MOo=; b=FRjtemGATV/Q1wDIY6/oxJFmyIZQkkqsmy9rfCFCBchfUs7TsJ8NW6cTyg+KQTflkVOSSiSFYgjUTCWf6Ed/wtR+pM9V3UEYURulfH6KZPKhpuvDsanit7asburEkky5BNbtcHHj6sMHUPuMK7RaKS9XvOsrwHsCVBJJ4hb6fz4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1612183362946372.3727015640245; Mon, 1 Feb 2021 04:42:42 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-457-wn18cl4PPQaoDw6Ko3tN6w-1; Mon, 01 Feb 2021 07:42:39 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A3EB21005D52; Mon, 1 Feb 2021 12:42:33 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 820E560C64; Mon, 1 Feb 2021 12:42:33 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 488551809CA0; Mon, 1 Feb 2021 12:42:33 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 111CgLNP014717 for ; Mon, 1 Feb 2021 07:42:21 -0500 Received: by smtp.corp.redhat.com (Postfix) id 0637D62461; Mon, 1 Feb 2021 12:42:21 +0000 (UTC) Received: from work.redhat.com (ovpn-113-167.ams2.redhat.com [10.36.113.167]) by smtp.corp.redhat.com (Postfix) with ESMTP id 179FB5D749; Mon, 1 Feb 2021 12:42:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612183362; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Qa124Ry/yNFFGDpuUZkxQrYujNTwsuqy7Iks8se8MOo=; b=DiA4+Bs0GhOYTQBQWl3sfG79l6cbh3no3hNvf57patvA7nFd7SuuGxxYmewUTAcqYeiKBX KQfvKzK6nfcpAJ3YFtgowNo1kChcwOHpi8BK03Mw2i5RekIKjqq969Bu1/9uKirso7Vb/q ZpxJmp705aDA7r40Bdgmqou4u+qygWA= X-MC-Unique: wn18cl4PPQaoDw6Ko3tN6w-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH v2 07/10] virhostuptime: Fix rounding in uptime calculation Date: Mon, 1 Feb 2021 13:42:04 +0100 Message-Id: <20210201124207.148709-8-twiederh@redhat.com> In-Reply-To: <20210201124207.148709-1-twiederh@redhat.com> References: <20210201124207.148709-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Cc: Peter Krempa , Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" "f + 0.5" does not round correctly for values very close to ".5" for every integer multiple, e.g. "0.499999975". Found by clang-tidy's "bugprone-incorrect-roundings" check. Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- src/util/virhostuptime.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/util/virhostuptime.c b/src/util/virhostuptime.c index 696a38fbb5..7508a5a9b6 100644 --- a/src/util/virhostuptime.c +++ b/src/util/virhostuptime.c @@ -32,6 +32,8 @@ #include "virtime.h" #include "virthread.h" =20 +#include + #define VIR_FROM_THIS VIR_FROM_NONE =20 VIR_LOG_INIT("util.virhostuptime"); @@ -76,7 +78,7 @@ virHostGetBootTimeProcfs(unsigned long long *btime) return -EINVAL; } =20 - *btime =3D now / 1000 - up + 0.5; + *btime =3D llround(now / 1000 - up); =20 return 0; } --=20 2.26.2