From nobody Mon Feb 9 10:32:51 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1612183348; cv=none; d=zohomail.com; s=zohoarc; b=nrRDHDOf76XHsPhvjh96V26qMkeRSpPBhHMM4Fl7WAywWlkMSMdricKe8UZzhHBecS6TUVl7aIRJ2o7d0malp9LvxOZ/jp2Z1/dsmJLay6ALGZXYCrKYoQuVRWj2m0idaNkVH0YMupZ8p1sX/5ikYjRtM22jEqTsbTdDUKrI2J8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612183348; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=/uvRJgu9a34xYMCQHXpoZ4KkxByXqwzqpvUVwyJpwrE=; b=kfHaEvqDEpqimhrlErPeaHV/yVASao7HM6tRZAbGREnZ5uItAFJauicY8TYIVq4zJnDulcKjuDRQNkiWn/A7RHazmd5uD3jDH2A4aJ48eXvdC8NS7Lo966843NoWor1arardxOQhb3BxgJJbwsudNUjc/O/+XAIB/tBIbgdXsIQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1612183348908509.1347952461873; Mon, 1 Feb 2021 04:42:28 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-430-TaDw23foM3SoceKc99XEtQ-1; Mon, 01 Feb 2021 07:42:25 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 12327193578C; Mon, 1 Feb 2021 12:42:20 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B664C6E405; Mon, 1 Feb 2021 12:42:19 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8157F5003A; Mon, 1 Feb 2021 12:42:19 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 111CgHfj014682 for ; Mon, 1 Feb 2021 07:42:17 -0500 Received: by smtp.corp.redhat.com (Postfix) id 4964A5D756; Mon, 1 Feb 2021 12:42:17 +0000 (UTC) Received: from work.redhat.com (ovpn-113-167.ams2.redhat.com [10.36.113.167]) by smtp.corp.redhat.com (Postfix) with ESMTP id 506C262461; Mon, 1 Feb 2021 12:42:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612183347; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=/uvRJgu9a34xYMCQHXpoZ4KkxByXqwzqpvUVwyJpwrE=; b=bcfErMe8i63X8gwsfKRbd1UFhtGG/4867dj2k5FUT/c342hINgMTfYUWGyPM2xgJiorJeC K0wPFH+6CLv56x8zYL7ApPFTW4EVzgcmgts2M1lIJrEpOvskyxGvhnPRXCAitYDHsDo66N 9ch9yMqKe8R3v1nu5OvV1wG8yId89+k= X-MC-Unique: TaDw23foM3SoceKc99XEtQ-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH v2 04/10] virsh-domain: Fix error handling of pthread_sigmask Date: Mon, 1 Feb 2021 13:42:01 +0100 Message-Id: <20210201124207.148709-5-twiederh@redhat.com> In-Reply-To: <20210201124207.148709-1-twiederh@redhat.com> References: <20210201124207.148709-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Cc: Peter Krempa , Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" pthread_sigmask() returns 0 on success and "a non-zero value on failure", but not neccessarily a negative one. Found by clang-tidy's "bugprone-posix-return" check. Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- tools/virsh-domain.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 2bb136333f..298c3a6587 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -4226,7 +4226,7 @@ doSave(void *opaque) =20 sigemptyset(&sigmask); sigaddset(&sigmask, SIGINT); - if (pthread_sigmask(SIG_BLOCK, &sigmask, &oldsigmask) < 0) + if (pthread_sigmask(SIG_BLOCK, &sigmask, &oldsigmask) !=3D 0) goto out_sig; #endif /* !WIN32 */ =20 @@ -4756,7 +4756,7 @@ doManagedsave(void *opaque) =20 sigemptyset(&sigmask); sigaddset(&sigmask, SIGINT); - if (pthread_sigmask(SIG_BLOCK, &sigmask, &oldsigmask) < 0) + if (pthread_sigmask(SIG_BLOCK, &sigmask, &oldsigmask) !=3D 0) goto out_sig; #endif /* !WIN32 */ =20 @@ -5438,7 +5438,7 @@ doDump(void *opaque) =20 sigemptyset(&sigmask); sigaddset(&sigmask, SIGINT); - if (pthread_sigmask(SIG_BLOCK, &sigmask, &oldsigmask) < 0) + if (pthread_sigmask(SIG_BLOCK, &sigmask, &oldsigmask) !=3D 0) goto out_sig; #endif /* !WIN32 */ =20 @@ -10732,7 +10732,7 @@ doMigrate(void *opaque) =20 sigemptyset(&sigmask); sigaddset(&sigmask, SIGINT); - if (pthread_sigmask(SIG_BLOCK, &sigmask, &oldsigmask) < 0) + if (pthread_sigmask(SIG_BLOCK, &sigmask, &oldsigmask) !=3D 0) goto out_sig; #endif /* !WIN32 */ =20 --=20 2.26.2