From nobody Tue Feb 10 19:47:55 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1612160943; cv=none; d=zohomail.com; s=zohoarc; b=CWUdqRa1WgfqnbSWstYHyQaMoK5Ij2jA9c58FfTge3u1Pz5ChOVe/FQE/J+b3N1MjSPCanuJOISQhH2ohAtUrWaaezOqTOCqq+qy9ukK0ICYlGUkQrxdElByUjc7H3h2w04SyPr5TTnpCRM2RDlCt2A3Mz4lwLZqVYnit6cf6cA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612160943; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=rH/juWmgcI25WR5uvL0J2aH5QTZshO1gdchPVKTNMCI=; b=RfitHtVcG2R98jUp+cCApQcQNaQ89XyMC4oPHnbzfklosnzVL6+bOHzgxeiLBnqbWb2FyjniuULB3k3bUX0svv2SU//8Ot/z1p+mfq3Dqk9FZvhwqOHBondLpAJRbTsxFHSqc06WZRkw7T8aN2PXrfB7ONTRcmqQOi6xfeCrOi8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1612160943343298.9276140957122; Sun, 31 Jan 2021 22:29:03 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-165-hNLcWg8LPOSLf7dJaOsrKg-1; Mon, 01 Feb 2021 01:28:00 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D66FB107ACFB; Mon, 1 Feb 2021 06:27:53 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B6A1F6F988; Mon, 1 Feb 2021 06:27:53 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 80F495003F; Mon, 1 Feb 2021 06:27:53 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1116RSKh026025 for ; Mon, 1 Feb 2021 01:27:28 -0500 Received: by smtp.corp.redhat.com (Postfix) id 64E2070476; Mon, 1 Feb 2021 06:27:28 +0000 (UTC) Received: from vhost2.laine.org (ovpn-112-159.phx2.redhat.com [10.3.112.159]) by smtp.corp.redhat.com (Postfix) with ESMTP id 300EF7216E for ; Mon, 1 Feb 2021 06:27:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612160942; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=rH/juWmgcI25WR5uvL0J2aH5QTZshO1gdchPVKTNMCI=; b=ZaNXcD8aVo16oupi7aaQPHaq/YhG0e6xFzo6g6Ivn0//dKY71SPMPTmjOabwgrJ8DspvHI Cp86/4mnLVO61ALzBX/OZ6PWfJNaCjZSFaWunFbIff8UA9dUuK6yIP6JcAcQlQaKp6E5ng Jw8Hd8giee6LIMFnGArm4sT6ahVLxXA= X-MC-Unique: hNLcWg8LPOSLf7dJaOsrKg-1 From: Laine Stump To: libvir-list@redhat.com Subject: [PATCH 6/8] conf: eliminate pointless setting of interface model Date: Mon, 1 Feb 2021 01:27:18 -0500 Message-Id: <20210201062720.425041-7-laine@redhat.com> In-Reply-To: <20210201062720.425041-1-laine@redhat.com> References: <20210201062720.425041-1-laine@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" There is no point in setting the interface model to unknown during virDomainNetDefFree(), since we are about to free the object anyway (and the model isn't used anywhere in the rest of the function). Signed-off-by: Laine Stump --- src/conf/domain_conf.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 658f563b36..1a163857ca 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -2468,7 +2468,6 @@ virDomainNetDefFree(virDomainNetDefPtr def) return; =20 VIR_FREE(def->modelstr); - def->model =3D VIR_DOMAIN_NET_MODEL_UNKNOWN; =20 switch (def->type) { case VIR_DOMAIN_NET_TYPE_VHOSTUSER: --=20 2.29.2