From nobody Tue Feb 10 16:58:11 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1612160880; cv=none; d=zohomail.com; s=zohoarc; b=jJ3vlbj8rqhzX+StIPXYQ2dxSLc1z1Rw2aKBPR3FO8gpzFH6neVKipJcrq9OozrjUwgnEKHa8yhE7M9QXnTOqgD6Fx8Gvqmx/XMid+l25VO3LqVrDcNNz8BKNvyPInkT1LHoFV68VoydLKolCY0dN/ZIu7Bgo/4Xx6jukYq/cWI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612160880; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=VQRaQ0z+1cuD+t5lyyEKmQc8pG7NbDV2HSB9YvwebY4=; b=fjHjlpW3uBCvNuRp+PhdlT3+XTczlaUssy+Q25GN8dieTek//Y5yNwvjgC/IRc54jCwNERQRALPKnm3JSM3lBbIe+y4zaGWWX7bSFPzoIvopY7yWp/8zV4wZ6S8C96kmVK9X0MIx4v2rGKtN0meM3Ds5VEdCIJHAed1nboBcLyw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1612160880161378.70118905799393; Sun, 31 Jan 2021 22:28:00 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-566--gLeQuX_Nu-ZlulT6Jhvdg-1; Mon, 01 Feb 2021 01:27:56 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 80024802B46; Mon, 1 Feb 2021 06:27:51 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1896F5E1B5; Mon, 1 Feb 2021 06:27:51 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D8DB950039; Mon, 1 Feb 2021 06:27:50 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1116RRTT025988 for ; Mon, 1 Feb 2021 01:27:27 -0500 Received: by smtp.corp.redhat.com (Postfix) id AC4F370497; Mon, 1 Feb 2021 06:27:27 +0000 (UTC) Received: from vhost2.laine.org (ovpn-112-159.phx2.redhat.com [10.3.112.159]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7774C70476 for ; Mon, 1 Feb 2021 06:27:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612160879; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=VQRaQ0z+1cuD+t5lyyEKmQc8pG7NbDV2HSB9YvwebY4=; b=g61o7qUCBvfbfK6Elw0oAiO3Q45orz8PL365gcVCA508HzSVjhY4+J1EyVhyWmWy6kZ1v9 UHlAeu08hOg8KDB9aP9wBrlW6CIhq23lpsQoexDGcrltiE3PKo7pdc3YqZfWnyc4MJfFzQ 1ohny/Yija0V2hNlfpaKiKsVy0E/RX0= X-MC-Unique: -gLeQuX_Nu-ZlulT6Jhvdg-1 From: Laine Stump To: libvir-list@redhat.com Subject: [PATCH 4/8] conf: fix arg to virDomainPCIAddressSetExtensionFree() Date: Mon, 1 Feb 2021 01:27:16 -0500 Message-Id: <20210201062720.425041-5-laine@redhat.com> In-Reply-To: <20210201062720.425041-1-laine@redhat.com> References: <20210201062720.425041-1-laine@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" This function clears out and frees a virDomainZPCIAddressIds object, so that's that's what it should take as its argument, *not* the pointer to a parent object that contains the object we want to free. Signed-off-by: Laine Stump --- src/conf/domain_addr.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/conf/domain_addr.c b/src/conf/domain_addr.c index a8648d5858..4ba620086d 100644 --- a/src/conf/domain_addr.c +++ b/src/conf/domain_addr.c @@ -944,15 +944,15 @@ virDomainPCIAddressReleaseAddr(virDomainPCIAddressSet= Ptr addrs, =20 =20 static void -virDomainPCIAddressSetExtensionFree(virDomainPCIAddressSetPtr addrs) +virDomainPCIAddressSetExtensionFree(virDomainZPCIAddressIdsPtr zpciIds) { - if (!addrs || !addrs->zpciIds) + if (!zpciIds) return; =20 - virHashFree(addrs->zpciIds->uids); - virHashFree(addrs->zpciIds->fids); + virHashFree(zpciIds->uids); + virHashFree(zpciIds->fids); =20 - VIR_FREE(addrs->zpciIds); + VIR_FREE(zpciIds); } =20 =20 @@ -1001,7 +1001,7 @@ virDomainPCIAddressSetFree(virDomainPCIAddressSetPtr = addrs) if (!addrs) return; =20 - virDomainPCIAddressSetExtensionFree(addrs); + virDomainPCIAddressSetExtensionFree(addrs->zpciIds); VIR_FREE(addrs->buses); VIR_FREE(addrs); } --=20 2.29.2