On 2/1/21 7:27 AM, Laine Stump wrote:
> Another set of small changes that started out with me noticing
> something I didn't like, and organically leading down a Kerouacian
> road to nowhere and everywhere.
>
> Most of them are related to eliminating unnecessary nullifying of
> objects that are about to be free'd anyway, but patch 2 is obsolete
> dead code, and patch 1 is a theoretical "failure with no registered
> error message".
>
> Laine Stump (8):
> log error if virConnectCacheOnceInit() fails
> hostdevmgr: remove unneeded oldStateDir
> conf: replace g_clear_pointer(..., g_hash_table_unref) with
> virHashFree()
> conf: fix arg to virDomainPCIAddressSetExtensionFree()
> conf: don't bother setting pointers to NULL in vir*Free() functions
> conf: eliminate pointless setting of interface model
> util: rename virStorageEncryptionInfoDefFree()
> conf: replace VIR_FREE() with g_free() in vir*Free() functions
>
> src/conf/capabilities.c | 8 +-
> src/conf/cpu_conf.c | 8 +-
> src/conf/device_conf.c | 2 +-
> src/conf/domain_addr.c | 32 +--
> src/conf/domain_capabilities.c | 6 +-
> src/conf/domain_conf.c | 304 +++++++++++++-------------
> src/conf/interface_conf.c | 32 +--
> src/conf/network_conf.c | 18 +-
> src/conf/node_device_conf.c | 105 +++++----
> src/conf/nwfilter_conf.c | 22 +-
> src/conf/nwfilter_params.c | 16 +-
> src/conf/object_event.c | 12 +-
> src/conf/secret_conf.c | 6 +-
> src/conf/snapshot_conf.c | 2 +-
> src/conf/storage_conf.c | 22 +-
> src/conf/storage_encryption_conf.c | 8 +-
> src/conf/storage_source_conf.c | 26 +--
> src/conf/virdomaincheckpointobjlist.c | 2 +-
> src/conf/virdomainmomentobjlist.c | 4 +-
> src/conf/virdomainsnapshotobjlist.c | 2 +-
> src/conf/virnetworkportdef.c | 12 +-
> src/conf/virnwfilterbindingdef.c | 10 +-
> src/conf/virnwfilterobj.c | 6 +-
> src/driver.c | 22 +-
> src/hypervisor/virhostdev.c | 60 +----
> src/hypervisor/virhostdev.h | 6 +-
> src/libxl/libxl_domain.c | 2 +-
> src/libxl/libxl_driver.c | 4 +-
> src/qemu/qemu_hostdev.c | 3 +-
> tests/virhostdevtest.c | 10 +-
> 30 files changed, 363 insertions(+), 409 deletions(-)
>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
Michal