From nobody Tue Feb 10 15:01:19 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1611937012; cv=none; d=zohomail.com; s=zohoarc; b=VPRldoq2FNm/cqWYikNxd5U9/NvupxW1oLaGUXpCMLTPnTqqUivI8B9mkdf661tR/DU4rLmxdSmBKynJb9r+Jp4WLpnAJNfXXHFBATn7agCb4MoCHKtj7OnLSsWquT6cf0rdR3MQ6QuVQ+IpPZuexNaw3kYycUvyXKbFNanEgxM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611937012; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=H4G0jqCILoZ9Mxps/xnoT3YbFnw9ZEe8WL3S2S0rf08=; b=l4AqHkZURLhjIZdSJvbYvjK0pYd1Ncr7zkvO76MXkFY4aFv3/JTqBtskS69MErrjxatdEH7Yant72dCxgifu4QljgQgPaOYuyaFXbepJ3gXkSlpDo0utSgz7NSP2NNpcq2LNj1iSgdK0DQ4rsgijzwSDkwmFAdalkFTi51qG9NI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1611937012457112.97683895692137; Fri, 29 Jan 2021 08:16:52 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-536-DTOvutlRMbmBABkfV7gWmg-1; Fri, 29 Jan 2021 11:16:49 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9D5771005504; Fri, 29 Jan 2021 16:16:40 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7B6385D9F8; Fri, 29 Jan 2021 16:16:40 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 120D85003F; Fri, 29 Jan 2021 16:16:40 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 10TGGb2d010245 for ; Fri, 29 Jan 2021 11:16:37 -0500 Received: by smtp.corp.redhat.com (Postfix) id 4911460CE0; Fri, 29 Jan 2021 16:16:37 +0000 (UTC) Received: from work.redhat.com (ovpn-113-143.ams2.redhat.com [10.36.113.143]) by smtp.corp.redhat.com (Postfix) with ESMTP id 89EB860871; Fri, 29 Jan 2021 16:16:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611937011; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=H4G0jqCILoZ9Mxps/xnoT3YbFnw9ZEe8WL3S2S0rf08=; b=OuqlGiiADVov3yeGHvGAtt4rRxWxKpA28YGdvGyfEDPXN3oJixKFvlIK7b7B1jrUH/yWJz HfneiEX9Tu2QnOuoiZpzk4NZ9mG1F4i+FrkE/rUepbTyv0IRU2E+HB+L1ZYkBab5cEo9T6 v9hDuna97INSAvppTywJ557MCls/IwQ= X-MC-Unique: DTOvutlRMbmBABkfV7gWmg-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH 03/19] commandhelper: Simplify envsort Date: Fri, 29 Jan 2021 17:16:13 +0100 Message-Id: <20210129161629.604823-4-twiederh@redhat.com> In-Reply-To: <20210129161629.604823-1-twiederh@redhat.com> References: <20210129161629.604823-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Comparing only the keys produces the same result as comparing keys and value. The latter saves two invocations of each `strndup` and `free`. Signed-off-by: Tim Wiederhake --- tests/commandhelper.c | 17 +---------------- 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/tests/commandhelper.c b/tests/commandhelper.c index 2b937979c0..05e3879688 100644 --- a/tests/commandhelper.c +++ b/tests/commandhelper.c @@ -39,22 +39,7 @@ static int envsort(const void *a, const void *b) { const char *const*astrptr =3D a; const char *const*bstrptr =3D b; - const char *astr =3D *astrptr; - const char *bstr =3D *bstrptr; - char *aeq =3D strchr(astr, '=3D'); - char *beq =3D strchr(bstr, '=3D'); - char *akey; - char *bkey; - int ret; - - if (!(akey =3D strndup(astr, aeq - astr))) - abort(); - if (!(bkey =3D strndup(bstr, beq - bstr))) - abort(); - ret =3D strcmp(akey, bkey); - free(akey); - free(bkey); - return ret; + return strcmp(*astrptr, *bstrptr); } =20 int main(int argc, char **argv) { --=20 2.26.2