From nobody Tue Feb 10 15:01:25 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1611937017; cv=none; d=zohomail.com; s=zohoarc; b=DN0ppo0xN1BQkmtqSM9R/qlzHwOImXcPw6qou5+HbwaNXLe1pP9FGJFcODYYTjDOJL/hZw0axKtyzwvYHIhbhMGeASiVVRD7FLdcaG8z5q+LiYp3k67ClSqplnFBEmnQgAshIYrtbVncked9lncYwodbMMAa3+u0FV2/o4GH8aA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611937017; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=J/esfX5b+3QcJ+5KbkySD1q3b44t+aIECV7uwfyAOAM=; b=LU0IRl/3PIaPKX8EQ5oyWWdCfJ2c7e+ZlQrtZs4pMWNlYGk9XvbqS7UEjvDeBWQr/JriqwF6pgqxXxsI4BWCneVdOI/CrKLBQqQW2G3DpvO0lzY+eNFfwLMgH21VCv73lh+AWJigsoxZIOyL3Lz2c3PMkB2V0POztLNXCdaRQDg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1611937017737956.4159581901075; Fri, 29 Jan 2021 08:16:57 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-22-LFJuB2RSNaCnTSyGs7_Nyw-1; Fri, 29 Jan 2021 11:16:53 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 34AE3107ACE6; Fri, 29 Jan 2021 16:16:43 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 08E4E646D6; Fri, 29 Jan 2021 16:16:43 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id C04621809C9F; Fri, 29 Jan 2021 16:16:42 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 10TGGZhD010227 for ; Fri, 29 Jan 2021 11:16:35 -0500 Received: by smtp.corp.redhat.com (Postfix) id 20C7360CE6; Fri, 29 Jan 2021 16:16:35 +0000 (UTC) Received: from work.redhat.com (ovpn-113-143.ams2.redhat.com [10.36.113.143]) by smtp.corp.redhat.com (Postfix) with ESMTP id 60DE260CE0; Fri, 29 Jan 2021 16:16:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611937015; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=J/esfX5b+3QcJ+5KbkySD1q3b44t+aIECV7uwfyAOAM=; b=CjJMpmQxYUKLNDIrS6+m0q/fvmpHoiKG9LOewu2jaxPqI4ZuMBGBeENcj86xxLSAcK1zEV J4354EP0MkAruYZxbQw1nxtt27v/R9o/W464LJ0fE0JOIo84E3j4rT3KMw3gmsYlrdW4r7 jsulqFgilG24beCjiW3kcQlkk6X3Z0M= X-MC-Unique: LFJuB2RSNaCnTSyGs7_Nyw-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH 01/19] commandhelper: Remove origenv variable Date: Fri, 29 Jan 2021 17:16:11 +0100 Message-Id: <20210129161629.604823-2-twiederh@redhat.com> In-Reply-To: <20210129161629.604823-1-twiederh@redhat.com> References: <20210129161629.604823-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake --- tests/commandhelper.c | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/tests/commandhelper.c b/tests/commandhelper.c index ba5681b715..c2040b76f0 100644 --- a/tests/commandhelper.c +++ b/tests/commandhelper.c @@ -60,7 +60,6 @@ static int envsort(const void *a, const void *b) int main(int argc, char **argv) { size_t i, n; int open_max; - char **origenv; char **newenv =3D NULL; char *cwd; FILE *log =3D fopen(abs_builddir "/commandhelper.log", "w"); @@ -92,23 +91,16 @@ int main(int argc, char **argv) { } } =20 - origenv =3D environ; - n =3D 0; - while (*origenv !=3D NULL) { - n++; - origenv++; + for (n =3D 0; environ[n]; n++) { } =20 if (!(newenv =3D malloc(sizeof(*newenv) * n))) abort(); =20 - origenv =3D environ; - n =3D i =3D 0; - while (*origenv !=3D NULL) { - newenv[i++] =3D *origenv; - n++; - origenv++; + for (i =3D 0; i < n; i++) { + newenv[i] =3D environ[i]; } + qsort(newenv, n, sizeof(newenv[0]), envsort); =20 for (i =3D 0; i < n; i++) { --=20 2.26.2