From nobody Fri May 3 03:49:01 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=linux.ibm.com ARC-Seal: i=1; a=rsa-sha256; t=1611920399; cv=none; d=zohomail.com; s=zohoarc; b=URK73qmcGK3bbY444RfvW9ELJLKvpKU5jp4X0jWe1kRKLzYMEZNrn3YQRm9I4cgxgDbQKNeXrIXhNSorAmOPQRAV62J4fuR65xTwqTHIm8MpsIqmPzKT6DHW058TtUcWD32NpPfW7k/2riH5GsV2Zi7vNy3a9ODaXok11GQj7MU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611920399; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=yAZzKZ6MTmJbZforIHLftAQf8YM2nRbe5WUQog3z0GY=; b=EA686QM/KRe3cwTjYNpMuyhFt1OM61mmBg5R/o15RjOfmIRpJAwR1QIuCUG/B7X5iNu524q0MMioW6FzwzGy0ZT/KLBiZdqav7jK06LkA5AAN/my+jakyWfpuH6QOHGxueYuOP4n+YUnlsWVW/g5Ty6uxkQjtI50d1O9Ukjx/ZY= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 161192039904124.39581766914705; Fri, 29 Jan 2021 03:39:59 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-402-76oEX1xHOtWz3D54sTyASw-1; Fri, 29 Jan 2021 06:39:55 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 780E6180E46D; Fri, 29 Jan 2021 11:39:50 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A34305D9C0; Fri, 29 Jan 2021 11:39:49 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B4C351809C9F; Fri, 29 Jan 2021 11:39:47 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 10TBdkeH009733 for ; Fri, 29 Jan 2021 06:39:46 -0500 Received: by smtp.corp.redhat.com (Postfix) id F053510D14DD; Fri, 29 Jan 2021 11:39:45 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EAB5910D14F4 for ; Fri, 29 Jan 2021 11:39:43 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8703E801229 for ; Fri, 29 Jan 2021 11:39:43 +0000 (UTC) Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-495-pywwgg3VNfO-5sZFlt07TQ-1; Fri, 29 Jan 2021 06:39:41 -0500 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 10TBVxuw052883; Fri, 29 Jan 2021 06:39:40 -0500 Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0a-001b2d01.pphosted.com with ESMTP id 36cft7b1ny-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 29 Jan 2021 06:39:39 -0500 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 10TBbZew017963; Fri, 29 Jan 2021 11:39:37 GMT Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by ppma06ams.nl.ibm.com with ESMTP id 368b2h5sjn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 29 Jan 2021 11:39:37 +0000 Received: from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 10TBdYuZ40370590 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 29 Jan 2021 11:39:34 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9E2BB42047; Fri, 29 Jan 2021 11:39:34 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6C5FB42049; Fri, 29 Jan 2021 11:39:34 +0000 (GMT) Received: from localhost.localdomain (unknown [9.145.183.171]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Fri, 29 Jan 2021 11:39:34 +0000 (GMT) X-MC-Unique: 76oEX1xHOtWz3D54sTyASw-1 X-MC-Unique: pywwgg3VNfO-5sZFlt07TQ-1 From: Boris Fiuczynski To: libvir-list@redhat.com Subject: [PATCH] conf: rename virDomainCheckVirtioOptions Date: Fri, 29 Jan 2021 12:39:22 +0100 Message-Id: <20210129113922.34933-1-fiuczy@linux.ibm.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369, 18.0.737 definitions=2021-01-29_04:2021-01-28, 2021-01-29 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 mlxlogscore=933 clxscore=1015 mlxscore=0 lowpriorityscore=0 phishscore=0 adultscore=0 bulkscore=0 impostorscore=0 malwarescore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2101290055 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-loop: libvir-list@redhat.com Cc: mprivozn@redhat.com, mhartmay@linux.ibm.com, shalini@linux.ibm.com, bwalk@linux.ibm.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename virDomainCheckVirtioOptions into virDomainCheckVirtioOptionsAreAbent since it checks if all virtio options are absent. The old name was very misleading. Signed-off-by: Boris Fiuczynski Reviewed-by: Daniel Henrique Barboza --- src/conf/domain_validate.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c index dd4c6e0fb3..a2f236c299 100644 --- a/src/conf/domain_validate.c +++ b/src/conf/domain_validate.c @@ -227,7 +227,7 @@ virSecurityDeviceLabelDefValidate(virSecurityDeviceLabe= lDefPtr *seclabels, =20 =20 static int -virDomainCheckVirtioOptions(virDomainVirtioOptionsPtr virtio) +virDomainCheckVirtioOptionsAreAbsent(virDomainVirtioOptionsPtr virtio) { if (!virtio) return 0; @@ -316,7 +316,7 @@ virDomainDiskDefValidate(const virDomainDef *def, return -1; } =20 - if (virDomainCheckVirtioOptions(disk->virtio) < 0) + if (virDomainCheckVirtioOptionsAreAbsent(disk->virtio) < 0) return -1; } =20 @@ -1363,7 +1363,7 @@ virDomainNetDefValidate(const virDomainNetDef *net) } =20 if (!virDomainNetIsVirtioModel(net) && - virDomainCheckVirtioOptions(net->virtio) < 0) { + virDomainCheckVirtioOptionsAreAbsent(net->virtio) < 0) { return -1; } =20 @@ -1513,7 +1513,7 @@ virDomainVsockDefValidate(const virDomainVsockDef *vs= ock) } =20 if (!virDomainVsockIsVirtioModel(vsock) && - virDomainCheckVirtioOptions(vsock->virtio) < 0) + virDomainCheckVirtioOptionsAreAbsent(vsock->virtio) < 0) return -1; =20 return 0; --=20 2.26.2