From nobody Mon Feb 9 11:47:20 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1611829649; cv=none; d=zohomail.com; s=zohoarc; b=euHbwwV4Pev7drvXuA3Z5QNG45YOV+xWQzPIJBLAeGL5GZWz7n3u9/4bnjDxgcEdYw1zeX3QT0AW7zib4YyEGxEHtnLi8Gtj40Vruc+7HXdfR4mEhII3D1l2ms2CFXKrgzIrc/pUFWN7A6hdA91zHcM0R9KPc4D4PS5L2av+g0U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611829649; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=sF+P/nAQ/ZYpIxhHLIs1TmEMiUR7MGK6AgT9TIwzibs=; b=aXdGVbQdJUNurhEEAxGsyw7h5L20XwGo+IP0fFICjKDFVC4gVLhuLXdvnrZzIs0nQ7uty/iNmGFZAXXBmG94psfujBiSqhQQBCstIBjVBP6uaqgv+Im8DoSnQyov8fbSwRDnZiYCeQyuSb0osso9nyodDTLT69zq0KV7RA2cyng= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1611829649868439.7293231302307; Thu, 28 Jan 2021 02:27:29 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-181-9gHAyih6OOiQlfNnnnWwHg-1; Thu, 28 Jan 2021 05:27:24 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 02406107ACF9; Thu, 28 Jan 2021 10:27:19 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CCA951F045; Thu, 28 Jan 2021 10:27:18 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 931D51809C9F; Thu, 28 Jan 2021 10:27:18 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 10SAOsCc026629 for ; Thu, 28 Jan 2021 05:24:55 -0500 Received: by smtp.corp.redhat.com (Postfix) id EF5AF10023BD; Thu, 28 Jan 2021 10:24:54 +0000 (UTC) Received: from work.redhat.com (ovpn-112-226.ams2.redhat.com [10.36.112.226]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4146310023BA; Thu, 28 Jan 2021 10:24:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611829646; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=sF+P/nAQ/ZYpIxhHLIs1TmEMiUR7MGK6AgT9TIwzibs=; b=aTznyAskZM2k1mmgtQdbNE5xxkmsr/+gnZsIasENf6dwuc8VObVLuEPNud7KypVZZ/z1DF 59Wz2KEnFrrtaklrzBCvSXvmueM7kLLosY+uCIb2sFtLhiRNuFPY2lXTnsrkA9hyupiK25 Du8tDxNsLUlO7exy95fweNt8ufvqzGQ= X-MC-Unique: 9gHAyih6OOiQlfNnnnWwHg-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH 08/11] tests: Prevent malloc with size 0 Date: Thu, 28 Jan 2021 11:24:38 +0100 Message-Id: <20210128102441.20241-9-twiederh@redhat.com> In-Reply-To: <20210128102441.20241-1-twiederh@redhat.com> References: <20210128102441.20241-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Found by clang-tidy's "clang-analyzer-optin.portability.UnixAPI" check. Signed-off-by: Tim Wiederhake --- tests/commandhelper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/commandhelper.c b/tests/commandhelper.c index ba5681b715..9394a42726 100644 --- a/tests/commandhelper.c +++ b/tests/commandhelper.c @@ -99,7 +99,7 @@ int main(int argc, char **argv) { origenv++; } =20 - if (!(newenv =3D malloc(sizeof(*newenv) * n))) + if ((n =3D=3D 0) || !(newenv =3D malloc(sizeof(*newenv) * n))) abort(); =20 origenv =3D environ; --=20 2.26.2