From nobody Mon Feb 9 12:15:31 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1611829536; cv=none; d=zohomail.com; s=zohoarc; b=Iv5WA1XDQh1fNpnk6xMm6vENy9b83B/pKLBslRNykNYxW5wsyZJII1UWcwTLHxxQxLhwrkdPSz1exUCLG6aig1aXcGMDZDFP9mTStjwUHsQpz1gKiyz4mddW7wiUweD8PJlqWSoKwcmsrDyJt9YYqoc2zeGVadD2kvUrU7Lzp04= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611829536; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=lkVSmdtqJ0m4WqNIT78YytfxGojFPn80DU8l6Z15Ayo=; b=UoXHYFpF0xjwNWCRxMmpbTrNCX9r6LR9lY/J8IzklFMEejOhqm7hkmTIXdewdudtqEUdeHVrW0dJ3xaCplKAThMd5EWhoGAq36C/dM90K8AaX1AeO+BUCsD8fCuoakbbiE7ykAfXuli4ZF8j3MxM6jLT3de6hawn2TIsqPG8ZcM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1611829536657505.8364014296152; Thu, 28 Jan 2021 02:25:36 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-500-5nqumeCVNZ-Its-D0KVbVg-1; Thu, 28 Jan 2021 05:25:33 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BA6EE107ACE3; Thu, 28 Jan 2021 10:25:27 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 985F75D9EF; Thu, 28 Jan 2021 10:25:27 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 626A350034; Thu, 28 Jan 2021 10:25:27 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 10SAOrOQ026624 for ; Thu, 28 Jan 2021 05:24:53 -0500 Received: by smtp.corp.redhat.com (Postfix) id E148210023BD; Thu, 28 Jan 2021 10:24:53 +0000 (UTC) Received: from work.redhat.com (ovpn-112-226.ams2.redhat.com [10.36.112.226]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2F02C10023BA; Thu, 28 Jan 2021 10:24:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611829535; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=lkVSmdtqJ0m4WqNIT78YytfxGojFPn80DU8l6Z15Ayo=; b=PDk9aNaEda2P95JL5C14xAidCZGFI/XsJEqPpHSuECHq1Da4mDJWlNQYdEIREBBXsLbV6y qlQDGXjztQ1mMvR207FS0gJKYcjhDRQPWH6FNlKbKRqRAymzgJ89Fh1XrIRD5M19UqL6fO HzwZ3B+DwKGNrPiUyPxntxqxEvtdmE4= X-MC-Unique: 5nqumeCVNZ-Its-D0KVbVg-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH 07/11] virhostuptime: Fix rounding in uptime calculation Date: Thu, 28 Jan 2021 11:24:37 +0100 Message-Id: <20210128102441.20241-8-twiederh@redhat.com> In-Reply-To: <20210128102441.20241-1-twiederh@redhat.com> References: <20210128102441.20241-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" "f + 0.5" does not round correctly for values very close to ".5" for every integer multiple, e.g. "0.499999975". Found by clang-tidy's "bugprone-incorrect-roundings" check. Signed-off-by: Tim Wiederhake --- src/util/virhostuptime.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/util/virhostuptime.c b/src/util/virhostuptime.c index 696a38fbb5..7508a5a9b6 100644 --- a/src/util/virhostuptime.c +++ b/src/util/virhostuptime.c @@ -32,6 +32,8 @@ #include "virtime.h" #include "virthread.h" =20 +#include + #define VIR_FROM_THIS VIR_FROM_NONE =20 VIR_LOG_INIT("util.virhostuptime"); @@ -76,7 +78,7 @@ virHostGetBootTimeProcfs(unsigned long long *btime) return -EINVAL; } =20 - *btime =3D now / 1000 - up + 0.5; + *btime =3D llround(now / 1000 - up); =20 return 0; } --=20 2.26.2