From nobody Mon Feb 9 12:15:24 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1611829685; cv=none; d=zohomail.com; s=zohoarc; b=ZCzyR+MkgyjaUD7Fgn2WXW9EVSDPKs0qvlZIQ5rPwxqNS//BKukeiGqi/Ic+5owL8ueR5PwuhsVZ/W1Xbu8m9ogtEk0LtJUqFYq1KEVmDqpXsQWTk5TNzwNLLF4Ipl2vu1eE6up1mtArXcxglWVA3ruMbt3ctoTIvKNwWmfi06A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611829685; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=S4j4N88J61VQE7e1eYQJ6r7XfddjP375W0zy6bH52jo=; b=bocuM1YgklRo7YIZL2SzxPDIjqhavIOaLpVSgyldSMrGBqbgqbESSvxkEXd5AAdzpQJqPJlY/5siDl8Ggc3r+65NFUj3Q3F4gRu/N9kAU44xEPmlKH4ytJ0vx/L8Jgs7cyjWdQmFjUhEGRoNw1A/vCMma0RE17fVyN2KNGtinDo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1611829685285715.582301365368; Thu, 28 Jan 2021 02:28:05 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-572-LG9bB44KP-ynod1fm9lA3A-1; Thu, 28 Jan 2021 05:27:30 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BE0C8100A647; Thu, 28 Jan 2021 10:27:24 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9AA2862AFA; Thu, 28 Jan 2021 10:27:24 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 5F97B1809CA3; Thu, 28 Jan 2021 10:27:24 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 10SAOwtH026663 for ; Thu, 28 Jan 2021 05:24:58 -0500 Received: by smtp.corp.redhat.com (Postfix) id 33EEA10023BD; Thu, 28 Jan 2021 10:24:58 +0000 (UTC) Received: from work.redhat.com (ovpn-112-226.ams2.redhat.com [10.36.112.226]) by smtp.corp.redhat.com (Postfix) with ESMTP id 71C6E100AE31; Thu, 28 Jan 2021 10:24:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611829684; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=S4j4N88J61VQE7e1eYQJ6r7XfddjP375W0zy6bH52jo=; b=cr0sqP0VHEYYGAn5Tna2CDdaraLdOaIyfcJr/m9R7F5E3YsiRvej83oEfml8UE5rka7e0z /cakwdAmPLMRBX8ktb0nNW27eLrVR9odIvDYOEHISWGZIGGnHPU//JOrMhjfMmCoLK6w4o 2LLb48qVOxmiYMsmuTdtV0pIa40q+fA= X-MC-Unique: LG9bB44KP-ynod1fm9lA3A-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH 11/11] vircommand: Simplify virCommandAddArg Date: Thu, 28 Jan 2021 11:24:41 +0100 Message-Id: <20210128102441.20241-12-twiederh@redhat.com> In-Reply-To: <20210128102441.20241-1-twiederh@redhat.com> References: <20210128102441.20241-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake --- src/util/vircommand.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/util/vircommand.c b/src/util/vircommand.c index 223010c6aa..f83d49ffac 100644 --- a/src/util/vircommand.c +++ b/src/util/vircommand.c @@ -1520,21 +1520,16 @@ virCommandAddEnvXDG(virCommandPtr cmd, const char *= baseDir) void virCommandAddArg(virCommandPtr cmd, const char *val) { - char *arg; - if (!cmd || cmd->has_error) return; =20 - arg =3D g_strdup(val); - /* Arg plus trailing NULL. */ if (VIR_RESIZE_N(cmd->args, cmd->maxargs, cmd->nargs, 1 + 1) < 0) { - VIR_FREE(arg); cmd->has_error =3D ENOMEM; return; } =20 - cmd->args[cmd->nargs++] =3D arg; + cmd->args[cmd->nargs++] =3D g_strdup(val); } =20 =20 --=20 2.26.2