From nobody Mon Feb 9 12:15:24 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1611829650; cv=none; d=zohomail.com; s=zohoarc; b=igX/+K9cBwgdCwWFokIX35tRUiIP9Wxi3/ADOkQpsOGvfECCweZ5079k13xk/Xr7dFMmHv5CtKoRPWr96Qqz6BkVvwqqepPVhuNQXC+NRj3zNHmyfTKAu12HaUptg13c8HqTHCfOif/7O61K7W5Nnqvu105oCVkmeKJ7jFrPc+w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611829650; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=h/yt9NwImjZidWX7Ip7Cgop4JLTA2RvjKBJIS430vLM=; b=JKDqNJZePMM/NPKgNF3P+MQbFoxexR45Z7Ru1N2cy6qJJxmgFaFIEvKcvlOpTdKV/A+ph957W1Qt8U8ONthivI/lAZHNIT2LNEBn0h7lTj/ePIlKFmxWTptVpRbwi3EiEDLYVG2DPQXl65AUkx46d8FLvqoILZz+EJmiiwQul68= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1611829650716285.3320236862106; Thu, 28 Jan 2021 02:27:30 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-528-P47K4QGIORuXYc_FuQFMTw-1; Thu, 28 Jan 2021 05:27:27 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 12BBC8049C7; Thu, 28 Jan 2021 10:27:22 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E322B62AFA; Thu, 28 Jan 2021 10:27:21 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id ABECB4E58E; Thu, 28 Jan 2021 10:27:21 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 10SAOv0K026651 for ; Thu, 28 Jan 2021 05:24:57 -0500 Received: by smtp.corp.redhat.com (Postfix) id 1CD86100AE30; Thu, 28 Jan 2021 10:24:57 +0000 (UTC) Received: from work.redhat.com (ovpn-112-226.ams2.redhat.com [10.36.112.226]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6284610023BD; Thu, 28 Jan 2021 10:24:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611829649; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=h/yt9NwImjZidWX7Ip7Cgop4JLTA2RvjKBJIS430vLM=; b=F1ndRjUIre96nqqenulxH21G7ho8V3hj4FvLmKgH4C9zaG5bspp0rjfkmh5tbg4qejrk/a PH39n4wqd04tKxqnV0RuTp5ZNt0IViJj+1O7xR+o4l07Bwx51Wy9fsZEzYvOAw9n1nPeGH sv7LVrKP96+nUIEbJqwlm1Kkq5fW/Eg= X-MC-Unique: P47K4QGIORuXYc_FuQFMTw-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH 10/11] vircommand: Remove NULL check in virCommandAddArg Date: Thu, 28 Jan 2021 11:24:40 +0100 Message-Id: <20210128102441.20241-11-twiederh@redhat.com> In-Reply-To: <20210128102441.20241-1-twiederh@redhat.com> References: <20210128102441.20241-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" `val` is declared `ATTRIBUTE_NONNULL`. Found by clang-tidy's "clang-diagnostic-tautological-pointer-compare" check. Signed-off-by: Tim Wiederhake --- src/util/vircommand.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/util/vircommand.c b/src/util/vircommand.c index c3a98bbeac..223010c6aa 100644 --- a/src/util/vircommand.c +++ b/src/util/vircommand.c @@ -1525,11 +1525,6 @@ virCommandAddArg(virCommandPtr cmd, const char *val) if (!cmd || cmd->has_error) return; =20 - if (val =3D=3D NULL) { - cmd->has_error =3D EINVAL; - return; - } - arg =3D g_strdup(val); =20 /* Arg plus trailing NULL. */ --=20 2.26.2