[PATCH] docs/interop/qmp-spec: Document the request queue limit

Markus Armbruster posted 1 patch 3 years, 2 months ago
Failed in applying to current master (apply log)
There is a newer version of this series
docs/interop/qmp-spec.txt | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
[PATCH] docs/interop/qmp-spec: Document the request queue limit
Posted by Markus Armbruster 3 years, 2 months ago
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 docs/interop/qmp-spec.txt | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/docs/interop/qmp-spec.txt b/docs/interop/qmp-spec.txt
index cdf5842555..b0e8351d5b 100644
--- a/docs/interop/qmp-spec.txt
+++ b/docs/interop/qmp-spec.txt
@@ -133,9 +133,11 @@ to pass "id" with out-of-band commands.  Passing it with all commands
 is recommended for clients that accept capability "oob".
 
 If the client sends in-band commands faster than the server can
-execute them, the server will stop reading the requests from the QMP
-channel until the request queue length is reduced to an acceptable
-range.
+execute them, the server will stop reading requests until the request
+queue length is reduced to an acceptable range.
+
+To ensure commands to be executed out-of-band get read and executed,
+the client should have at most eight in-band commands in flight.
 
 Only a few commands support out-of-band execution.  The ones that do
 have "allow-oob": true in output of query-qmp-schema.
-- 
2.26.2


Re: [PATCH] docs/interop/qmp-spec: Document the request queue limit
Posted by John Snow 3 years, 2 months ago
On 1/27/21 9:47 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>   docs/interop/qmp-spec.txt | 8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/docs/interop/qmp-spec.txt b/docs/interop/qmp-spec.txt
> index cdf5842555..b0e8351d5b 100644
> --- a/docs/interop/qmp-spec.txt
> +++ b/docs/interop/qmp-spec.txt
> @@ -133,9 +133,11 @@ to pass "id" with out-of-band commands.  Passing it with all commands
>   is recommended for clients that accept capability "oob".
>   
>   If the client sends in-band commands faster than the server can
> -execute them, the server will stop reading the requests from the QMP
> -channel until the request queue length is reduced to an acceptable
> -range.
> +execute them, the server will stop reading requests until the request
> +queue length is reduced to an acceptable range.
> +
> +To ensure commands to be executed out-of-band get read and executed,
> +the client should have at most eight in-band commands in flight.
>   
>   Only a few commands support out-of-band execution.  The ones that do
>   have "allow-oob": true in output of query-qmp-schema.
> 

Great to know, thank you!

Reviewed-by: John Snow <jsnow@redhat.com>

Re: [PATCH] docs/interop/qmp-spec: Document the request queue limit
Posted by Markus Armbruster 3 years, 1 month ago
Queued.