From nobody Mon Feb 9 13:57:23 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1611364553; cv=none; d=zohomail.com; s=zohoarc; b=B62WNFLtOvdjRPJ1OvYF7sS5dxbRE7Cux9/vz10mlgvAJO17GYDMftD89WcikO8tBmUjFlnp/rBZy+b+cR02HPipTdNaQrLj/6mcaI46kEmiY9aXkpshx4cNCFlHo+785nXU8TK9oJNWnnCHUrgEYLi/CZExs89ZqE4pP16iigg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611364553; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=r9ILmJK0e3VTCSwZAPhciwTAOC8i6ZPvXWtJk0nkob8=; b=nPX1l4z0tPKt7HO1CYwwPy+D60Xxqi9nDo+b5TEBhCPpMl7lkZbrsjtJOyzy2v6TITHAK2ILP/y3gFK5W7cNOjyYr/im0SfS9gxx3ZtMdIqwyMwbXgX9FUxeu60RN3LKb+CbJhyX7ApXVIlipXwm6o/Cu/N5oBrqm+rLk6wmELw= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 161136455316421.606142025560985; Fri, 22 Jan 2021 17:15:53 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-372-QIyAo3XKMhWRetPZPJPFgw-1; Fri, 22 Jan 2021 20:15:49 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 65E1215729; Sat, 23 Jan 2021 01:15:44 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3D4F31992D; Sat, 23 Jan 2021 01:15:44 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 03DEB50032; Sat, 23 Jan 2021 01:15:44 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 10N1Ba5b001181 for ; Fri, 22 Jan 2021 20:11:36 -0500 Received: by smtp.corp.redhat.com (Postfix) id 9F0FF2026D5D; Sat, 23 Jan 2021 01:11:36 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast03.extmail.prod.ext.rdu2.redhat.com [10.11.55.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9A3BD2026D46 for ; Sat, 23 Jan 2021 01:11:36 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 86707811E76 for ; Sat, 23 Jan 2021 01:11:36 +0000 (UTC) Received: from mail-qk1-f179.google.com (mail-qk1-f179.google.com [209.85.222.179]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-407-ZdmVAL7AOzq-QatvRaLABQ-1; Fri, 22 Jan 2021 20:11:34 -0500 Received: by mail-qk1-f179.google.com with SMTP id z11so7085330qkj.7 for ; Fri, 22 Jan 2021 17:11:33 -0800 (PST) Received: from localhost (209-6-122-159.s2973.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [209.6.122.159]) by smtp.gmail.com with ESMTPSA id 8sm7333242qkr.28.2021.01.22.17.11.32 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Jan 2021 17:11:33 -0800 (PST) X-MC-Unique: QIyAo3XKMhWRetPZPJPFgw-1 X-MC-Unique: ZdmVAL7AOzq-QatvRaLABQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=r9ILmJK0e3VTCSwZAPhciwTAOC8i6ZPvXWtJk0nkob8=; b=Hzc/WO/3YbQTIHWmnWcgA9x8kPNq7cyM122uSvQFxo7ayhvIQzQlqhP5CSqIEdw/fy feWZowjvA06Xl6u3x9sTuZU6LWrmulEWDEisp/0esdKBRFftklDTw1crgLv1AU6x9vca FJc+IDfkjFMWcZ/NMQmhKc8W744hx2uOc00YzmRF5ni/ST+QXMt4xcxLqStYRLzdVB7B 23K27AvgxctpYsjaAQd16WOiasU6VegzN8xA6qfJxSmrDCZHkbvPRDBRG70euiF3lJSA FRGER+JAD9q5ITQxBy0alWoO8adAUvKdLbb06KCvtzjfaX8HBQ4B73Mfz1USAPAA/sr5 DhOw== X-Gm-Message-State: AOAM5338iQrB9HbQcfZaRU/kpIIwlk9aMewAVG6Eo6I7f6Y6SyBMBw39 DgAzB1r1HKMA2JUYiH41NvWD+k+LBQ== X-Google-Smtp-Source: ABdhPJxFzHHFyzIvDevUxa6IIclXa24SeyU5K9CDHwadNrIruqkzkVZri8gP5t/cFrHWudPALBdxRA== X-Received: by 2002:a05:620a:1139:: with SMTP id p25mr7497630qkk.9.1611364293403; Fri, 22 Jan 2021 17:11:33 -0800 (PST) From: Masayoshi Mizuma To: libvir-list@redhat.com Subject: [RFC PATCH 7/7] qemu: Add virtio disks as sharable transient disks Date: Fri, 22 Jan 2021 20:11:06 -0500 Message-Id: <20210123011106.11126-8-msys.mizuma@gmail.com> In-Reply-To: <20210123011106.11126-1-msys.mizuma@gmail.com> References: <20210123011106.11126-1-msys.mizuma@gmail.com> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Cc: Masayoshi Mizuma , Masayoshi Mizuma X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 2 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Masayoshi Mizuma Add virtio disks to be sharable transient disks. Signed-off-by: Masayoshi Mizuma --- src/qemu/qemu_hotplug.c | 13 ++++++++----- src/qemu/qemu_process.c | 2 +- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 5d0445538d..fc6ca028e3 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -814,7 +814,9 @@ qemuDomainAttachDiskGeneric(virQEMUDriverPtr driver, static int qemuDomainAttachVirtioDiskDevice(virQEMUDriverPtr driver, virDomainObjPtr vm, - virDomainDiskDefPtr disk) + virDomainDiskDefPtr disk, + int bootindex, + qemuDomainAsyncJob asyncJob) { virDomainDeviceDef dev =3D { VIR_DOMAIN_DEVICE_DISK, { .disk =3D disk = } }; bool releaseaddr =3D false; @@ -823,8 +825,8 @@ qemuDomainAttachVirtioDiskDevice(virQEMUDriverPtr drive= r, if (qemuDomainEnsureVirtioAddress(&releaseaddr, vm, &dev, disk->dst) <= 0) return -1; =20 - if ((rv =3D qemuDomainAttachDiskGeneric(driver, vm, disk, 0, - QEMU_ASYNC_JOB_NONE)) < 0) { + if ((rv =3D qemuDomainAttachDiskGeneric(driver, vm, disk, bootindex, + asyncJob)) < 0) { if (rv =3D=3D -1 && releaseaddr) qemuDomainReleaseDeviceAddress(vm, &disk->info); =20 @@ -1033,7 +1035,7 @@ static int qemuDomainAttachDeviceDiskLiveInternal(virQEMUDriverPtr driver, virDomainObjPtr vm, virDomainDeviceDefPtr dev, - qemuDomainAsyncJob asyncJob G_GNUC_= UNUSED) + qemuDomainAsyncJob asyncJob) { size_t i; virDomainDiskDefPtr disk =3D dev->data.disk; @@ -1080,7 +1082,8 @@ qemuDomainAttachDeviceDiskLiveInternal(virQEMUDriverP= tr driver, break; =20 case VIR_DOMAIN_DISK_BUS_VIRTIO: - ret =3D qemuDomainAttachVirtioDiskDevice(driver, vm, disk); + ret =3D qemuDomainAttachVirtioDiskDevice(driver, vm, disk, + disk->info.bootIndex, async= Job); break; =20 case VIR_DOMAIN_DISK_BUS_SCSI: diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 2e2d1c6fea..55577632c5 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -6907,7 +6907,7 @@ qemuCheckTransientDiskSharable(virDomainObjPtr vm) for (i =3D 0; i < vm->def->ndisks; i++) { virDomainDiskDefPtr disk =3D vm->def->disks[i]; =20 - if (disk->transient && disk->bus !=3D VIR_DOMAIN_DISK_BUS_LAST) + if (disk->transient && disk->bus !=3D VIR_DOMAIN_DISK_BUS_VIRTIO) return; } =20 --=20 2.27.0