From nobody Mon Feb 9 10:47:59 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1611364542; cv=none; d=zohomail.com; s=zohoarc; b=SCrD4TfwyerwrDz+xsKKawmmxaehcfB9Z5k0WVhJBt+ew1ZfF9MOO8G9gHsxfredUQRfK5ZHf3LVtegJSbzvYue7ZrWVcu27bJYGE+Tu3DfkJH1ooMujIWlT01FLT8wA2HYgMFB3VkdgPgc8JCcHktVJsfzWSA3nJjuuk822okA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611364542; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=Sz0FZ7rkTfbl3QaQAd5rqvcqm33ntHA5riE3MuuC+uM=; b=bhczx1dp9BOa6v1kRn42LjPGQi0fCMSHPyPC+vbEoRbptbiT+1StKHCakssCgoFR2ejbyBNOfvxr6dyv67K9PuyoEllM4MXul+vaVM8YqZmfX/pMJUEwZ9vvAoZx5GSkICts4YV7pWe497jE08FcSNa0wTKNMqWZr4g+lvaiQGo= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1611364542651636.2058087305288; Fri, 22 Jan 2021 17:15:42 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-438-DBznBBzpPX-VBIMpC3dZnw-1; Fri, 22 Jan 2021 20:15:39 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D15F41005D44; Sat, 23 Jan 2021 01:15:30 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2FC3471D4D; Sat, 23 Jan 2021 01:15:30 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id ED6E05002D; Sat, 23 Jan 2021 01:15:29 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 10N1BUJB001126 for ; Fri, 22 Jan 2021 20:11:31 -0500 Received: by smtp.corp.redhat.com (Postfix) id CA1F6F101D; Sat, 23 Jan 2021 01:11:30 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast04.extmail.prod.ext.rdu2.redhat.com [10.11.55.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C3D01F11CB for ; Sat, 23 Jan 2021 01:11:30 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 62F36100FBC6 for ; Sat, 23 Jan 2021 01:11:30 +0000 (UTC) Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-592-dIqPZoeHNrqlyi1lFZqhhg-1; Fri, 22 Jan 2021 20:11:28 -0500 Received: by mail-qk1-f175.google.com with SMTP id x81so4217968qkb.0 for ; Fri, 22 Jan 2021 17:11:28 -0800 (PST) Received: from localhost (209-6-122-159.s2973.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [209.6.122.159]) by smtp.gmail.com with ESMTPSA id u7sm7199663qke.116.2021.01.22.17.11.26 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Jan 2021 17:11:27 -0800 (PST) X-MC-Unique: DBznBBzpPX-VBIMpC3dZnw-1 X-MC-Unique: dIqPZoeHNrqlyi1lFZqhhg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Sz0FZ7rkTfbl3QaQAd5rqvcqm33ntHA5riE3MuuC+uM=; b=QW+lKxDbQrGN/h+ixJX026uGct3XPfjCy5bRXMEdm+XQDAqIqm/504DU3kwzJVhl6P DRUIqFzhcv1rXMUvcvm8uiFU1Q1xlRXBzMeJotiInZQiy9sShuxikOwVR/E9b+2OoklU uHNzJ8f+M0IcfVYvyEFjLk4lcP7GI8XWJ3f8ILTrHlttBnKZ37kUEqp511LA/Ns85fHM RkMtzsALrq+JRo0tcaLyHYuWHBfyUDKUnIuOajKbvA97PfyM2o65Dbemenx07kGruOUu CJp8dRLywUQRCVf4iD3VGZ/2ogoKGlXnauIms2OKhLt0FvOyY/H/Cg1laensQiiB+qF5 9XZg== X-Gm-Message-State: AOAM533Wfiv/0w0VTC+SJNjwA+Lx9GFS1j7lO5CO4MJZajAIq2nG3PWh LG8QZSpuGT2sPpmy2gPYISx/D7h4LQ== X-Google-Smtp-Source: ABdhPJwhaKq0UnWXfglSUrz1sKmD9J/mrqzy+5bZR/KqulpkHOA+zVJM+3YuWJk0qxBMLraY+81C3A== X-Received: by 2002:a37:809:: with SMTP id 9mr7431455qki.156.1611364287704; Fri, 22 Jan 2021 17:11:27 -0800 (PST) From: Masayoshi Mizuma To: libvir-list@redhat.com Subject: [RFC PATCH 3/7] qemu_hotplug: Add asynJob argument to qemuDomainRemoveDiskDevice Date: Fri, 22 Jan 2021 20:11:02 -0500 Message-Id: <20210123011106.11126-4-msys.mizuma@gmail.com> In-Reply-To: <20210123011106.11126-1-msys.mizuma@gmail.com> References: <20210123011106.11126-1-msys.mizuma@gmail.com> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-loop: libvir-list@redhat.com Cc: Masayoshi Mizuma , Masayoshi Mizuma X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 2 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Masayoshi Mizuma Add asynJob argument to qemuDomainRemoveDiskDevice() so that it can be used before CPUs start. Signed-off-by: Masayoshi Mizuma --- src/qemu/qemu_hotplug.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index a61899d53a..b989652533 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -4302,7 +4302,8 @@ static bool qemuIsMultiFunctionDevice(virDomainDefPtr= def, static int qemuDomainRemoveDiskDevice(virQEMUDriverPtr driver, virDomainObjPtr vm, - virDomainDiskDefPtr disk) + virDomainDiskDefPtr disk, + qemuDomainAsyncJob asyncJob) { qemuDomainDiskPrivatePtr diskPriv =3D QEMU_DOMAIN_DISK_PRIVATE(disk); g_autoptr(qemuBlockStorageSourceChainData) diskBackend =3D NULL; @@ -4347,7 +4348,8 @@ qemuDomainRemoveDiskDevice(virQEMUDriverPtr driver, } } =20 - qemuDomainObjEnterMonitor(driver, vm); + if (qemuDomainObjEnterMonitorAsync(driver, vm, asyncJob) < 0) + goto cleanup; =20 if (corAlias) ignore_value(qemuMonitorBlockdevDel(priv->mon, corAlias)); @@ -5093,7 +5095,8 @@ qemuDomainRemoveDevice(virQEMUDriverPtr driver, * into this function. */ case VIR_DOMAIN_DEVICE_DISK: - if (qemuDomainRemoveDiskDevice(driver, vm, dev->data.disk) < 0) + if (qemuDomainRemoveDiskDevice(driver, vm, dev->data.disk, + QEMU_ASYNC_JOB_NONE) < 0) return -1; break; case VIR_DOMAIN_DEVICE_CONTROLLER: --=20 2.27.0