From nobody Mon Feb 9 10:47:52 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1611364547; cv=none; d=zohomail.com; s=zohoarc; b=SO7RLAZSbCkR6soJ0eE56h7FpPuWi/9u6PaKdP6RufZ2qBs7Yzos+i2WXKb6RkvYsrgkpWj239EMM97yx+R0gjTuk7qdbtSEarzwVHtkOreLjygWw8DCL2B/hIC6EZKyZ2BBa12HpSKIOpEalFoASN1SeYS6t3F20JIRKudp+us= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611364547; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=zmOduyRI7eErkPS0iANFmvw2eIbEXPMZe5QQRfvRMvQ=; b=ZmM3IX0FooSrEZU0Tdw4N+sif0Sw416V+pdc8U0lvZEXI6oerm45cEWE5CFvcEWYyQx8pkaoesaZAKOQk3wr5UyWR9+SxE0pLhW4k+dWMhvrluWdpNEia/xp1P3BBk2Y+RKgw7eu2uOawtBGqaDyrNtBrN0NFVVHXLpeLiWQmlc= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1611364547567272.2100667931825; Fri, 22 Jan 2021 17:15:47 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-35-cy1OG2UCOTWaVgo_fMn0hw-1; Fri, 22 Jan 2021 20:15:44 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5ADFD15720; Sat, 23 Jan 2021 01:15:38 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3AAC8709AD; Sat, 23 Jan 2021 01:15:38 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 081531809CA3; Sat, 23 Jan 2021 01:15:38 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 10N1BVZO001139 for ; Fri, 22 Jan 2021 20:11:31 -0500 Received: by smtp.corp.redhat.com (Postfix) id 92EB52026D5D; Sat, 23 Jan 2021 01:11:31 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast04.extmail.prod.ext.rdu2.redhat.com [10.11.55.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8E1482026D46 for ; Sat, 23 Jan 2021 01:11:29 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 195E7100FBC5 for ; Sat, 23 Jan 2021 01:11:29 +0000 (UTC) Received: from mail-qk1-f176.google.com (mail-qk1-f176.google.com [209.85.222.176]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-267-Hv0M3XpFMxqhnbKt0kw8Rw-1; Fri, 22 Jan 2021 20:11:26 -0500 Received: by mail-qk1-f176.google.com with SMTP id x81so4217937qkb.0 for ; Fri, 22 Jan 2021 17:11:26 -0800 (PST) Received: from localhost (209-6-122-159.s2973.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [209.6.122.159]) by smtp.gmail.com with ESMTPSA id x64sm3936372qtd.15.2021.01.22.17.11.25 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Jan 2021 17:11:25 -0800 (PST) X-MC-Unique: cy1OG2UCOTWaVgo_fMn0hw-1 X-MC-Unique: Hv0M3XpFMxqhnbKt0kw8Rw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=zmOduyRI7eErkPS0iANFmvw2eIbEXPMZe5QQRfvRMvQ=; b=MkvI8MlSI4KR4w89cLfQUjWf8KQ+kr15CthhqoECzscZOfVFFLBL/2g51YbwDBcN2O zPcJkDVc/H+YsILvqpQcWT36j9Ph/B9zNzXcHVWL1ihKjZA+77nGfbRQGYmaaSVg9cgi Pkn7JHGKiCePaHyuiRCeAVSrrY/R9b1P6mKcMI+Ag3JVxh/F4qwSaMjfqqN3xQeeVZHO UZWwdwRxgPR5DSoDDx6tEVvvQkqdtWR3jcaRhoDTFrzcWUMIw0PpT5MlruwhvmBYOp3H Bb1SmJIRoWWBaGAA6/LDU6b1lKf753IRPRJBRUKoWzOL+4RNlLBD0lDR/dmXUfqQNdvG 2WKQ== X-Gm-Message-State: AOAM53047WISk1fTpYnpePfnOmOYs8ESSdaYRAUOfaGr3mSJy1KRKzPB GwSQfe07pm9LPxXkM9cfYsNP2xTPcw== X-Google-Smtp-Source: ABdhPJyi4YYL9ZjP0/zplhx0UALS52NwvWSDdfVmBj9+2NUCkhi+nihLfSY7eRlOzMQEABaRTKAOBg== X-Received: by 2002:a37:afc2:: with SMTP id y185mr7623370qke.499.1611364286328; Fri, 22 Jan 2021 17:11:26 -0800 (PST) From: Masayoshi Mizuma To: libvir-list@redhat.com Subject: [RFC PATCH 2/7] qemu_hotplug: Add asyncJob argument to qemuDomainAttachDeviceDiskLiveInternal Date: Fri, 22 Jan 2021 20:11:01 -0500 Message-Id: <20210123011106.11126-3-msys.mizuma@gmail.com> In-Reply-To: <20210123011106.11126-1-msys.mizuma@gmail.com> References: <20210123011106.11126-1-msys.mizuma@gmail.com> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Cc: Masayoshi Mizuma , Masayoshi Mizuma X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 2 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Masayoshi Mizuma Add asynJob argument to qemuDomainAttachDeviceDiskLiveInternal() so that it= can be used before CPUs start. To avoid a compile warning, G_GNUC_UNUSED is add= ed here. A later patch will remove G_GNUC_UNUSED. Signed-off-by: Masayoshi Mizuma --- src/qemu/qemu_hotplug.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 609e9d1a8a..a61899d53a 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -1030,7 +1030,8 @@ qemuDomainAttachUSBMassStorageDevice(virQEMUDriverPtr= driver, static int qemuDomainAttachDeviceDiskLiveInternal(virQEMUDriverPtr driver, virDomainObjPtr vm, - virDomainDeviceDefPtr dev) + virDomainDeviceDefPtr dev, + qemuDomainAsyncJob asyncJob G_GNUC_= UNUSED) { size_t i; virDomainDiskDefPtr disk =3D dev->data.disk; @@ -1138,7 +1139,7 @@ qemuDomainAttachDeviceDiskLive(virQEMUDriverPtr drive= r, return 0; } =20 - return qemuDomainAttachDeviceDiskLiveInternal(driver, vm, dev); + return qemuDomainAttachDeviceDiskLiveInternal(driver, vm, dev, QEMU_AS= YNC_JOB_NONE); } =20 =20 --=20 2.27.0