[libvirt PATCH 0/2] meson: Fix cross-building of dtrace probes

Andrea Bolognani posted 2 patches 3 years, 2 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20210120165405.247294-1-abologna@redhat.com
ci/containers/ci-centos-7.Dockerfile                     | 2 +-
ci/containers/ci-centos-8.Dockerfile                     | 2 +-
ci/containers/ci-centos-stream.Dockerfile                | 2 +-
ci/containers/ci-debian-10-cross-aarch64.Dockerfile      | 3 ++-
ci/containers/ci-debian-10-cross-armv6l.Dockerfile       | 3 ++-
ci/containers/ci-debian-10-cross-armv7l.Dockerfile       | 3 ++-
ci/containers/ci-debian-10-cross-i686.Dockerfile         | 3 ++-
ci/containers/ci-debian-10-cross-mips.Dockerfile         | 3 ++-
ci/containers/ci-debian-10-cross-mips64el.Dockerfile     | 3 ++-
ci/containers/ci-debian-10-cross-mipsel.Dockerfile       | 3 ++-
ci/containers/ci-debian-10-cross-ppc64le.Dockerfile      | 3 ++-
ci/containers/ci-debian-10-cross-s390x.Dockerfile        | 3 ++-
ci/containers/ci-debian-10.Dockerfile                    | 2 +-
ci/containers/ci-debian-sid-cross-aarch64.Dockerfile     | 3 ++-
ci/containers/ci-debian-sid-cross-armv6l.Dockerfile      | 3 ++-
ci/containers/ci-debian-sid-cross-armv7l.Dockerfile      | 3 ++-
ci/containers/ci-debian-sid-cross-i686.Dockerfile        | 3 ++-
ci/containers/ci-debian-sid-cross-mips64el.Dockerfile    | 3 ++-
ci/containers/ci-debian-sid-cross-mipsel.Dockerfile      | 3 ++-
ci/containers/ci-debian-sid-cross-ppc64le.Dockerfile     | 3 ++-
ci/containers/ci-debian-sid-cross-s390x.Dockerfile       | 3 ++-
ci/containers/ci-debian-sid.Dockerfile                   | 2 +-
ci/containers/ci-fedora-32.Dockerfile                    | 2 +-
ci/containers/ci-fedora-33.Dockerfile                    | 2 +-
ci/containers/ci-fedora-rawhide-cross-mingw32.Dockerfile | 2 +-
ci/containers/ci-fedora-rawhide-cross-mingw64.Dockerfile | 2 +-
ci/containers/ci-fedora-rawhide.Dockerfile               | 2 +-
ci/containers/ci-opensuse-152.Dockerfile                 | 2 +-
ci/containers/ci-ubuntu-1804.Dockerfile                  | 2 +-
ci/containers/ci-ubuntu-2004.Dockerfile                  | 2 +-
meson.build                                              | 1 +
src/meson.build                                          | 4 ++--
src/qemu/meson.build                                     | 4 ++--
33 files changed, 52 insertions(+), 34 deletions(-)
[libvirt PATCH 0/2] meson: Fix cross-building of dtrace probes
Posted by Andrea Bolognani 3 years, 2 months ago
We didn't spot this issue before simply because we're not
installing dtrace in the cross-building environments.

Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/244473178
libvirt-ci MR: https://gitlab.com/libvirt/libvirt-ci/-/merge_requests/82

Andrea Bolognani (1):
  ci: Refresh dockerfiles

Helmut Grohne (1):
  meson: Fix cross-building of dtrace probes

 ci/containers/ci-centos-7.Dockerfile                     | 2 +-
 ci/containers/ci-centos-8.Dockerfile                     | 2 +-
 ci/containers/ci-centos-stream.Dockerfile                | 2 +-
 ci/containers/ci-debian-10-cross-aarch64.Dockerfile      | 3 ++-
 ci/containers/ci-debian-10-cross-armv6l.Dockerfile       | 3 ++-
 ci/containers/ci-debian-10-cross-armv7l.Dockerfile       | 3 ++-
 ci/containers/ci-debian-10-cross-i686.Dockerfile         | 3 ++-
 ci/containers/ci-debian-10-cross-mips.Dockerfile         | 3 ++-
 ci/containers/ci-debian-10-cross-mips64el.Dockerfile     | 3 ++-
 ci/containers/ci-debian-10-cross-mipsel.Dockerfile       | 3 ++-
 ci/containers/ci-debian-10-cross-ppc64le.Dockerfile      | 3 ++-
 ci/containers/ci-debian-10-cross-s390x.Dockerfile        | 3 ++-
 ci/containers/ci-debian-10.Dockerfile                    | 2 +-
 ci/containers/ci-debian-sid-cross-aarch64.Dockerfile     | 3 ++-
 ci/containers/ci-debian-sid-cross-armv6l.Dockerfile      | 3 ++-
 ci/containers/ci-debian-sid-cross-armv7l.Dockerfile      | 3 ++-
 ci/containers/ci-debian-sid-cross-i686.Dockerfile        | 3 ++-
 ci/containers/ci-debian-sid-cross-mips64el.Dockerfile    | 3 ++-
 ci/containers/ci-debian-sid-cross-mipsel.Dockerfile      | 3 ++-
 ci/containers/ci-debian-sid-cross-ppc64le.Dockerfile     | 3 ++-
 ci/containers/ci-debian-sid-cross-s390x.Dockerfile       | 3 ++-
 ci/containers/ci-debian-sid.Dockerfile                   | 2 +-
 ci/containers/ci-fedora-32.Dockerfile                    | 2 +-
 ci/containers/ci-fedora-33.Dockerfile                    | 2 +-
 ci/containers/ci-fedora-rawhide-cross-mingw32.Dockerfile | 2 +-
 ci/containers/ci-fedora-rawhide-cross-mingw64.Dockerfile | 2 +-
 ci/containers/ci-fedora-rawhide.Dockerfile               | 2 +-
 ci/containers/ci-opensuse-152.Dockerfile                 | 2 +-
 ci/containers/ci-ubuntu-1804.Dockerfile                  | 2 +-
 ci/containers/ci-ubuntu-2004.Dockerfile                  | 2 +-
 meson.build                                              | 1 +
 src/meson.build                                          | 4 ++--
 src/qemu/meson.build                                     | 4 ++--
 33 files changed, 52 insertions(+), 34 deletions(-)

-- 
2.26.2


Re: [libvirt PATCH 0/2] meson: Fix cross-building of dtrace probes
Posted by Andrea Bolognani 3 years, 2 months ago
On Wed, 2021-01-20 at 17:54 +0100, Andrea Bolognani wrote:
> We didn't spot this issue before simply because we're not
> installing dtrace in the cross-building environments.
> 
> Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/244473178
> libvirt-ci MR: https://gitlab.com/libvirt/libvirt-ci/-/merge_requests/82
> 
> Andrea Bolognani (1):
>   ci: Refresh dockerfiles
> 
> Helmut Grohne (1):
>   meson: Fix cross-building of dtrace probes

Ping?

I'm keen on merging this sooner rather than later because the
libvirt-ci change has already been merged and so, if for some
unrelated reason we will need to refresh the Dockerfiles, without
these Meson changes that will result in all cross-builds suddenly
failing.

-- 
Andrea Bolognani / Red Hat / Virtualization

Re: [libvirt PATCH 0/2] meson: Fix cross-building of dtrace probes
Posted by Daniel P. Berrangé 3 years, 2 months ago
On Wed, Jan 20, 2021 at 05:54:03PM +0100, Andrea Bolognani wrote:
> We didn't spot this issue before simply because we're not
> installing dtrace in the cross-building environments.
> 
> Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/244473178
> libvirt-ci MR: https://gitlab.com/libvirt/libvirt-ci/-/merge_requests/82
> 
> Andrea Bolognani (1):
>   ci: Refresh dockerfiles
> 
> Helmut Grohne (1):
>   meson: Fix cross-building of dtrace probes

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|