[libvirt PATCH] docs: Clarify use of virtio-scsi model for SCSI controllers

Andrea Bolognani posted 1 patch 3 years, 2 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20210119143840.184363-1-abologna@redhat.com
docs/formatdomain.rst | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
[libvirt PATCH] docs: Clarify use of virtio-scsi model for SCSI controllers
Posted by Andrea Bolognani 3 years, 2 months ago
The current formulation can lead people to believe SCSI
controllers only allow the virtio-scsi model, but really the
only difference is that you have to use model='virtio-scsi'
where you would use model='virtio' for another device.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 docs/formatdomain.rst | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
index dd197d8f6a..af540391db 100644
--- a/docs/formatdomain.rst
+++ b/docs/formatdomain.rst
@@ -3428,8 +3428,10 @@ machine types, accept the following ``model`` values:
 While the information outlined above applies to most virtio devices, there are a
 few exceptions:
 
--  for SCSI controllers, ``virtio-scsi`` must be used instead of ``virtio`` for
-   backwards compatibility reasons;
+-  for SCSI controllers, there is no ``virtio`` model available due to
+   historical reasons: use ``virtio-scsi`` instead, which behaves the same as
+   ``virtio`` does for other devices. Both ``virtio-transitional`` and
+   ``virtio-non-transitional`` work with SCSI controllers;
 -  some devices, such as GPUs and input devices (keyboard, tablet and mouse),
    are only defined in the virtio 1.0 spec and as such don't have a transitional
    variant: the only accepted model is ``virtio``, which will result in a
-- 
2.26.2

Re: [libvirt PATCH] docs: Clarify use of virtio-scsi model for SCSI controllers
Posted by Jiri Denemark 3 years, 2 months ago
On Tue, Jan 19, 2021 at 15:38:40 +0100, Andrea Bolognani wrote:
> The current formulation can lead people to believe SCSI
> controllers only allow the virtio-scsi model, but really the
> only difference is that you have to use model='virtio-scsi'
> where you would use model='virtio' for another device.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  docs/formatdomain.rst | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
> index dd197d8f6a..af540391db 100644
> --- a/docs/formatdomain.rst
> +++ b/docs/formatdomain.rst
> @@ -3428,8 +3428,10 @@ machine types, accept the following ``model`` values:
>  While the information outlined above applies to most virtio devices, there are a
>  few exceptions:
>  
> --  for SCSI controllers, ``virtio-scsi`` must be used instead of ``virtio`` for
> -   backwards compatibility reasons;
> +-  for SCSI controllers, there is no ``virtio`` model available due to
> +   historical reasons: use ``virtio-scsi`` instead, which behaves the same as
> +   ``virtio`` does for other devices. Both ``virtio-transitional`` and
> +   ``virtio-non-transitional`` work with SCSI controllers;
>  -  some devices, such as GPUs and input devices (keyboard, tablet and mouse),
>     are only defined in the virtio 1.0 spec and as such don't have a transitional
>     variant: the only accepted model is ``virtio``, which will result in a

Reviewed-by: Jiri Denemark <jdenemar@redhat.com>