According to meson.build, and the actual code, Xen 4.6+ is required.
Drop the version, they is mentioned in meson.build.
Signed-off-by: Olaf Hering <olaf@aepfle.de>
---
libvirt.spec.in | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index 0a8b0ebad4..470631f7bd 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -126,7 +126,7 @@
%endif
# RHEL doesn't ship OpenVZ, VBox, PowerHypervisor,
-# VMware, libxenlight (Xen 4.1 and newer),
+# VMware, libxenlight
# or HyperV.
%if 0%{?rhel}
%define with_openvz 0
@@ -272,7 +272,7 @@ BuildRequires: perl
BuildRequires: python3
BuildRequires: systemd-units
%if %{with_libxl}
-BuildRequires: xen-devel
+BuildRequires: pkgconfig(xenlight)
%endif
BuildRequires: glib2-devel >= 2.48
BuildRequires: libxml2-devel
On Fri, Jan 8, 2021 at 5:26 AM Olaf Hering <olaf@aepfle.de> wrote: > > According to meson.build, and the actual code, Xen 4.6+ is required. > Drop the version, they is mentioned in meson.build. > > Signed-off-by: Olaf Hering <olaf@aepfle.de> > --- > libvirt.spec.in | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libvirt.spec.in b/libvirt.spec.in > index 0a8b0ebad4..470631f7bd 100644 > --- a/libvirt.spec.in > +++ b/libvirt.spec.in > @@ -126,7 +126,7 @@ > %endif > > # RHEL doesn't ship OpenVZ, VBox, PowerHypervisor, > -# VMware, libxenlight (Xen 4.1 and newer), > +# VMware, libxenlight > # or HyperV. > %if 0%{?rhel} > %define with_openvz 0 > @@ -272,7 +272,7 @@ BuildRequires: perl > BuildRequires: python3 > BuildRequires: systemd-units > %if %{with_libxl} > -BuildRequires: xen-devel > +BuildRequires: pkgconfig(xenlight) > %endif > BuildRequires: glib2-devel >= 2.48 > BuildRequires: libxml2-devel > Why are we changing to `pkgconfig(xenlight)` from xen-devel? It looks like xen-devel provides that name... -- 真実はいつも一つ!/ Always, there's only one truth!
Am Fri, 8 Jan 2021 14:39:43 -0500 schrieb Neal Gompa <ngompa13@gmail.com>: > Why are we changing to `pkgconfig(xenlight)` from xen-devel? It looks > like xen-devel provides that name... Because meson, and configure.ac, checks for entries in the pkgconfig namespace. Olaf
On Fri, Jan 08, 2021 at 08:48:09PM +0100, Olaf Hering wrote: > Am Fri, 8 Jan 2021 14:39:43 -0500 > schrieb Neal Gompa <ngompa13@gmail.com>: > > > Why are we changing to `pkgconfig(xenlight)` from xen-devel? It looks > > like xen-devel provides that name... > > Because meson, and configure.ac, checks for entries in the pkgconfig namespace. which the xen-devel package satisfies already, so this isn't needed. Consistency is more important and thus far we don't use the pkgconfig virtual deps. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
© 2016 - 2024 Red Hat, Inc.