[PATCH 0/2] fix re-attach of bridge device for <interface type='bridge'>

Laine Stump posted 2 patches 1 week, 6 days ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20210108074248.60395-1-laine@redhat.com
src/conf/domain_conf.c   |  3 +--
src/libxl/libxl_driver.c | 24 +++++++++---------------
src/lxc/lxc_driver.c     | 17 +++++------------
src/lxc/lxc_process.c    | 19 +++++++------------
src/qemu/qemu_process.c  |  9 ++++-----
5 files changed, 26 insertions(+), 46 deletions(-)

[PATCH 0/2] fix re-attach of bridge device for <interface type='bridge'>

Posted by Laine Stump 1 week, 6 days ago
For a long time I thought this worked, but during discussion in a
bugzilla report one day I realized it only worked properly for
<interface type='network'> - we're not even trying to reattach bridges
during libvirtd restart for type='bridge' (i.e. no associated libvirt
network).

These two patches together fix that problem.

Laine Stump (2):
  call virDomainNetNotifyActualDevice() for all interface types
  use g_autoptr for (almost) all virConnectPtrs used with
    virGetConnectNetwork()

 src/conf/domain_conf.c   |  3 +--
 src/libxl/libxl_driver.c | 24 +++++++++---------------
 src/lxc/lxc_driver.c     | 17 +++++------------
 src/lxc/lxc_process.c    | 19 +++++++------------
 src/qemu/qemu_process.c  |  9 ++++-----
 5 files changed, 26 insertions(+), 46 deletions(-)

-- 
2.29.2

Re: [PATCH 0/2] fix re-attach of bridge device for <interface type='bridge'>

Posted by Michal Privoznik 1 week, 6 days ago
On 1/8/21 8:42 AM, Laine Stump wrote:
> For a long time I thought this worked, but during discussion in a
> bugzilla report one day I realized it only worked properly for
> <interface type='network'> - we're not even trying to reattach bridges
> during libvirtd restart for type='bridge' (i.e. no associated libvirt
> network).
> 
> These two patches together fix that problem.
> 
> Laine Stump (2):
>    call virDomainNetNotifyActualDevice() for all interface types
>    use g_autoptr for (almost) all virConnectPtrs used with
>      virGetConnectNetwork()
> 
>   src/conf/domain_conf.c   |  3 +--
>   src/libxl/libxl_driver.c | 24 +++++++++---------------
>   src/lxc/lxc_driver.c     | 17 +++++------------
>   src/lxc/lxc_process.c    | 19 +++++++------------
>   src/qemu/qemu_process.c  |  9 ++++-----
>   5 files changed, 26 insertions(+), 46 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal