From nobody Sat Feb 7 10:44:33 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1607709968; cv=none; d=zohomail.com; s=zohoarc; b=n2BMiwfw8R5lbOQ3RPTNOOrT8LAmacxO9nWwozeEUzVkS7ByydpkMCPxMwbG7pi4fkBe+fAJAqAaNmdvvQBJuctHepf+8IduPQm0tv/abTCwiKTl5nVVO+Eh2NKBdG+oLL4CWq7007LqKU7A0/RXEv5lbUHbzQbdBCadkGvTfbs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607709968; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=gT1GF/TBhwrNCtaBjM3d0QL3QtUMjX1PuTEKMmAMiKQ=; b=f+DnOCp1zljCt/jfeFHjAPjzA7zYRSa+v3sbj58nVZ4XPPEgtQU6Y1u69hjo6YuF909noZwHTb2fdlnVeygN+vTGG9uPI5OsRHG0P5dEYxHMUw5rVAiKOyZewsYr6Q1Y6inhvEUTQjQqxHWF49YY1zTozOADQLzKSn5Yc6HRmzo= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1607709968223173.73097172301175; Fri, 11 Dec 2020 10:06:08 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-441-wpcuxXbsPKiTZ7W29529rg-1; Fri, 11 Dec 2020 13:06:01 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 12566803628; Fri, 11 Dec 2020 18:05:54 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E590F60BF1; Fri, 11 Dec 2020 18:05:53 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id AF1B61809CA8; Fri, 11 Dec 2020 18:05:53 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0BBI5eFh027567 for ; Fri, 11 Dec 2020 13:05:41 -0500 Received: by smtp.corp.redhat.com (Postfix) id C187C2166B2C; Fri, 11 Dec 2020 18:05:40 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BC69D2166B29 for ; Fri, 11 Dec 2020 18:05:40 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A7C9C800B3B for ; Fri, 11 Dec 2020 18:05:40 +0000 (UTC) Received: from mail-qk1-f195.google.com (mail-qk1-f195.google.com [209.85.222.195]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-114-nS1yF19YOXuruv-J38SIrw-1; Fri, 11 Dec 2020 13:05:38 -0500 Received: by mail-qk1-f195.google.com with SMTP id n142so9270439qkn.2 for ; Fri, 11 Dec 2020 10:05:38 -0800 (PST) Received: from rekt.ibmuc.com ([2804:431:c7c6:9e32:a7fb:6602:e8c2:3c0f]) by smtp.gmail.com with ESMTPSA id y6sm7585703qkj.60.2020.12.11.10.05.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Dec 2020 10:05:37 -0800 (PST) X-MC-Unique: wpcuxXbsPKiTZ7W29529rg-1 X-MC-Unique: nS1yF19YOXuruv-J38SIrw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gT1GF/TBhwrNCtaBjM3d0QL3QtUMjX1PuTEKMmAMiKQ=; b=Y7YTgulW+ZLwaKHbNUivjVKfxJlWVY9LLdEQRARJDFhNn0feByeowsMSY3eBKNfc+4 pseMJcRGIl6cuCLKfM5AJY8/vao+sa8S89IYxve5aXZ+ijga6+BlzZmV+dgJNyPCPxvt 1Yf0n0TSA7xVrd6wE09svWRVuyN1xhz8c8Da44TIi9gV6H6J0YXRkHMcHJOqPAQVs5/E evhanqC1b76K25M/pVrsvkRrytJEgGj++kBk9p2J8M61R/UuP4KkU76YkMRRde6+vc6s bM7wuKRINGvkHCUVFV0QaWaCbCb1lvycb7oYqHzE9t/nTK2l8Qowt2CQJ8QXzGTueMlX KmCw== X-Gm-Message-State: AOAM531BeFrxNmyDAYQtcciDdjdiPjKaJdilwJggrlXnw6Gv+yn5te2m PYJhSgKiTTmMnD+RUishlchLHB1OS/Vf9w== X-Google-Smtp-Source: ABdhPJzBFau0zA2TZ9uel9YyeXBOo1qf0lWk7lj50vvsUEH4VbUuSJyBlF/rY7eI7qaZxxubKmgdlw== X-Received: by 2002:a37:a0c6:: with SMTP id j189mr17875830qke.142.1607709937910; Fri, 11 Dec 2020 10:05:37 -0800 (PST) From: Daniel Henrique Barboza To: libvir-list@redhat.com Subject: [PATCH 06/12] domain_validate.c: make local functions static Date: Fri, 11 Dec 2020 15:05:10 -0300 Message-Id: <20201211180516.1952683-7-danielhb413@gmail.com> In-Reply-To: <20201211180516.1952683-1-danielhb413@gmail.com> References: <20201211180516.1952683-1-danielhb413@gmail.com> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-loop: libvir-list@redhat.com Cc: Daniel Henrique Barboza X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" virDomainDefValidateInternal() helpers can now be made static again since they're all in the same file. Signed-off-by: Daniel Henrique Barboza --- src/conf/domain_validate.c | 22 +++++++++++----------- src/conf/domain_validate.h | 13 ------------- 2 files changed, 11 insertions(+), 24 deletions(-) diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c index 47aa3e4375..6632262ca2 100644 --- a/src/conf/domain_validate.c +++ b/src/conf/domain_validate.c @@ -30,7 +30,7 @@ =20 VIR_LOG_INIT("conf.domain_validate"); =20 -int +static int virDomainDefBootValidate(const virDomainDef *def) { if (def->os.bm_timeout_set && def->os.bm_timeout > 65535) { @@ -52,7 +52,7 @@ virDomainDefBootValidate(const virDomainDef *def) } =20 =20 -int +static int virDomainDefVideoValidate(const virDomainDef *def) { size_t i; @@ -499,7 +499,7 @@ virDomainSmartcardDefValidate(const virDomainSmartcardD= ef *smartcard, } =20 =20 -int +static int virDomainDefTunablesValidate(const virDomainDef *def) { size_t i, j; @@ -615,7 +615,7 @@ virDomainControllerDefValidate(const virDomainControlle= rDef *controller) } =20 =20 -int +static int virDomainDefIdMapValidate(const virDomainDef *def) { if ((def->idmap.uidmap && !def->idmap.gidmap) || @@ -638,7 +638,7 @@ virDomainDefIdMapValidate(const virDomainDef *def) } =20 =20 -int +static int virDomainDefDuplicateDiskInfoValidate(const virDomainDef *def) { size_t i; @@ -667,7 +667,7 @@ virDomainDefDuplicateDiskInfoValidate(const virDomainDe= f *def) * Returns 0 in case of there are no duplicate drive addresses, -1 * otherwise. */ -int +static int virDomainDefDuplicateDriveAddressesValidate(const virDomainDef *def) { size_t i; @@ -822,7 +822,7 @@ virDomainDeviceDefValidateAliasesIterator(virDomainDefP= tr def, * Returns 0 on success, * -1 otherwise (with error reported). */ -int +static int virDomainDefValidateAliases(const virDomainDef *def, GHashTable **aliases) { @@ -901,7 +901,7 @@ virDomainDeviceValidateAliasForHotplug(virDomainObjPtr = vm, } =20 =20 -int +static int virDomainDefLifecycleActionValidate(const virDomainDef *def) { if (!virDomainDefLifecycleActionAllowed(VIR_DOMAIN_LIFECYCLE_POWEROFF, @@ -923,7 +923,7 @@ virDomainDefLifecycleActionValidate(const virDomainDef = *def) } =20 =20 -int +static int virDomainDefMemtuneValidate(const virDomainDef *def) { const virDomainMemtune *mem =3D &(def->mem); @@ -975,7 +975,7 @@ virDomainDefMemtuneValidate(const virDomainDef *def) } =20 =20 -int +static int virDomainDefOSValidate(const virDomainDef *def, virDomainXMLOptionPtr xmlopt) { @@ -1023,7 +1023,7 @@ virDomainDefOSValidate(const virDomainDef *def, } \ } while (0) =20 -int +static int virDomainDefCputuneValidate(const virDomainDef *def) { CPUTUNE_VALIDATE_PERIOD(period); diff --git a/src/conf/domain_validate.h b/src/conf/domain_validate.h index 309ae5f950..e89cadab75 100644 --- a/src/conf/domain_validate.h +++ b/src/conf/domain_validate.h @@ -25,8 +25,6 @@ #include "domain_conf.h" #include "virconftypes.h" =20 -int virDomainDefBootValidate(const virDomainDef *def); -int virDomainDefVideoValidate(const virDomainDef *def); int virDomainVideoDefValidate(const virDomainVideoDef *video, const virDomainDef *def); int virSecurityDeviceLabelDefValidate(virSecurityDeviceLabelDefPtr *seclab= els, @@ -43,21 +41,10 @@ int virDomainRNGDefValidate(const virDomainRNGDef *rng, const virDomainDef *def); int virDomainSmartcardDefValidate(const virDomainSmartcardDef *smartcard, const virDomainDef *def); -int virDomainDefTunablesValidate(const virDomainDef *def); int virDomainControllerDefValidate(const virDomainControllerDef *controlle= r); -int virDomainDefIdMapValidate(const virDomainDef *def); -int virDomainDefDuplicateDiskInfoValidate(const virDomainDef *def); -int virDomainDefDuplicateDriveAddressesValidate(const virDomainDef *def); -int virDomainDefValidateAliases(const virDomainDef *def, - GHashTable **aliases); int virDomainDeviceValidateAliasForHotplug(virDomainObjPtr vm, virDomainDeviceDefPtr dev, unsigned int flags); -int virDomainDefLifecycleActionValidate(const virDomainDef *def); -int virDomainDefMemtuneValidate(const virDomainDef *def); -int virDomainDefOSValidate(const virDomainDef *def, - virDomainXMLOptionPtr xmlopt); -int virDomainDefCputuneValidate(const virDomainDef *def); int virDomainDefValidate(virDomainDefPtr def, unsigned int parseFlags, virDomainXMLOptionPtr xmlopt, --=20 2.26.2