From nobody Tue May 14 22:58:47 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1607620880; cv=none; d=zohomail.com; s=zohoarc; b=fZ9LimDRGfo0ZmMF9Wjw5AMWAX+WIYxQUZTX1i3eH2sXOT47lawNoF3nhI7Q5ZOwb0eU8RNe7Hs6w4LOBVnaJWKl2NzBB98RfivbpxH9mE0vxCRTZbb3GFkKkpCaIZc/pQ4sLEMV/YapH2r7hbl4r7RMCl5GWqo6n21y6DKKrgM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607620880; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Subject:To; bh=TUB+tdqJVam0Ka2WQ7+iPmxajuOAWN6UWIthadc/vek=; b=c4q+keNVqUQe8F87Z7hLQ7zDhQmYh1Uofi2l8YJepcpzQzRXF8rXlGaAsu5b3mFlBUJ/6fnrnNv4C+IxjrFP4dqZSPnTTASFhI+y96Fcromqeusl60cFjIOzMBISdZ4V9elCG+hVojsLLB2hhsGshM3D74I95pS1Yv0DEFYbd8Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 16076208802361016.4934089383833; Thu, 10 Dec 2020 09:21:20 -0800 (PST) Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-223-zbcSXLX1OCiTquwIjtitFA-1; Thu, 10 Dec 2020 12:21:17 -0500 Received: by mail-wm1-f70.google.com with SMTP id h68so2285823wme.5 for ; Thu, 10 Dec 2020 09:21:16 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (101.red-88-21-206.staticip.rima-tde.net. [88.21.206.101]) by smtp.gmail.com with ESMTPSA id y6sm10652342wmg.39.2020.12.10.09.21.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Dec 2020 09:21:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607620878; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TUB+tdqJVam0Ka2WQ7+iPmxajuOAWN6UWIthadc/vek=; b=ZmIJZddEmJk+RUp+/GGjOUUirEH0U6TSgnpP4rUORJLJeE/gS/LLB5JBmzxoHIuWSwLhrD z3YuBUtR+NDEly6CvGF4U1jXZFSHRyBa/uqJl5D06+O0jqusLpxdL93kV3JTRfuAmGaskp tfQiK+elHxj/c5VT/j/+wXeyIFk1PPY= X-MC-Unique: zbcSXLX1OCiTquwIjtitFA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=TUB+tdqJVam0Ka2WQ7+iPmxajuOAWN6UWIthadc/vek=; b=MbTl7CCJBw9ZAEqWJB+dDqK1sTN5d75YXA9/2bHgmnIekifLMud/ZnnkJ7nNvPa5ks mObNVBxYYp0YUA9rm+SCB3GBr40Gmy3rDAD8OJ2QYVxrPvtetmUDbPdSHl5ki2p6tpj9 DKokPPZpkq5/Ud5A62ILriV40rtroYSYiLWMCoCvHjj//ttv+5g/FOOpoRNqNW0MeZnz L1JC2ui1IFA/mIbFIW6eU8QWUmT9L1w/DhhfXfystNIwYoMmHo0hfB4nrIC/wvG1px0Z M0B5b1wjnaw2wkO77Ou0/VQdTRSBdcpEkPwItYB0RMU0J54SlMiTkprOpmeQ7JrZ/y7j k7yw== X-Gm-Message-State: AOAM531FF7NTqIpZpu2HJQtMLCYTLBTTO+1gGlpONm9ibwzwIAE5X5nM oBzzBO1QPXmTDV6286NGHXVA/bELzQvTgZS88C3Ib3Nuq4+JRADN5r1pYIPgY5CKJQvC2ylLm3R mV5XA7PpnhOVtKQ== X-Received: by 2002:a1c:790f:: with SMTP id l15mr9390179wme.188.1607620875946; Thu, 10 Dec 2020 09:21:15 -0800 (PST) X-Google-Smtp-Source: ABdhPJwhmLKJ8/6opJK8jk7uu+wIWqCk/dQqmBbhpZoqL4HEaOEJWFqXp3RPaobXIHeJX7etDLh82g== X-Received: by 2002:a1c:790f:: with SMTP id l15mr9390162wme.188.1607620875740; Thu, 10 Dec 2020 09:21:15 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: libvir-list@redhat.com, Paolo Bonzini , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Thomas Huth , =?UTF-8?q?J=C3=A1n=20Tomko?= Subject: [PATCH v2] accel/tcg: Remove deprecated '-tb-size' option Date: Thu, 10 Dec 2020 18:21:13 +0100 Message-Id: <20201210172113.167640-1-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) The '-tb-size' option (replaced by '-accel tcg,tb-size') is deprecated since 5.0 (commit fe174132478). Remove it. Reviewed-by: Thomas Huth Reviewed-by: J=C3=A1n Tomko Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- v2: fixed "Title underline too short." (Thomas) --- docs/system/deprecated.rst | 12 +++++------- accel/tcg/translate-all.c | 2 +- softmmu/vl.c | 8 -------- qemu-options.hx | 8 -------- 4 files changed, 6 insertions(+), 24 deletions(-) diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst index 565389697e8..14326063e9a 100644 --- a/docs/system/deprecated.rst +++ b/docs/system/deprecated.rst @@ -100,13 +100,6 @@ QEMU 5.1 has three options: to the user to load all the images they need. 3. ``-bios `` - Tells QEMU to load the specified file as the firmwr= ae. =20 -``-tb-size`` option (since 5.0) -''''''''''''''''''''''''''''''' - -QEMU 5.0 introduced an alternative syntax to specify the size of the trans= lation -block cache, ``-accel tcg,tb-size=3D``. The new syntax deprecates the -previously available ``-tb-size`` option. - ``-show-cursor`` option (since 5.0) ''''''''''''''''''''''''''''''''''' =20 @@ -523,6 +516,11 @@ for the ``id`` parameter, which should now be used ins= tead. =20 The ``-no-kvm`` argument was a synonym for setting ``-machine accel=3Dtcg`= `. =20 +``-tb-size`` option (removed in 6.0) +'''''''''''''''''''''''''''''''''''' + +QEMU 5.0 introduced an alternative syntax to specify the size of the trans= lation +block cache, ``-accel tcg,tb-size=3D``. =20 QEMU Machine Protocol (QMP) commands ------------------------------------ diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c index 4572b4901fb..b7d50a73d44 100644 --- a/accel/tcg/translate-all.c +++ b/accel/tcg/translate-all.c @@ -2379,7 +2379,7 @@ void dump_exec_info(void) qemu_printf("Translation buffer state:\n"); /* * Report total code size including the padding and TB structs; - * otherwise users might think "-tb-size" is not honoured. + * otherwise users might think "-accel tcg,tb-size" is not honoured. * For avg host size we use the precise numbers from tb_tree_stats tho= ugh. */ qemu_printf("gen code size %zu/%zu\n", diff --git a/softmmu/vl.c b/softmmu/vl.c index e6e0ad5a925..3f052849d8c 100644 --- a/softmmu/vl.c +++ b/softmmu/vl.c @@ -3639,14 +3639,6 @@ void qemu_init(int argc, char **argv, char **envp) exit(1); } break; - case QEMU_OPTION_tb_size: -#ifndef CONFIG_TCG - error_report("TCG is disabled"); - exit(1); -#endif - warn_report("The -tb-size option is deprecated, use -accel= tcg,tb-size instead"); - object_register_sugar_prop(ACCEL_CLASS_NAME("tcg"), "tb-si= ze", optarg); - break; case QEMU_OPTION_icount: icount_opts =3D qemu_opts_parse_noisily(qemu_find_opts("ic= ount"), optarg, true); diff --git a/qemu-options.hx b/qemu-options.hx index 104632ea343..7ce06290b68 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -4080,14 +4080,6 @@ SRST Show cursor. ERST =20 -DEF("tb-size", HAS_ARG, QEMU_OPTION_tb_size, \ - "-tb-size n set TB size\n", QEMU_ARCH_ALL) -SRST -``-tb-size n`` - Set TCG translation block cache size. Deprecated, use - '\ ``-accel tcg,tb-size=3Dn``\ ' instead. -ERST - DEF("incoming", HAS_ARG, QEMU_OPTION_incoming, \ "-incoming tcp:[host]:port[,to=3Dmaxport][,ipv4][,ipv6]\n" \ "-incoming rdma:host:port[,ipv4][,ipv6]\n" \ --=20 2.26.2