From nobody Sat May 18 12:05:14 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1607339581; cv=none; d=zohomail.com; s=zohoarc; b=XddnOL/3JLLd2/Lu0djilcSCohlTpOpAKfwNSFlF2ewBePFuIQZvEU+gBQuWQSmRxiLUhvP9MYsQey9cKejsRWxKIZJvNZaeYwbOPoqNZYhtNsKtdSITTvF2Pm+/cvMAl3l9j6e6gIt5ZooJHtvzPSn4lQyhvXTVhUA7BoDiHF8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607339581; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=JWZvmsOtkhEG+05k+IHz1CiN9LSta0Qcgvm/pcOaOo4=; b=mn+Nm/4/Qo09Ygxv0wAbZYMNRbS7EYQDvGdhJFkDSoOll82sAjwuMz6pSf61sUn9yIaYYRGKnUW+RkaY5z9UccLDKKwB6oJbScZjafTk3023z8MSazvOUDvIQCWZ5i3O3UGp7Gg2puM3ujj8BondDZk2DPxWOFfhrwIns0MQ9Og= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 16073395819241010.9891865984899; Mon, 7 Dec 2020 03:13:01 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-458-sK_6GIABNIKO1Mi4Fs4jcw-1; Mon, 07 Dec 2020 06:12:58 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 55E77107ACFC; Mon, 7 Dec 2020 11:12:52 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C2FB55D9E2; Mon, 7 Dec 2020 11:12:51 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 84E534BB7B; Mon, 7 Dec 2020 11:12:49 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0B7B5WlS025270 for ; Mon, 7 Dec 2020 06:05:32 -0500 Received: by smtp.corp.redhat.com (Postfix) id D14691E5; Mon, 7 Dec 2020 11:05:32 +0000 (UTC) Received: from fedora.redhat.com (ovpn-113-137.ams2.redhat.com [10.36.113.137]) by smtp.corp.redhat.com (Postfix) with ESMTP id C8F9D60BD8; Mon, 7 Dec 2020 11:05:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607339580; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=JWZvmsOtkhEG+05k+IHz1CiN9LSta0Qcgvm/pcOaOo4=; b=VZGJDz9oPJcVb3Kp8gfOGOJzBYEqLQDzd6UvuxBUyur9tNRWaqn6UB0M7cNi6sed8AWdmE +iR/LMKQTBm6ewBIn95IxDxkQAhnsGWpLeqxGjZUTLEKPQf/z5OxwKwzJJ7G4DsleWnZxu cNMXwACCni24btn2gIB+szV+dGyIfXQ= X-MC-Unique: sK_6GIABNIKO1Mi4Fs4jcw-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Subject: [libvirt PATCH] libvirt-guests: Remove obsolete Windows comment Date: Mon, 7 Dec 2020 11:05:17 +0000 Message-Id: <20201207110516.3106591-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Cc: Kevin Locke X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" From: Kevin Locke The comment that > For instance, qemu-ga doesn't support guest time synchronization on > Windows guests, but Linux ones. Was correct at the time, but has since been addressed by qemu/qemu@105fad6bb22, which added support for set-time without a time argument, as used by `virsh domtime --sync` by libvirt-guests.sh. I can confirm that `virsh domtime --sync` works correctly on a Windows 10 guest, as does `SYNC_TIME=3D1`. (Note that there can be a significant delay between when the command completes and when the guest time finishes synchronizing due to QEMU GA calling `w32tm` with `/nowait`, which complicates testing.) Signed-off-by: Kevin Locke --- Merged this trivial docs patch from a gitlab MR. tools/libvirt-guests.sysconf | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tools/libvirt-guests.sysconf b/tools/libvirt-guests.sysconf index 0765efec21..4f83edab90 100644 --- a/tools/libvirt-guests.sysconf +++ b/tools/libvirt-guests.sysconf @@ -46,7 +46,5 @@ =20 # If non-zero, try to sync guest time on domain resume. Be aware, that # this requires guest agent with support for time synchronization -# running in the guest. For instance, qemu-ga doesn't support guest time -# synchronization on Windows guests, but Linux ones. By default, this -# functionality is turned off. +# running in the guest. By default, this functionality is turned off. #SYNC_TIME=3D1 --=20 2.28.0