From nobody Sun Feb 8 07:52:46 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1606245709; cv=none; d=zohomail.com; s=zohoarc; b=QJyhee2AlSFc3ZGAfz23YhzwdjBNOjjSd+NPk/7K0ib89UpVJCdlFIqWBHujxQrrDH0E//iU3+j07L9N/+XSf9hyEfs4JBG5Mz8XKqibHhBnPptsxDLLkWDPM7w6T4ryAJhta+xdR0FGr/X4G9HQVmOjdq3NDRCqJvT18GI8UEk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606245709; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=0j86XdAh1PbyOonw3RvGpUOFO6zlGsgIwry4GDYsffs=; b=MjVflS/1bDb+vIucs24Cuo46NPMYD6njmmjHoI89e4dn7cHPfa6REnTwyDXVCBjYMjOEEti1nwAGBGkF1P/x8Cb60hnGCZ/h7y5jgBDhMerFnMPyq/Mj4q82ffKfqJy/dcVUhHgXDCK7a0dkbvlNS1vcvHr0BTJFgFOhLyw68aQ= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1606245709083995.1346468693966; Tue, 24 Nov 2020 11:21:49 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-465-hbtEu7faOnuTs8pXQwgEJA-1; Tue, 24 Nov 2020 14:21:45 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4535410060D5; Tue, 24 Nov 2020 19:21:39 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 200BB60916; Tue, 24 Nov 2020 19:21:39 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D34CA18087F2; Tue, 24 Nov 2020 19:21:38 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0AOJLbRW004724 for ; Tue, 24 Nov 2020 14:21:37 -0500 Received: by smtp.corp.redhat.com (Postfix) id B9FFF110F0D3; Tue, 24 Nov 2020 19:21:37 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast04.extmail.prod.ext.rdu2.redhat.com [10.11.55.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B4A0A110F0D1 for ; Tue, 24 Nov 2020 19:21:33 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2A471103B807 for ; Tue, 24 Nov 2020 19:21:33 +0000 (UTC) Received: from mail-qv1-f48.google.com (mail-qv1-f48.google.com [209.85.219.48]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-293-zymsCSnRPliGzwYTzJIYpA-1; Tue, 24 Nov 2020 14:21:29 -0500 Received: by mail-qv1-f48.google.com with SMTP id y11so11146910qvu.10 for ; Tue, 24 Nov 2020 11:21:29 -0800 (PST) Received: from rekt.redhat.com ([2804:431:c7c7:d88a:482:7c39:5cca:96f6]) by smtp.gmail.com with ESMTPSA id l79sm88837qke.1.2020.11.24.11.21.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Nov 2020 11:21:28 -0800 (PST) X-MC-Unique: hbtEu7faOnuTs8pXQwgEJA-1 X-MC-Unique: zymsCSnRPliGzwYTzJIYpA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0j86XdAh1PbyOonw3RvGpUOFO6zlGsgIwry4GDYsffs=; b=TNbHZb2btcfByFWbTxg7XOsYdYce+c9snzrVi2HfhdEZy32ZHwC3vNv3BRcIVCPut3 StJURyoCRn2pGLJF38BOAbajV8dryeojd/DBp3mAxIL6RKrrcQjdE7qb4r4Jxuxxe4rh +0Uwe+qv0tLvIzcapVCd5IvwDhuhWV+QaUzk1kJvax1SmF1SKn5FLjAiUt/sJiP+fNcM dqGB1YhJEgMK2GJuKJ5x3X7ktJERiyD2vDUaZUi9b7gtifeJLpu/PwWXxzcbeQ/sXVkF lHKhcGBkjTHN3d3CcXh2QGDjltw910qdPPBE9W1zSfAFrm3JeMW+5U4oNnWhKK4pODJH KjWQ== X-Gm-Message-State: AOAM533L40g/C03/6+5jILf0UcK5FJnC5XlUDalzy4QqVnrpb3SuDwCt mmDGVXo8jrl4IRVS/1hpLT4ZkL2Oo2c= X-Google-Smtp-Source: ABdhPJxdK3OisvBAvU836AuhwWgqjQB9xwxrz70P1r3fBEeyw4XFN/26kEYVseeg5N8bfoOMN41Bww== X-Received: by 2002:a0c:f28d:: with SMTP id k13mr6395961qvl.31.1606245689005; Tue, 24 Nov 2020 11:21:29 -0800 (PST) From: Daniel Henrique Barboza To: libvir-list@redhat.com Subject: [PATCH 20/21] domain_conf.c: use VIR_ERR_CONFIG_UNSUPPORTED in post parse Date: Tue, 24 Nov 2020 16:20:34 -0300 Message-Id: <20201124192035.2343063-21-danielhb413@gmail.com> In-Reply-To: <20201124192035.2343063-1-danielhb413@gmail.com> References: <20201124192035.2343063-1-danielhb413@gmail.com> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-loop: libvir-list@redhat.com Cc: Daniel Henrique Barboza X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Some occurrences in post parse functions of domain_conf.c are using VIR_ERR_XML_ERROR. Use VIR_ERR_CONFIG_UNSUPPORTED instead since these errors might not be related to a XML use case. Signed-off-by: Daniel Henrique Barboza --- src/conf/domain_conf.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index b794611b1e..c99c1b60d4 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -5266,15 +5266,15 @@ virDomainDiskDefPostParse(virDomainDiskDefPtr disk, if (virStorageSourceGetActualType(disk->src) !=3D VIR_STORAGE_TYPE_NET= WORK && disk->src->protocol !=3D VIR_STORAGE_NET_PROTOCOL_RBD) { if (disk->src->snapshot) { - virReportError(VIR_ERR_XML_ERROR, "%s", - _(" element is currently supported " + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("'snapshot' is currently supported " "only with 'rbd' disks")); return -1; } =20 if (disk->src->configFile) { - virReportError(VIR_ERR_XML_ERROR, "%s", - _(" element is currently supported " + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("'config' is currently supported " "only with 'rbd' disks")); return -1; } @@ -5373,7 +5373,7 @@ virDomainControllerDefPostParse(virDomainControllerDe= fPtr cdev) cdev->model !=3D VIR_DOMAIN_CONTROLLER_MODEL_SCSI_VIRTIO_SCSI && cdev->model !=3D VIR_DOMAIN_CONTROLLER_MODEL_SCSI_VIRTIO_TRANSITIO= NAL && cdev->model !=3D VIR_DOMAIN_CONTROLLER_MODEL_SCSI_VIRTIO_NON_TRANS= ITIONAL) { - virReportError(VIR_ERR_XML_ERROR, "%s", + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("'iothread' attribute only supported for " "virtio scsi controllers")); return -1; --=20 2.26.2