From nobody Tue Feb 10 02:49:43 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1606188629; cv=none; d=zohomail.com; s=zohoarc; b=gIjufMM8XlWygMEVRAO3BZ22kMU4drFrZgVkOwSk23QfXiPyFSSikuaecjT/+39s+uOovSmD9iaYachMNmgFP53dmHTFL8SIHeKyHVkzkYGfR6CjH61TEeo2FVKlb6M57dY89U9+3ntIEptW+DsVYlWLHZBXo5ORFMJ/Gv3JJI0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606188629; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=9fH6HzOsgcG6OqoF21tvz/r6SLOBbbPIpr7tMh55eBQ=; b=Pr6q9tumoeLbezsBWo7j5ZZ/ab8XnitSmzBmbOezCDSAPyLuk63P+cBNzEy431Q0WlABSWz/gcSlB9E/8ZhTnLKvXAeROiN3ZPJMTsgScPK9DPY4+/4+GoO85sOGY0Ai+FBBLMS7XhnI1uY4n/GE/8sEWyfRkxVKkeNTQiTKvvE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1606188629850662.5665345286528; Mon, 23 Nov 2020 19:30:29 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-462-7H2ACzXlOOCDvahwqKzAoA-1; Mon, 23 Nov 2020 22:30:26 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E97718030B4; Tue, 24 Nov 2020 03:30:20 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D4A2260C04; Tue, 24 Nov 2020 03:30:19 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 10AB45002C; Tue, 24 Nov 2020 03:30:15 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0AO3UEiA007394 for ; Mon, 23 Nov 2020 22:30:14 -0500 Received: by smtp.corp.redhat.com (Postfix) id 36CC45D705; Tue, 24 Nov 2020 03:30:14 +0000 (UTC) Received: from vhost2.laine.org (ovpn-112-35.phx2.redhat.com [10.3.112.35]) by smtp.corp.redhat.com (Postfix) with ESMTP id F3FB25D6A1 for ; Tue, 24 Nov 2020 03:30:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606188628; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=9fH6HzOsgcG6OqoF21tvz/r6SLOBbbPIpr7tMh55eBQ=; b=DRefYrvf+n69gyZNpK7OTT5aPZ576tstGJgXKlpFmAnPsJwKQ+WX1amDf6L11ogQ2cI2Dz BRTc7eDHTVLMzjEVaz0gzgjiZtA7O6iJ40BooBNJKPmfZPizjofeckm56/l0lAarj7XpnY rJhkSeyId4arScrm8Gf0QW4fXo3SMO0= X-MC-Unique: 7H2ACzXlOOCDvahwqKzAoA-1 From: Laine Stump To: libvir-list@redhat.com Subject: [PATCH 5/8] network: be more verbose about the reason for a firewall reload Date: Mon, 23 Nov 2020 22:30:01 -0500 Message-Id: <20201124033004.1163126-6-laine@redhat.com> In-Reply-To: <20201124033004.1163126-1-laine@redhat.com> References: <20201124033004.1163126-1-laine@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Laine Stump --- src/network/bridge_driver.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 5d9b9eaa4f..fdad2191e6 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -653,6 +653,7 @@ firewalld_dbus_signal_callback(GDBusConnection *connect= ion G_GNUC_UNUSED, if (STREQ(interfaceName, "org.fedoraproject.FirewallD1") && STREQ(signalName, "Reloaded")) { reload =3D true; + VIR_DEBUG("Reload in bridge_driver because of 'Reloaded' signal"); } else if (STREQ(interfaceName, "org.freedesktop.DBus") && STREQ(signalName, "NameOwnerChanged")) { char *name =3D NULL; @@ -661,14 +662,15 @@ firewalld_dbus_signal_callback(GDBusConnection *conne= ction G_GNUC_UNUSED, =20 g_variant_get(parameters, "(&s&s&s)", &name, &old_owner, &new_owne= r); =20 - if (new_owner && *new_owner) + if (new_owner && *new_owner) { + VIR_DEBUG("Reload in bridge_driver because of 'NameOwnerChange= d' signal, new owner is: '%s'", + new_owner); reload =3D true; + } } =20 - if (reload) { - VIR_DEBUG("Reload in bridge_driver because of firewalld."); + if (reload) networkReloadFirewallRules(driver, false, true); - } } #endif =20 --=20 2.28.0