[libvirt PATCH v2 0/3] network: Drop UUID handling for default network

Andrea Bolognani posted 3 patches 1 week, 3 days ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20201119153630.332878-1-abologna@redhat.com
libvirt.spec.in          |  4 ----
src/conf/virnetworkobj.c | 17 ++++++++++++++++-
src/network/meson.build  | 32 +++++++-------------------------
3 files changed, 23 insertions(+), 30 deletions(-)

[libvirt PATCH v2 0/3] network: Drop UUID handling for default network

Posted by Andrea Bolognani 1 week, 3 days ago
Changes from [v1]:

  * ensure the updated network configuration is written back to disk
    whenever a UUID has been generated.

[v1] https://www.redhat.com/archives/libvir-list/2020-November/msg00785.html

Andrea Bolognani (3):
  conf: Write network config to disk after generating UUID
  network: Drop UUID handling for default network
  spec: Drop UUID handling for default network

 libvirt.spec.in          |  4 ----
 src/conf/virnetworkobj.c | 17 ++++++++++++++++-
 src/network/meson.build  | 32 +++++++-------------------------
 3 files changed, 23 insertions(+), 30 deletions(-)

-- 
2.26.2


Re: [libvirt PATCH v2 0/3] network: Drop UUID handling for default network

Posted by Laine Stump 1 week, 3 days ago
On 11/19/20 10:36 AM, Andrea Bolognani wrote:
> Changes from [v1]:
>
>    * ensure the updated network configuration is written back to disk
>      whenever a UUID has been generated.
>
> [v1] https://www.redhat.com/archives/libvir-list/2020-November/msg00785.html
>
> Andrea Bolognani (3):
>    conf: Write network config to disk after generating UUID
>    network: Drop UUID handling for default network
>    spec: Drop UUID handling for default network
>
>   libvirt.spec.in          |  4 ----
>   src/conf/virnetworkobj.c | 17 ++++++++++++++++-
>   src/network/meson.build  | 32 +++++++-------------------------
>   3 files changed, 23 insertions(+), 30 deletions(-)
>

Reviewed-by: Laine Stump <laine@redhat.com>


for the series.


We should change the other drivers that have uuids so that they also 
save if the uuid was added during parse. If that sounds boring to you, 
then I can put it on a list somewhere. I can't guarantee that will mean 
that it actually gets done though :-)

Re: [libvirt PATCH v2 0/3] network: Drop UUID handling for default network

Posted by Andrea Bolognani 1 week, 3 days ago
On Thu, 2020-11-19 at 11:03 -0500, Laine Stump wrote:
> On 11/19/20 10:36 AM, Andrea Bolognani wrote:
> > Andrea Bolognani (3):
> >    conf: Write network config to disk after generating UUID
> >    network: Drop UUID handling for default network
> >    spec: Drop UUID handling for default network
> 
> Reviewed-by: Laine Stump <laine@redhat.com>
> 
> for the series.

Thanks, pushed now.

> We should change the other drivers that have uuids so that they also 
> save if the uuid was added during parse. If that sounds boring to you, 
> then I can put it on a list somewhere. I can't guarantee that will mean 
> that it actually gets done though :-)

I'm going to take a stab at that, but I felt like there was a very
strong case for introducing this behavior for networks specifically
because 1) we already have it for MAC addresses and 2) we also
already do it for nwfilters, the other libvirt object for which we
know for sure we're going to be dropping configuration files into
/etc/libvirt at install time.

While I think extending this behavior to all libvirt objects is the
way to go, I can also see that being a more controversial change, so
I didn't to tie the two together and risk this never getting merged
because of that :)

-- 
Andrea Bolognani / Red Hat / Virtualization

Re: [libvirt PATCH v2 0/3] network: Drop UUID handling for default network

Posted by Laine Stump 1 week, 2 days ago
On 11/20/20 5:53 AM, Andrea Bolognani wrote:
> On Thu, 2020-11-19 at 11:03 -0500, Laine Stump wrote:
> 
>> We should change the other drivers that have uuids so that they also
>> save if the uuid was added during parse. If that sounds boring to you,
>> then I can put it on a list somewhere. I can't guarantee that will mean
>> that it actually gets done though :-)
> 
> I'm going to take a stab at that, but I felt like there was a very
> strong case for introducing this behavior for networks specifically
> because 1) we already have it for MAC addresses and 2) we also
> already do it for nwfilters, the other libvirt object for which we
> know for sure we're going to be dropping configuration files into
> /etc/libvirt at install time.
> 
> While I think extending this behavior to all libvirt objects is the
> way to go, I can also see that being a more controversial change, so
> I didn't to tie the two together and risk this never getting merged
> because of that :)
> 

Yup. I was only suggesting it as something to add to the todo list, not 
something that needed to be done right away.