From nobody Wed Apr 24 23:10:00 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1605729563; cv=none; d=zohomail.com; s=zohoarc; b=Npc3gaNifh7RvUzeEw+kDgYuJ4VlOoL9GpJW2UAACq+mX9kE4q5yaY+vO5u8gCfT1TkLe2vHstWl+6ND0sQFxyFD+p3ITvgqhunmVpDamei6x9EeYYKa1TdYkww9enajNKmlAiT+BWq651ZZ0wDAy+uzVonNsir8/gUYL224blU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605729563; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=OPdKkVe0MDYD6RiadmlPqtS2+qcXLx2pW+CM4A5Hoa4=; b=kncOXf+Odgxt9JZco3KfVbWKoZm6L4FNvZAPZEpPnm/LlzuOmiC1GiWMsXhEivhb5M7kflZ8MIBWZJy15fMQeraBG/jLG0vzdLvm30cc9xOAuKTZZKMzKyonmumuPwRp8FLxC5eWSFaTdEkSblQNLUMLQ3i88oMCErlaoKdkkdI= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1605729563216713.2874346306672; Wed, 18 Nov 2020 11:59:23 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-500-QvmbO54ANHOC5f0T7JxQhw-1; Wed, 18 Nov 2020 14:59:19 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5D4A91005D44; Wed, 18 Nov 2020 19:59:13 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3544910016FB; Wed, 18 Nov 2020 19:59:13 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id F192B8B2B6; Wed, 18 Nov 2020 19:59:12 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0AIJwun3021586 for ; Wed, 18 Nov 2020 14:58:56 -0500 Received: by smtp.corp.redhat.com (Postfix) id AD479112D40D; Wed, 18 Nov 2020 19:58:56 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast06.extmail.prod.ext.rdu2.redhat.com [10.11.55.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A9AE9100414B for ; Wed, 18 Nov 2020 19:58:54 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 583AF1823603 for ; Wed, 18 Nov 2020 19:58:54 +0000 (UTC) Received: from mail-qv1-f65.google.com (mail-qv1-f65.google.com [209.85.219.65]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-273-AHgIF8sCNWyRhlJ0crGgmQ-1; Wed, 18 Nov 2020 14:58:51 -0500 Received: by mail-qv1-f65.google.com with SMTP id z17so1649921qvy.11 for ; Wed, 18 Nov 2020 11:58:51 -0800 (PST) Received: from rekt.ibmuc.com ([2804:431:c7c7:d88a:482:7c39:5cca:96f6]) by smtp.gmail.com with ESMTPSA id n21sm7022757qke.21.2020.11.18.11.58.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Nov 2020 11:58:50 -0800 (PST) X-MC-Unique: QvmbO54ANHOC5f0T7JxQhw-1 X-MC-Unique: AHgIF8sCNWyRhlJ0crGgmQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OPdKkVe0MDYD6RiadmlPqtS2+qcXLx2pW+CM4A5Hoa4=; b=IN1rYANwTGeB6OtPKKxVNK4/bzITJ2ArxMxMOPZuSYc8XdcFOU7IAYnmsJR94g96cQ B4gpZjQFbTGUYQZJmtZaotBxLVGk+Ez74ZkRA/GHsBJXSVCdHFJ11Y75ViAw4nukfgDB 44LZiKq3MhpbDZefxXnFcF6pI3zej+j5m2qKqZj5Nlfboim41YVbL5F1qp7uj7dU06GL ueWTPfaK8dDcn7rKdjIr18aMzn8YB/S6Kmclvph33RnKYqSncEIQPKbd4G/rvU4UbWr8 +CobNjuGJnpoY4h/fEFDfgTmM6d+40TQXZt8aQvxsF0LBmriIXUyEUX5UeYX8yxC0OK0 DoFg== X-Gm-Message-State: AOAM530MzWd6H47jK69/In/w6VjtCQNgLbSMGxDri2k2mKR3xbV3upig 43OYykgAPALPxDM5WLVU1bVxZ+E8ScM= X-Google-Smtp-Source: ABdhPJw7A+1Dbhdr7QiVBotet72X3Ay1o2t5wEvhouf8wXL4IWfx0TXoqIEEehlHXBq1nypN0h30LA== X-Received: by 2002:a05:6214:6a2:: with SMTP id s2mr6435306qvz.58.1605729530517; Wed, 18 Nov 2020 11:58:50 -0800 (PST) From: Daniel Henrique Barboza To: libvir-list@redhat.com Subject: [PATCH v2 1/6] qemu_process.c: check migrateURI when setting VIR_QEMU_PROCESS_START_NEW Date: Wed, 18 Nov 2020 16:58:29 -0300 Message-Id: <20201118195834.1187381-2-danielhb413@gmail.com> In-Reply-To: <20201118195834.1187381-1-danielhb413@gmail.com> References: <20201118195834.1187381-1-danielhb413@gmail.com> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-loop: libvir-list@redhat.com Cc: Daniel Henrique Barboza X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" qemuProcessCreatePretendCmdPrepare() is setting the VIR_QEMU_PROCESS_START_NEW regardless of whether this is a migration case or not. This behavior differs from what we're doing in qemuProcessStart(), where the flag is set only if !migrate && !snapshot. Fix it by making the flag setting consistent with what we're doing in qemuProcessStart(). Signed-off-by: Daniel Henrique Barboza Reviewed-by: Andrea Bolognani --- src/qemu/qemu_process.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 579b3c3713..3677da635c 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -7436,7 +7436,10 @@ qemuProcessCreatePretendCmdPrepare(virQEMUDriverPtr = driver, VIR_QEMU_PROCESS_START_AUTODESTROY, -1); =20 flags |=3D VIR_QEMU_PROCESS_START_PRETEND; - flags |=3D VIR_QEMU_PROCESS_START_NEW; + + if (!migrateURI) + flags |=3D VIR_QEMU_PROCESS_START_NEW; + if (standalone) flags |=3D VIR_QEMU_PROCESS_START_STANDALONE; =20 --=20 2.26.2