[PATCH v2 4/6] qemuxml2xmltest.c: honor ARG_PARSEFLAGS

Daniel Henrique Barboza posted 6 patches 2 months ago

[PATCH v2 4/6] qemuxml2xmltest.c: honor ARG_PARSEFLAGS

Posted by Daniel Henrique Barboza 2 months ago
At this moment,  it is not possible to create a test specifying
ARG_PARSEFLAGS because info->parseFlags is not being forwarded to
testCompareDomXML2XMLFiles(). Let's fix it now so next patch can
make use of it.

Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
---
 tests/qemuxml2xmltest.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c
index c006719dee..603ba71686 100644
--- a/tests/qemuxml2xmltest.c
+++ b/tests/qemuxml2xmltest.c
@@ -32,7 +32,8 @@ testXML2XMLActive(const void *opaque)
     const struct testQemuInfo *info = opaque;
 
     return testCompareDomXML2XMLFiles(driver.caps, driver.xmlopt,
-                                      info->infile, info->outfile, true, 0,
+                                      info->infile, info->outfile, true,
+                                      info->parseFlags,
                                       TEST_COMPARE_DOM_XML2XML_RESULT_SUCCESS);
 }
 
@@ -43,7 +44,8 @@ testXML2XMLInactive(const void *opaque)
     const struct testQemuInfo *info = opaque;
 
     return testCompareDomXML2XMLFiles(driver.caps, driver.xmlopt,
-                                      info->infile, info->outfile, false, 0,
+                                      info->infile, info->outfile, false,
+                                      info->parseFlags,
                                       TEST_COMPARE_DOM_XML2XML_RESULT_SUCCESS);
 }
 
-- 
2.26.2

Re: [PATCH v2 4/6] qemuxml2xmltest.c: honor ARG_PARSEFLAGS

Posted by Andrea Bolognani 1 month, 2 weeks ago
On Wed, 2020-11-18 at 16:58 -0300, Daniel Henrique Barboza wrote:
> At this moment,  it is not possible to create a test specifying
> ARG_PARSEFLAGS because info->parseFlags is not being forwarded to
> testCompareDomXML2XMLFiles(). Let's fix it now so next patch can
> make use of it.
> 
> Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
> ---
>  tests/qemuxml2xmltest.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization