From nobody Tue Feb 10 17:08:40 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1605617792; cv=none; d=zohomail.com; s=zohoarc; b=GqybLNa+DU9REd+tc4v/bkxyrvA9pNY1yvBi5u/av7CCRvifeQtcWHNLP6GCyvquyzv3a+Ivp1QAfs4DBHetCVB4VwMrJrbX4pw22vKlCRPTloJuOj4R0FGk+4JUKI/JqjDPx2gb4XglZQxcVL0+sjkggojEY8xv+EYN40+nVYs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605617792; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=erbNP6GjEi7x8mW+e2UaRld+kaFSnhElv0SHZ5pAi4I=; b=oEMJ5UHRdwZj+R+z90JHZvPiOwxBsodMql0dIjn5H1nyVu4uMenrMS9i7W3/2vSNRJ8OsshLA1xMYRSqBtR6Nds8zyvgtSEJbwm3yjLVcMn4jLzKF/y/Wfirl1fM9bOPd6NdydE56XDuvoEWuX+5m8GDo5rgfikWz45Sbn6Pap8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1605617792936202.48400654133638; Tue, 17 Nov 2020 04:56:32 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-431-vz1XEA87P_WYN5yXVCzIWg-1; Tue, 17 Nov 2020 07:56:28 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CDDCC1017DC9; Tue, 17 Nov 2020 12:56:22 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C88905C1D0; Tue, 17 Nov 2020 12:56:21 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 89F1D180B657; Tue, 17 Nov 2020 12:56:21 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0AHCuJDc004674 for ; Tue, 17 Nov 2020 07:56:19 -0500 Received: by smtp.corp.redhat.com (Postfix) id A02B25C1DA; Tue, 17 Nov 2020 12:56:19 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-115-10.ams2.redhat.com [10.36.115.10]) by smtp.corp.redhat.com (Postfix) with ESMTP id EAF6E5C1CF; Tue, 17 Nov 2020 12:56:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605617791; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=erbNP6GjEi7x8mW+e2UaRld+kaFSnhElv0SHZ5pAi4I=; b=iX+tCGSxigoP0K+xL99npK/9k1egua5UkxjcoEZQ5b+VygxQGSYhmRPMtR+CBiN7GmY9lF Wuhj0yVYKYl/PFZ74228La+pZHjyZX/TE2eZ9ZhpsppXseAhAQYXQGWPgYhLZwBepgeY2s gAaiFhbP94K0jt8UsycABqXQNpKXmHg= X-MC-Unique: vz1XEA87P_WYN5yXVCzIWg-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Subject: [libvirt PATCH 1/4] nodedev: improve debugging logs from udev device/event processing Date: Tue, 17 Nov 2020 12:56:05 +0000 Message-Id: <20201117125608.177278-2-berrange@redhat.com> In-Reply-To: <20201117125608.177278-1-berrange@redhat.com> References: <20201117125608.177278-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Signed-off-by: Daniel P. Berrang=C3=A9 --- src/node_device/node_device_udev.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/node_device/node_device_udev.c b/src/node_device/node_devi= ce_udev.c index 65f312d8f4..b1b1886c54 100644 --- a/src/node_device/node_device_udev.c +++ b/src/node_device/node_device_udev.c @@ -141,8 +141,9 @@ udevGetDeviceProperty(struct udev_device *udev_device, =20 ret =3D udev_device_get_property_value(udev_device, property_key); =20 - VIR_DEBUG("Found property key '%s' value '%s' for device with sysname = '%s'", - property_key, NULLSTR(ret), udev_device_get_sysname(udev_dev= ice)); + VIR_DEBUG("Found property key '%s' value '%s' for device with sysname = '%s' errno=3D'%s'", + property_key, NULLSTR(ret), udev_device_get_sysname(udev_dev= ice), + ret ? "" : g_strerror(errno)); =20 return ret; } @@ -1609,7 +1610,7 @@ udevHandleOneDevice(struct udev_device *device) { const char *action =3D udev_device_get_action(device); =20 - VIR_DEBUG("udev action: '%s'", action); + VIR_DEBUG("udev action: '%s': %s", action, udev_device_get_syspath(dev= ice)); =20 if (STREQ(action, "add") || STREQ(action, "change")) return udevAddOneDevice(device); --=20 2.28.0