[PATCH libvirt v3 00/11] Support AP card, AP queues and AP matrix

Shalini Chellathurai Saroja posted 11 patches 1 week, 6 days ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20201117121105.2854458-1-shalini@linux.ibm.com
docs/formatnode.html.in                       |  48 +++-
docs/manpages/virsh.rst                       |   2 +-
docs/schemas/nodedev.rng                      |  46 ++++
include/libvirt/libvirt-nodedev.h             |   3 +
src/conf/node_device_conf.c                   | 218 ++++++++++++++++++
src/conf/node_device_conf.h                   |  41 +++-
src/conf/virnodedeviceobj.c                   |  13 +-
src/libvirt-nodedev.c                         |   3 +
src/libvirt_private.syms                      |   1 +
src/node_device/node_device_driver.c          |  33 ++-
src/node_device/node_device_udev.c            |  86 +++++++
tests/nodedevschemadata/ap_07_0038.xml        |   9 +
tests/nodedevschemadata/ap_card07.xml         |   8 +
tests/nodedevschemadata/ap_matrix.xml         |   7 +
.../ap_matrix_mdev_types.xml                  |  14 ++
...v_ee0b88c4_f554_4dc1_809d_b2a01e8e48ad.xml |   9 +
tests/nodedevxml2xmltest.c                    |   5 +
tools/virsh-nodedev.c                         |   9 +
18 files changed, 549 insertions(+), 6 deletions(-)
create mode 100644 tests/nodedevschemadata/ap_07_0038.xml
create mode 100644 tests/nodedevschemadata/ap_card07.xml
create mode 100644 tests/nodedevschemadata/ap_matrix.xml
create mode 100644 tests/nodedevschemadata/ap_matrix_mdev_types.xml
create mode 100644 tests/nodedevschemadata/mdev_ee0b88c4_f554_4dc1_809d_b2a01e8e48ad.xml

[PATCH libvirt v3 00/11] Support AP card, AP queues and AP matrix

Posted by Shalini Chellathurai Saroja 1 week, 6 days ago
Add support for AP card devices, AP queues and AP matrix devices in
libvirt node device driver.
---
v3:
 - Modify schema definition of ap-adapter to support hex values alone.
 - Modify schema definition of ap-domain to support hex values alone.
 - Verify domain value of AP queue device to be within the supported
   range during parsing.
 - Re-organized patches 6 and 10 according to review comment.
 - Minor changes according to review comments.

v2:
 - The tests included in the patches to detect the node devices (AP
   card, AP queues and AP matrix) are moved to separate patches.
   These patches are not divided further due to the following reasons:
    - The previous patches that add support for node devices in
      libvirt are not divided further into smaller patches (eg:
      53aec799fa31711ffaeacc7ec17ec6d3c2e3cadf).
    - It would be easier to identify the patches relevant to support
      AP node devices.
    - The number of lines in each of these patches are around 125,
      which is not too much.

 - Modified according to review comments.

 - New patch to detect mdev_types capabilty of AP matrix device is
   added to this patch series.

Boris Fiuczynski (1):
  node_device: detecting mdev_types capability on ap_matrix device

Farhan Ali (1):
  virsh: nodedev: Filter by AP card and AP queue capabilities

Shalini Chellathurai Saroja (9):
  nodedev: detect AP card device
  tests: AP card node device
  nodedev: detect AP queues
  tests: AP queue node device
  nodedev: detect AP matrix device
  tests: AP matrix node device
  virsh: nodedev: filter by AP Matrix capability
  node_device: refactor address retrieval of node device
  node_device: mdev matrix support

 docs/formatnode.html.in                       |  48 +++-
 docs/manpages/virsh.rst                       |   2 +-
 docs/schemas/nodedev.rng                      |  46 ++++
 include/libvirt/libvirt-nodedev.h             |   3 +
 src/conf/node_device_conf.c                   | 218 ++++++++++++++++++
 src/conf/node_device_conf.h                   |  41 +++-
 src/conf/virnodedeviceobj.c                   |  13 +-
 src/libvirt-nodedev.c                         |   3 +
 src/libvirt_private.syms                      |   1 +
 src/node_device/node_device_driver.c          |  33 ++-
 src/node_device/node_device_udev.c            |  86 +++++++
 tests/nodedevschemadata/ap_07_0038.xml        |   9 +
 tests/nodedevschemadata/ap_card07.xml         |   8 +
 tests/nodedevschemadata/ap_matrix.xml         |   7 +
 .../ap_matrix_mdev_types.xml                  |  14 ++
 ...v_ee0b88c4_f554_4dc1_809d_b2a01e8e48ad.xml |   9 +
 tests/nodedevxml2xmltest.c                    |   5 +
 tools/virsh-nodedev.c                         |   9 +
 18 files changed, 549 insertions(+), 6 deletions(-)
 create mode 100644 tests/nodedevschemadata/ap_07_0038.xml
 create mode 100644 tests/nodedevschemadata/ap_card07.xml
 create mode 100644 tests/nodedevschemadata/ap_matrix.xml
 create mode 100644 tests/nodedevschemadata/ap_matrix_mdev_types.xml
 create mode 100644 tests/nodedevschemadata/mdev_ee0b88c4_f554_4dc1_809d_b2a01e8e48ad.xml

-- 
2.26.2

Re: [PATCH libvirt v3 00/11] Support AP card, AP queues and AP matrix

Posted by Erik Skultety 1 week, 4 days ago
On Tue, Nov 17, 2020 at 01:10:54PM +0100, Shalini Chellathurai Saroja wrote:
> Add support for AP card devices, AP queues and AP matrix devices in
> libvirt node device driver.

Is there any public blueprint document or something that I can use to
cross-reference this design & implementation to?

Regards,
Erik

> ---
> v3:
>  - Modify schema definition of ap-adapter to support hex values alone.
>  - Modify schema definition of ap-domain to support hex values alone.
>  - Verify domain value of AP queue device to be within the supported
>    range during parsing.
>  - Re-organized patches 6 and 10 according to review comment.
>  - Minor changes according to review comments.
> 
> v2:
>  - The tests included in the patches to detect the node devices (AP
>    card, AP queues and AP matrix) are moved to separate patches.
>    These patches are not divided further due to the following reasons:
>     - The previous patches that add support for node devices in
>       libvirt are not divided further into smaller patches (eg:
>       53aec799fa31711ffaeacc7ec17ec6d3c2e3cadf).
>     - It would be easier to identify the patches relevant to support
>       AP node devices.
>     - The number of lines in each of these patches are around 125,
>       which is not too much.
> 
>  - Modified according to review comments.
> 
>  - New patch to detect mdev_types capabilty of AP matrix device is
>    added to this patch series.
> 
> Boris Fiuczynski (1):
>   node_device: detecting mdev_types capability on ap_matrix device
> 
> Farhan Ali (1):
>   virsh: nodedev: Filter by AP card and AP queue capabilities
> 
> Shalini Chellathurai Saroja (9):
>   nodedev: detect AP card device
>   tests: AP card node device
>   nodedev: detect AP queues
>   tests: AP queue node device
>   nodedev: detect AP matrix device
>   tests: AP matrix node device
>   virsh: nodedev: filter by AP Matrix capability
>   node_device: refactor address retrieval of node device
>   node_device: mdev matrix support
> 
>  docs/formatnode.html.in                       |  48 +++-
>  docs/manpages/virsh.rst                       |   2 +-
>  docs/schemas/nodedev.rng                      |  46 ++++
>  include/libvirt/libvirt-nodedev.h             |   3 +
>  src/conf/node_device_conf.c                   | 218 ++++++++++++++++++
>  src/conf/node_device_conf.h                   |  41 +++-
>  src/conf/virnodedeviceobj.c                   |  13 +-
>  src/libvirt-nodedev.c                         |   3 +
>  src/libvirt_private.syms                      |   1 +
>  src/node_device/node_device_driver.c          |  33 ++-
>  src/node_device/node_device_udev.c            |  86 +++++++
>  tests/nodedevschemadata/ap_07_0038.xml        |   9 +
>  tests/nodedevschemadata/ap_card07.xml         |   8 +
>  tests/nodedevschemadata/ap_matrix.xml         |   7 +
>  .../ap_matrix_mdev_types.xml                  |  14 ++
>  ...v_ee0b88c4_f554_4dc1_809d_b2a01e8e48ad.xml |   9 +
>  tests/nodedevxml2xmltest.c                    |   5 +
>  tools/virsh-nodedev.c                         |   9 +
>  18 files changed, 549 insertions(+), 6 deletions(-)
>  create mode 100644 tests/nodedevschemadata/ap_07_0038.xml
>  create mode 100644 tests/nodedevschemadata/ap_card07.xml
>  create mode 100644 tests/nodedevschemadata/ap_matrix.xml
>  create mode 100644 tests/nodedevschemadata/ap_matrix_mdev_types.xml
>  create mode 100644 tests/nodedevschemadata/mdev_ee0b88c4_f554_4dc1_809d_b2a01e8e48ad.xml
> 
> -- 
> 2.26.2
> 

Re: [PATCH libvirt v3 00/11] Support AP card, AP queues and AP matrix

Posted by Boris Fiuczynski 1 week, 3 days ago
On 11/19/20 12:53 PM, Erik Skultety wrote:
> On Tue, Nov 17, 2020 at 01:10:54PM +0100, Shalini Chellathurai Saroja wrote:
>> Add support for AP card devices, AP queues and AP matrix devices in
>> libvirt node device driver.
> Is there any public blueprint document or something that I can use to
> cross-reference this design & implementation to?
> 
> Regards,
> Erik
> 

Hi Erik,
a good starting point is here:
https://github.com/torvalds/linux/blob/master/Documentation/s390/vfio-ap.rst


-- 
Mit freundlichen Grüßen/Kind regards
    Boris Fiuczynski

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Gregor Pillen
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294