From nobody Sun Feb 8 18:15:52 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1605217762; cv=none; d=zohomail.com; s=zohoarc; b=Xt3gu4rVwTgpadNE1gV4vHks2LdhOkqZNGX8NzhPv2tAiPOoU5jp/knDNZsbc7Jv43WBEzgOAsaUEwU5Upf065DsgqQiFzQqUeaSCxvX8HkuL6mf4xbBQqUb7Bg0k4NAC0ISIkASWLl6hUIqWAyz9VX/mS2VqIjeEBJE4uxTt18= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605217762; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=DZ1kewH6Z88n5+My1DtrqrgK6pvDE4bOVbKcJcvTDNY=; b=E07FnBsS09r4IRGNnXl0HzmwTq7RDjmpP/Si8R070b1ULu4ko+sTtzu7XR7yC9qwGQzoedqSmqzjJTtADJ+1CDKNWwCzSTWr/MW3gecuk7fOEO2NOZF1DONJIGCf55FBcnovZOXOfCaHDfR78QoYoVSCBjgy3slgFxAENCp2FGo= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1605217762603172.33881871283359; Thu, 12 Nov 2020 13:49:22 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-24-RKKaxncyOLSrZ6_84bvHNA-1; Thu, 12 Nov 2020 16:49:19 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8D7921074643; Thu, 12 Nov 2020 21:49:12 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6A7575D9CA; Thu, 12 Nov 2020 21:49:12 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 36A3258118; Thu, 12 Nov 2020 21:49:12 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0ACLn27a005476 for ; Thu, 12 Nov 2020 16:49:02 -0500 Received: by smtp.corp.redhat.com (Postfix) id B58F910711F; Thu, 12 Nov 2020 21:49:02 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast03.extmail.prod.ext.rdu2.redhat.com [10.11.55.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5A78B107263 for ; Thu, 12 Nov 2020 21:48:59 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 20540811E78 for ; Thu, 12 Nov 2020 21:48:59 +0000 (UTC) Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-373-CsiEqoqLOOevhqff6kxEWw-1; Thu, 12 Nov 2020 16:48:56 -0500 Received: by mail-qk1-f174.google.com with SMTP id 11so7000023qkd.5 for ; Thu, 12 Nov 2020 13:48:56 -0800 (PST) Received: from rekt.ibmuc.com ([2804:431:c7c7:b9cd:904e:d02:53c4:1c05]) by smtp.gmail.com with ESMTPSA id i15sm5136931qke.16.2020.11.12.13.48.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2020 13:48:55 -0800 (PST) X-MC-Unique: RKKaxncyOLSrZ6_84bvHNA-1 X-MC-Unique: CsiEqoqLOOevhqff6kxEWw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DZ1kewH6Z88n5+My1DtrqrgK6pvDE4bOVbKcJcvTDNY=; b=lR13w2tjVXuLFjuwkDEw75xUvX2NrtJsk7FcxKIgLR2IIYC5eVjbNbG97ASaqZ6CEe 32zdG2PdhLXhHXHeBBKMngmd+0pTnvPn6HXTNgDMwd0WG6g+/GYlaarJVAQdEIXAa8t4 EWxU93aXRjnx+lQX4n4PMlsudUAbk086FhVorbvs/kH2buW4PMhy0p5ceiryvl23bKOy +6QFNKfY2/kBKrKGljhE8nh+qylP4muNk/gTzwmUpWcW+XDJ/77eAZWLfctGju8WtCf2 A4EivgxSrbJ+Dd2ACQEKs/2nhiJk3F3953HEtO2iDqAxxkyJsh9iDWPGMei7R3MwfYch jSVA== X-Gm-Message-State: AOAM531mIiDXGHg53BFiYFa/kYoMQ4gz3PGj6WR9iYmRv7Duxh7nSM8e ha+v5RNERCsfS+AbbdqyhEwUxDM5yBU= X-Google-Smtp-Source: ABdhPJyDdyMkWkn8SehA1gfkSEYwueY6jRLaweLqM6DzCiP3DsDz9tO7Zak7soCVc7Ytbfe7MdVRAA== X-Received: by 2002:a37:8c43:: with SMTP id o64mr2042948qkd.176.1605217736277; Thu, 12 Nov 2020 13:48:56 -0800 (PST) From: Daniel Henrique Barboza To: libvir-list@redhat.com Subject: [PATCH v1 05/10] qemu_snapshot.c: remove uneeded 'cleanup' label in qemuSnapshotDelete() Date: Thu, 12 Nov 2020 18:48:35 -0300 Message-Id: <20201112214840.636909-6-danielhb413@gmail.com> In-Reply-To: <20201112214840.636909-1-danielhb413@gmail.com> References: <20201112214840.636909-1-danielhb413@gmail.com> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-loop: libvir-list@redhat.com Cc: Daniel Henrique Barboza X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Signed-off-by: Daniel Henrique Barboza --- src/qemu/qemu_snapshot.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c index 8e3540bbc1..a31a62b7ec 100644 --- a/src/qemu/qemu_snapshot.c +++ b/src/qemu/qemu_snapshot.c @@ -2304,7 +2304,7 @@ qemuSnapshotDelete(virDomainObjPtr vm, VIR_DOMAIN_SNAPSHOT_DELETE_CHILDREN_ONLY, -1); =20 if (qemuDomainObjBeginJob(driver, vm, QEMU_JOB_MODIFY) < 0) - goto cleanup; + return -1; =20 if (!(snap =3D qemuSnapObjFromSnapshot(vm, snapshot))) goto endjob; @@ -2378,6 +2378,5 @@ qemuSnapshotDelete(virDomainObjPtr vm, endjob: qemuDomainObjEndJob(driver, vm); =20 - cleanup: return ret; } --=20 2.26.2