From nobody Sat Feb 7 18:51:45 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1605217755; cv=none; d=zohomail.com; s=zohoarc; b=YtZAiqAWfov6JpLT7KFvBDMHwvuEqwi09Apt2hLxAhFIZSoo0UyzJCJyD4xA0Amq4PaLhY6fxxgIhmx7vjV/goMKLww/fnCQIbf0QHSPyienul57wd5OWhxKkdVz7OUlC2/Md8HTqxn26ZmbQSzGZNdLbqeBypeMSK/n/Bw2aaE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605217755; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=1a3VoKWb6pAYePIKzKyOsHDUtsdBvUYTQg2xmBsQrtc=; b=UTEeYuUUEKmeOiJGHWDlklmwPEBqg13uOBpis2XiF/koSfmBHAQntqzwXKDClCFKmUw/TBlyosnohOe0mgZdm75YdlRhfWDS2GlCb2/TTciXAp+2ew0dgQmoj3z9BdeVDYTJ3FWw+B3Nm66yji+INh7L+a8CbX2vBnZ1RUplP18= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1605217755650183.0191870051632; Thu, 12 Nov 2020 13:49:15 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-118-reBvgX3AMrWtDpAEzXByLw-1; Thu, 12 Nov 2020 16:49:12 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 05E3C1009E35; Thu, 12 Nov 2020 21:49:07 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D84786EF5F; Thu, 12 Nov 2020 21:49:06 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A525B18037C6; Thu, 12 Nov 2020 21:49:06 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0ACLmwXs005448 for ; Thu, 12 Nov 2020 16:48:58 -0500 Received: by smtp.corp.redhat.com (Postfix) id 63CF01006512; Thu, 12 Nov 2020 21:48:58 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast05.extmail.prod.ext.rdu2.redhat.com [10.11.55.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5F9711007A21 for ; Thu, 12 Nov 2020 21:48:56 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 15F4990E422 for ; Thu, 12 Nov 2020 21:48:56 +0000 (UTC) Received: from mail-qk1-f194.google.com (mail-qk1-f194.google.com [209.85.222.194]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-581-4bInBSfLONqGdap6GLBnBg-1; Thu, 12 Nov 2020 16:48:53 -0500 Received: by mail-qk1-f194.google.com with SMTP id l2so7018065qkf.0 for ; Thu, 12 Nov 2020 13:48:53 -0800 (PST) Received: from rekt.ibmuc.com ([2804:431:c7c7:b9cd:904e:d02:53c4:1c05]) by smtp.gmail.com with ESMTPSA id i15sm5136931qke.16.2020.11.12.13.48.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2020 13:48:52 -0800 (PST) X-MC-Unique: reBvgX3AMrWtDpAEzXByLw-1 X-MC-Unique: 4bInBSfLONqGdap6GLBnBg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1a3VoKWb6pAYePIKzKyOsHDUtsdBvUYTQg2xmBsQrtc=; b=WIc4caNmlYXVno7EAw72dr5PBdW5z6TXBnCZtrake0qY4xAGlnmwZY6EnUpT9nQ7X3 X9N2jst2BubnhscQc4xnz8jYAom2Wz3cENDtmL/vMtSwWXIszfdz7P8G/7GpS2xrPR7D Upi6uIQKXBIcLrfx32ZMyCavn21k41/WJIsoL9pIcBiV22mWBqU9jXzHAjhGuCuXij5H RMRMsv5K9kfD5esLtaefjWUi5cEpFrelTEfmBUA5ZixBRTY0XelucyJwVwnoP5Rq/i23 AooQCchHEOqNzpemON1AcME9nqbZiu7T0A+3Bypljwrr2WxSLUHvDuPKS+XCiM0fyIEJ y7Bg== X-Gm-Message-State: AOAM531o5bmwByB+v9amTC4FQkvzwSQedR3gi9ZM0J4hAfXVhI/6in21 aLPJxnNXgXrFOxYl/K5dtATPPhEHTqA= X-Google-Smtp-Source: ABdhPJzI7sJwBbjCY0FpuYVuqgGP/ahVNcURMDvLl4TAfEaBKtGimVJykWh4mM39IkKkoS7WFfHykA== X-Received: by 2002:a37:f706:: with SMTP id q6mr2063192qkj.234.1605217733301; Thu, 12 Nov 2020 13:48:53 -0800 (PST) From: Daniel Henrique Barboza To: libvir-list@redhat.com Subject: [PATCH v1 03/10] qemu_driver.c: use g_autoptr() with virDomainDeviceDefPtr Date: Thu, 12 Nov 2020 18:48:33 -0300 Message-Id: <20201112214840.636909-4-danielhb413@gmail.com> In-Reply-To: <20201112214840.636909-1-danielhb413@gmail.com> References: <20201112214840.636909-1-danielhb413@gmail.com> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-loop: libvir-list@redhat.com Cc: Daniel Henrique Barboza X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Signed-off-by: Daniel Henrique Barboza --- src/qemu/qemu_driver.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 2198e7f1e9..6ff7289fd1 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -7748,9 +7748,9 @@ qemuDomainAttachDeviceLiveAndConfig(virDomainObjPtr v= m, qemuDomainObjPrivatePtr priv =3D vm->privateData; g_autoptr(virDomainDef) vmdef =3D NULL; g_autoptr(virQEMUDriverConfig) cfg =3D NULL; - virDomainDeviceDefPtr devConf =3D NULL; + g_autoptr(virDomainDeviceDef) devConf =3D NULL; virDomainDeviceDef devConfSave =3D { 0 }; - virDomainDeviceDefPtr devLive =3D NULL; + g_autoptr(virDomainDeviceDef) devLive =3D NULL; int ret =3D -1; unsigned int parse_flags =3D VIR_DOMAIN_DEF_PARSE_INACTIVE | VIR_DOMAIN_DEF_PARSE_ABI_UPDATE; @@ -7836,9 +7836,6 @@ qemuDomainAttachDeviceLiveAndConfig(virDomainObjPtr v= m, =20 ret =3D 0; cleanup: - virDomainDeviceDefFree(devConf); - virDomainDeviceDefFree(devLive); - return ret; } =20 @@ -7894,7 +7891,8 @@ static int qemuDomainUpdateDeviceFlags(virDomainPtr d= om, virDomainObjPtr vm =3D NULL; qemuDomainObjPrivatePtr priv; g_autoptr(virDomainDef) vmdef =3D NULL; - virDomainDeviceDefPtr dev =3D NULL, dev_copy =3D NULL; + g_autoptr(virDomainDeviceDef) dev =3D NULL; + virDomainDeviceDefPtr dev_copy =3D NULL; bool force =3D (flags & VIR_DOMAIN_DEVICE_MODIFY_FORCE) !=3D 0; int ret =3D -1; g_autoptr(virQEMUDriverConfig) cfg =3D NULL; @@ -7990,7 +7988,6 @@ static int qemuDomainUpdateDeviceFlags(virDomainPtr d= om, cleanup: if (dev !=3D dev_copy) virDomainDeviceDefFree(dev_copy); - virDomainDeviceDefFree(dev); virDomainObjEndAPI(&vm); virNWFilterUnlockFilterUpdates(); return ret; @@ -8004,7 +8001,8 @@ qemuDomainDetachDeviceLiveAndConfig(virQEMUDriverPtr = driver, { qemuDomainObjPrivatePtr priv =3D vm->privateData; g_autoptr(virQEMUDriverConfig) cfg =3D NULL; - virDomainDeviceDefPtr dev =3D NULL, dev_copy =3D NULL; + g_autoptr(virDomainDeviceDef) dev =3D NULL; + virDomainDeviceDefPtr dev_copy =3D NULL; unsigned int parse_flags =3D VIR_DOMAIN_DEF_PARSE_SKIP_VALIDATE; g_autoptr(virDomainDef) vmdef =3D NULL; int ret =3D -1; @@ -8080,7 +8078,6 @@ qemuDomainDetachDeviceLiveAndConfig(virQEMUDriverPtr = driver, cleanup: if (dev !=3D dev_copy) virDomainDeviceDefFree(dev_copy); - virDomainDeviceDefFree(dev); return ret; } =20 --=20 2.26.2