From nobody Mon Feb 9 00:20:37 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1605001921; cv=none; d=zohomail.com; s=zohoarc; b=C/aPQ9punuvjPqIr5oE+Kw3Sk6DY9PsXxcTM4cohdxUIVB7AUo+Qc5ZcvEqmRxVbVv2YMCO+zQcuENN2GgCQY5sKdwHNhU3fDYgD7C4GQ8xWDrp13qQ2ryg1khQhQ8sW+yVmVG1oNSuLMB8eL4DZ3+k3KuXXazV4gqk38F/7Qvo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605001921; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=mdLtNJYaozG32ggm4jKva9Tv1c0INsjG0+qampaLNvY=; b=l2ObKOZt2XKcOTffayql7txoFbImwgNg7ewckQGQDyRWcomNo4lU17VKbNqMYIGmsHk0j9OOHYqzVX0NwjB7fRnNEHC3Z8bRVbY/tspx81XEXPBWkCm6muER7Qce5e3UH2UwLeZvh5pCxnU7hnuN4R7nAhAFBmBaemK5JLXswvg= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1605001921064746.7638758165684; Tue, 10 Nov 2020 01:52:01 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-505-V3a7zGTSN4CYJVGFcFRowQ-1; Tue, 10 Nov 2020 04:51:57 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DAAE7107B472; Tue, 10 Nov 2020 09:51:51 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B664F5CC26; Tue, 10 Nov 2020 09:51:51 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 83C1758116; Tue, 10 Nov 2020 09:51:51 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0AA9pbFE006559 for ; Tue, 10 Nov 2020 04:51:37 -0500 Received: by smtp.corp.redhat.com (Postfix) id 7E8AE2156A49; Tue, 10 Nov 2020 09:51:37 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast04.extmail.prod.ext.rdu2.redhat.com [10.11.55.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7828F2156A3A for ; Tue, 10 Nov 2020 09:51:37 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5F8421021F8C for ; Tue, 10 Nov 2020 09:51:37 +0000 (UTC) Received: from de-smtp-delivery-52.mimecast.com (de-smtp-delivery-52.mimecast.com [51.163.158.52]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-465-CNqiOMyZPlCvYo6IpNtrig-1; Tue, 10 Nov 2020 04:51:34 -0500 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2055.outbound.protection.outlook.com [104.47.13.55]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-39-KOarS7KuMayAW7da8doU_A-5; Tue, 10 Nov 2020 10:51:31 +0100 Received: from AM6PR04MB5782.eurprd04.prod.outlook.com (2603:10a6:20b:aa::17) by AS8PR04MB7734.eurprd04.prod.outlook.com (2603:10a6:20b:2a6::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21; Tue, 10 Nov 2020 09:51:29 +0000 Received: from AM6PR04MB5782.eurprd04.prod.outlook.com ([fe80::8945:92d8:e72a:6245]) by AM6PR04MB5782.eurprd04.prod.outlook.com ([fe80::8945:92d8:e72a:6245%6]) with mapi id 15.20.3541.025; Tue, 10 Nov 2020 09:51:29 +0000 Received: from t440p.suse.asia (60.251.47.115) by AM4P190CA0015.EURP190.PROD.OUTLOOK.COM (2603:10a6:200:56::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21 via Frontend Transport; Tue, 10 Nov 2020 09:51:27 +0000 X-MC-Unique: V3a7zGTSN4CYJVGFcFRowQ-1 X-MC-Unique: CNqiOMyZPlCvYo6IpNtrig-1 X-MC-Unique: KOarS7KuMayAW7da8doU_A-5 From: Lin Ma To: libvir-list@redhat.com Subject: [libvirt] [PATCH v2 02/13] virsh: Add logical CPU IDs completion for nodecpustats command Date: Tue, 10 Nov 2020 17:50:53 +0800 Message-ID: <20201110095104.10783-3-lma@suse.com> In-Reply-To: <20201110095104.10783-1-lma@suse.com> References: <20201110095104.10783-1-lma@suse.com> X-Originating-IP: [60.251.47.115] X-ClientProxiedBy: AM4P190CA0015.EURP190.PROD.OUTLOOK.COM (2603:10a6:200:56::25) To AM6PR04MB5782.eurprd04.prod.outlook.com (2603:10a6:20b:aa::17) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 497580e0-841d-4a7b-8705-08d8855e322d X-MS-TrafficTypeDiagnostic: AS8PR04MB7734: X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1013 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0 X-Microsoft-Antispam-Message-Info: 6I/Rwp/JTZo31rZqqLwb3ruQ/lTqoDfQbevBwomPK/pcG/xEJ3Hp7uo0uWYQ7tSqYxdOTmgL5FujDwGe1KBkZBWkdVKtH8EhgIACnA+2Q9V3budGjPX7OoD9Lh4YFgIH8egbHHPt/mvIVhs9F/LNZw9H0ebAz6s0Pp/t7J0XGm4gHR2cAcQLwFQoIOJUmn7ydZFpFBgGfi1tXeRav/nhpYsMzLQyzAkT/5oRtebjxk18HPkmitpj7N8xKDB9cP3qCvskkV9YcpP+tklvcN00GUmCamiNAerKy43yJD9YZ64AjclZ0qMK7yemZ60d2iRZDZNzKVJBgLhPl36jJ/UUlg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR04MB5782.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(396003)(39860400002)(346002)(366004)(376002)(136003)(8936002)(2906002)(8676002)(66556008)(6666004)(2616005)(52116002)(107886003)(55236004)(6506007)(956004)(83380400001)(4326008)(6512007)(86362001)(36756003)(5660300002)(316002)(1076003)(66476007)(66946007)(478600001)(450100002)(16526019)(6916009)(26005)(186003)(6486002); DIR:OUT; SFP:1101 X-MS-Exchange-AntiSpam-MessageData: oeZv6kwfVpcE0h7qTIPvplg4OMC4K3JDzdDcx2XO42YL7Qv8iQhdWsX9rRepZZ0cRGFogfbmxa8lJiQOw2/DiCeV91ivWwxiFJd2Cpxbc43yh1OibfBGeGXXDfEJSooRLVFBM4fDx3NAo+MJDUVzXG5+pYQzPF7lxFVq3nSl6ybsHKN7kEAjw7UDXM3LcVeNlT2pa2DURToDzk+P2oTBgyvBR2z2JF9/dINFGc8/bhhhfWydYARsph0UFYAvpZMyo9Ie0llgJetCqYdT0vz0Zu3G6y47R1PMk5UlqFLDpxVNKFirbC5njuULeCZ6OM0hozxFhvnFiU212Swu4bqMe4KgrHSkjUoGZseJ/+66BJT7NaLIDQmGCVpJP9Uhrgg5ff/zZgVmLgRVe/x2OVosgW4Ab8dcjVFK8538t5Ywuaxk5pWxINeIO+qzBGN1r/sbXq0MSydtN6ll5t4alPnPhHef5p61ozMbmIbcaf10I0ZaiWtd+Wb0WF0g2wJepce3K1tzj0kD1Jsx00YQMz3R/u0LycogDWrZp0OnA6sBpCQHjJMPfm+vkB+1Jgq2mP8n9kj9TzlTzNPumX9BQvsXFqlXBCpkmShPpILrTXVdAcTMWkXzomBdpViJ2izo02YCyXvNRNBKWe5Yk3aue1Am/xsDdtnTU6MebfgqikKE+Phlb2vxNhEcjXBzyNoiVkQu/ZBDwMRQIHpXymwzfHaUwUJ7Gv/bQNHPZPa42i1bS8LOJROs/KLXfrIWcaaQMdC7HAIZb2kjZRLsePv/De94cX9WkBNP5i4s9F60EQD4+sYmyHF2XF92AHfjMdUNfda/iXojpYFquY1mpXpvX8YkDV/GP8JTnDQL04wShz+ADcs6S2NJc3Fs51eTpkbYhJWC5JNqn3saE8Mb+1XnUdepmA== X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 497580e0-841d-4a7b-8705-08d8855e322d X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB5782.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2020 09:51:29.2347 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dw6mIPULQaLBFpJOwAufBdSfCbrBJnmssbaW9I6fhx1IHCxmiBC6RO209yeWBCw6 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7734 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 0AA9pbFE006559 X-loop: libvir-list@redhat.com Cc: mprivozn@redhat.com, Lin Ma X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Signed-off-by: Lin Ma --- tools/virsh-completer-host.c | 31 +++++++++++++++++++++++++++++++ tools/virsh-completer-host.h | 4 ++++ tools/virsh-host.c | 1 + 3 files changed, 36 insertions(+) diff --git a/tools/virsh-completer-host.c b/tools/virsh-completer-host.c index 339390aa00..685fa23fd4 100644 --- a/tools/virsh-completer-host.c +++ b/tools/virsh-completer-host.c @@ -136,3 +136,34 @@ virshCellnoCompleter(vshControl *ctl, =20 return g_steal_pointer(&tmp); } + + +char ** +virshCpuCompleter(vshControl *ctl, + const vshCmd *cmd G_GNUC_UNUSED, + unsigned int flags) +{ + virshControlPtr priv =3D ctl->privData; + VIR_AUTOSTRINGLIST tmp =3D NULL; + size_t i; + int cpunum; + size_t offset =3D 0; + unsigned int online; + g_autofree unsigned char *cpumap =3D NULL; + + virCheckFlags(0, NULL); + + if ((cpunum =3D virNodeGetCPUMap(priv->conn, &cpumap, &online, 0)) < 0) + return NULL; + + tmp =3D g_new0(char *, online + 1); + + for (i =3D 0; i < cpunum; i++) { + if (VIR_CPU_USED(cpumap, i) =3D=3D 0) + continue; + + tmp[offset++] =3D g_strdup_printf("%zu", i); + } + + return g_steal_pointer(&tmp); +} diff --git a/tools/virsh-completer-host.h b/tools/virsh-completer-host.h index 921beb7a2d..777783b908 100644 --- a/tools/virsh-completer-host.h +++ b/tools/virsh-completer-host.h @@ -29,3 +29,7 @@ char ** virshAllocpagesPagesizeCompleter(vshControl *ctl, char ** virshCellnoCompleter(vshControl *ctl, const vshCmd *cmd, unsigned int flags); + +char ** virshCpuCompleter(vshControl *ctl, + const vshCmd *cmd, + unsigned int flags); diff --git a/tools/virsh-host.c b/tools/virsh-host.c index cda2ef4ac1..4774f76ed8 100644 --- a/tools/virsh-host.c +++ b/tools/virsh-host.c @@ -751,6 +751,7 @@ static const vshCmdInfo info_nodecpustats[] =3D { static const vshCmdOptDef opts_node_cpustats[] =3D { {.name =3D "cpu", .type =3D VSH_OT_INT, + .completer =3D virshCpuCompleter, .help =3D N_("prints specified cpu statistics only.") }, {.name =3D "percent", --=20 2.26.0