From nobody Thu May 2 10:13:43 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1604618667; cv=none; d=zohomail.com; s=zohoarc; b=GTGW1wunuxlzM5PhtERFT1vf+Ks7tAVMW1s3LFTKDlad6wABC6KkPTQ2+k9WUApeDYVqzRLaKdxoe7vjrXhkpZju4y941EPlvGNEaDMZZO5O1Jo/XpxUR6C4QbA2wVAZbKAI6X040rycVc5sKBGt+KoD+6uCdv43dqB2i7DoD/s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1604618667; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=MdK5jBRlB6Lpgnw8k8lj+Kwl1vAEtK7WMS+bgDUAYtY=; b=EDeXErpyIXZkcBH9+583c1scC+NZYzFfzY2oW5BvjPawJ3vBIp8gtgdGpsy7O55FdR7jPOfWVlOJvAf7Gam2yx/JDOy6V1FcEQKOL/ep0Pum/Ng7onsGsHt0j+7sr3aojiUrm4datQCNchdfLuIV6cqO/pTO1abdHPQaTqUGXxI= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1604618666710167.58830383310953; Thu, 5 Nov 2020 15:24:26 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-84-VQBSD4sXNDefOhW9zq0rzA-1; Thu, 05 Nov 2020 18:24:23 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 18C121006C80; Thu, 5 Nov 2020 23:24:17 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DB7A219728; Thu, 5 Nov 2020 23:24:15 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id BE96186BE8; Thu, 5 Nov 2020 23:24:12 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0A5NOA40014028 for ; Thu, 5 Nov 2020 18:24:10 -0500 Received: by smtp.corp.redhat.com (Postfix) id 58724207B114; Thu, 5 Nov 2020 23:24:10 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast05.extmail.prod.ext.rdu2.redhat.com [10.11.55.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 539B4207A522 for ; Thu, 5 Nov 2020 23:24:08 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D5CFA90E42C for ; Thu, 5 Nov 2020 23:24:07 +0000 (UTC) Received: from smtp.263.net (regular2.263xmail.com [211.157.152.6]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-86-IUoJ3X-tPlCqrw8BDr47DQ-1; Thu, 05 Nov 2020 18:24:04 -0500 Received: from regular1.263xmail.com (unknown [192.168.165.111]) by smtp.263.net (Postfix) with ESMTP id 30ECE20B for ; Fri, 6 Nov 2020 07:20:32 +0800 (CST) Received: from localhost (unknown [192.168.167.13]) by regular1.263xmail.com (Postfix) with ESMTP id 7D6CA703 for ; Fri, 6 Nov 2020 07:20:24 +0800 (CST) Received: from localhost.localdomain (unknown [14.18.236.70]) by smtp.263.net (postfix) whith ESMTP id P9248T140658805294848S1604618419899594_; Fri, 06 Nov 2020 07:20:24 +0800 (CST) X-MC-Unique: VQBSD4sXNDefOhW9zq0rzA-1 X-MC-Unique: IUoJ3X-tPlCqrw8BDr47DQ-1 X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-ADDR-CHECKED4: 1 X-ANTISPAM-LEVEL: 2 X-SKE-CHECKED: 1 X-ABS-CHECKED: 1 X-IP-DOMAINF: 1 X-UNIQUE-TAG: <669b04b49485c70900117da468ecf1c9> X-RL-SENDER: yili@winhong.com X-SENDER: yili@winhong.com X-LOGIN-NAME: yili@winhong.com X-FST-TO: libvir-list@redhat.com X-SENDER-IP: 14.18.236.70 X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 X-System-Flag: 0 From: Yi Li To: libvir-list@redhat.com Subject: [PATCH] util: xml: remove unused function virXMLChildElementCount Date: Fri, 6 Nov 2020 07:20:00 +0800 Message-Id: <20201105232000.3524028-1-yili@winhong.com> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 0A5NOA40014028 X-loop: libvir-list@redhat.com Cc: yilikernel@gmail.com, yili@winhong.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" --- src/libvirt_private.syms | 1 - src/util/virxml.c | 21 --------------------- src/util/virxml.h | 1 - 3 files changed, 23 deletions(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 9029ea4fa2..36ab84162c 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -3504,7 +3504,6 @@ virVsockSetGuestCid; # util/virxml.h virParseScaledValue; virXMLCheckIllegalChars; -virXMLChildElementCount; virXMLExtractNamespaceXML; virXMLFormatElement; virXMLNodeContentString; diff --git a/src/util/virxml.c b/src/util/virxml.c index 8a94de8fe4..a3b819d85c 100644 --- a/src/util/virxml.c +++ b/src/util/virxml.c @@ -934,27 +934,6 @@ virXMLSaveFile(const char *path, return virFileRewrite(path, S_IRUSR | S_IWUSR, virXMLRewriteFile, &dat= a); } =20 -/* Returns the number of children of node, or -1 on error. */ -long -virXMLChildElementCount(xmlNodePtr node) -{ - long ret =3D 0; - xmlNodePtr cur =3D NULL; - - /* xmlChildElementCount returns 0 on error, which isn't helpful; - * besides, it is not available in libxml2 2.6. */ - if (!node || node->type !=3D XML_ELEMENT_NODE) - return -1; - cur =3D node->children; - while (cur) { - if (cur->type =3D=3D XML_ELEMENT_NODE) - ret++; - cur =3D cur->next; - } - return ret; -} - - /** * virXMLNodeToString: convert an XML node ptr to an XML string * diff --git a/src/util/virxml.h b/src/util/virxml.h index b73591c3df..f73b8975ba 100644 --- a/src/util/virxml.h +++ b/src/util/virxml.h @@ -77,7 +77,6 @@ char * virXMLPropStringLimit(xmlNodePtr node, const char *name, size_t maxlen); char * virXMLNodeContentString(xmlNodePtr node); -long virXMLChildElementCount(xmlNodePtr node); =20 /* Internal function; prefer the macros below. */ xmlDocPtr virXMLParseHelper(int domcode, --=20 2.25.3