From nobody Mon Feb 9 01:16:33 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1604305686; cv=none; d=zohomail.com; s=zohoarc; b=ODQEjuI/eHvYkLRl0SHujcUhzSCVoad+NvyCqVkDksJc6QkAf2HhedopjEI4BJg+TFSWYTvGe1hDSmIxOnMYZnTsf4Kf05CKslCjj6bJkaN/MEtSpk+nOLmGSShCCISUJyJL7BI6aiK2qDw/pMsZkW7HiN2rCi6vVKzQCgvx0Bw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1604305686; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=LkFOz41b5WgHytw6rkvR2tx1fw6A1Es7hpTfv03RoJE=; b=bOkQCNNqfAIDiVJcYOdsxHVcQAaju6j8R/pu6SkCnSyWeqdNs5xGJhnYhYXsqYUYZHMkfJfpCNoRjP+ISCB9RTDoSJ+LQxfWErMSfPBy2BkPcEJQSSvySQkDe4QTsLLtdT3TTFHs6Xmc2wK2bJjiGjomKAxzXW7qFuHJbEszBrs= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 160430568662257.24779985815212; Mon, 2 Nov 2020 00:28:06 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-553-xFxpKuDcN9Cc7Qi-hRRyfA-1; Mon, 02 Nov 2020 03:27:37 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8FCFA801FD7; Mon, 2 Nov 2020 08:27:31 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6643D5C5AF; Mon, 2 Nov 2020 08:27:31 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 31075181A87F; Mon, 2 Nov 2020 08:27:31 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0A28RKEB031370 for ; Mon, 2 Nov 2020 03:27:20 -0500 Received: by smtp.corp.redhat.com (Postfix) id 6C0882156A36; Mon, 2 Nov 2020 08:27:20 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast05.extmail.prod.ext.rdu2.redhat.com [10.11.55.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 644E62156A39 for ; Mon, 2 Nov 2020 08:27:18 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 051598D632D for ; Mon, 2 Nov 2020 08:27:18 +0000 (UTC) Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [51.163.158.102]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-312-F7FmVIPPOJeYTSDF517MpQ-1; Mon, 02 Nov 2020 03:27:15 -0500 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02lp2057.outbound.protection.outlook.com [104.47.5.57]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-25-MiLiaeDLPv2TCnjCC1raDw-1; Mon, 02 Nov 2020 09:27:11 +0100 Received: from AM6PR04MB5782.eurprd04.prod.outlook.com (2603:10a6:20b:aa::17) by AM6PR04MB6119.eurprd04.prod.outlook.com (2603:10a6:20b:bc::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.27; Mon, 2 Nov 2020 08:27:10 +0000 Received: from AM6PR04MB5782.eurprd04.prod.outlook.com ([fe80::b5ca:e454:9fad:8712]) by AM6PR04MB5782.eurprd04.prod.outlook.com ([fe80::b5ca:e454:9fad:8712%7]) with mapi id 15.20.3499.030; Mon, 2 Nov 2020 08:27:10 +0000 Received: from t440p.suse.asia (60.251.47.115) by AM9P191CA0007.EURP191.PROD.OUTLOOK.COM (2603:10a6:20b:21c::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.19 via Frontend Transport; Mon, 2 Nov 2020 08:27:08 +0000 X-MC-Unique: xFxpKuDcN9Cc7Qi-hRRyfA-1 X-MC-Unique: F7FmVIPPOJeYTSDF517MpQ-1 X-MC-Unique: MiLiaeDLPv2TCnjCC1raDw-1 From: Lin Ma To: libvir-list@redhat.com Subject: [libvirt] [PATCH 15/19] virsh-domain: Apply macro VIRSH_DOMAIN_OPT_MAC for mac option Date: Mon, 2 Nov 2020 16:26:17 +0800 Message-ID: <20201102082621.13228-16-lma@suse.com> In-Reply-To: <20201102082621.13228-1-lma@suse.com> References: <20201102082621.13228-1-lma@suse.com> X-Originating-IP: [60.251.47.115] X-ClientProxiedBy: AM9P191CA0007.EURP191.PROD.OUTLOOK.COM (2603:10a6:20b:21c::12) To AM6PR04MB5782.eurprd04.prod.outlook.com (2603:10a6:20b:aa::17) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 27835532-5bea-4014-158b-08d87f0917a0 X-MS-TrafficTypeDiagnostic: AM6PR04MB6119: X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:296 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0 X-Microsoft-Antispam-Message-Info: 8Yicji4mMBje2VWBes6YiymyE+/0s1kq3RWIxrSJZIjqM4NUSGU4vgha08r86TVk6H2yIqVHt3lqcEdlzc13VZBICIqiwSLHzZB8mGc9WG/mn5gu5NfO9STi+a0Pea3lbGycP9BecoVCm5oARSE4Il8Xv97GQehKRMxiRbMH8J5KpfS5sjujR36h+p9pBWHA8D4elctyqBYuREeNvOXkYRnqfx148+R1RzyC6tJhIEST+FUEsCxw/paJck7X9eHb8xLgJv0Uukl9hNGJKHtrarLT8uPeZtS2hKKJH/udx8Crx+aUFlB1bFHqJV/HAHvH X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR04MB5782.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(39860400002)(366004)(376002)(346002)(136003)(396003)(6512007)(8676002)(450100002)(316002)(6506007)(66946007)(66556008)(66476007)(2906002)(107886003)(4744005)(5660300002)(83380400001)(8936002)(4326008)(52116002)(55236004)(6486002)(6916009)(16526019)(186003)(6666004)(36756003)(478600001)(2616005)(956004)(86362001)(26005)(1076003); DIR:OUT; SFP:1101 X-MS-Exchange-AntiSpam-MessageData: r3NTlBTsCilxypZC+mbMlgw65kMsTrfhUS+ppE2NWJwMEJQfcFPi2xwMFJQ3WhpN0+dTTXm9bh77x/UNH8zfonVNTNz140J/8cYdBhdPEj5KIKAWElQoqofiLff/az/CUIF1obyIcQUWt6PV3n9VCaHqyfWncK+E72pFMBY7PfuOl4jkNjESs04l/XuddIdyy1S/xFoHW8WxOokcuPYjJEQ8xVOne7uAWjZ90o9jxEEgnTD1XXXtiOqD+S2RcKyjBFR2OuzfIpCSZoDqDnpa8r3wC/2WFT507vCToVVJtlpFw7TQHXGJe8q+H6YbwAdF/btDLIIoHfZlFUER1EiW6qFLTrXDzhxT89THE2o2sOLkSTJkfJkJ/2iTqvyRPttLPEqm0jDaYjBP6jxcE9sBpBvpaAbLB2FK7Hmh/Wr5jGKDeTS9gT7cd3G3HxCiO9U3ejxWJaPRazN0PRV77hr6VuXXZDawDO+PB4KJ/Uk21vCTjVK9fZ6I1cLtzIRelClrUmQT+JQ6U8FMB7/fY/W6ucLmsaCQEzb8+TXMBJkTkBXUEO/Laz0lRJkLt5z+pbkZsHU9OsSPte4Mjq1Z/qbn9cKUrIpkrx/H4URukq6H1KCUyydPVEEF61ttyaqF70rPyjFC+SloWQdPvdhORu2hBQ== X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 27835532-5bea-4014-158b-08d87f0917a0 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB5782.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2020 08:27:10.4553 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iONkpGDXMxf2Znt+o2o7ES0B+1iI25ouQAq/RkZPrfabmZpjew2cedYmPHfTmsEY X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6119 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 0A28RKEB031370 X-loop: libvir-list@redhat.com Cc: mprivozn@redhat.com, Lin Ma X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Signed-off-by: Lin Ma --- tools/virsh-domain.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index d50fdbad26..ed7307cdb6 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -12291,12 +12291,7 @@ static const vshCmdOptDef opts_detach_interface[] = =3D { .flags =3D VSH_OFLAG_REQ, .help =3D N_("network interface type") }, - {.name =3D "mac", - .type =3D VSH_OT_STRING, - .completer =3D virshDomainInterfaceCompleter, - .completer_flags =3D VIRSH_DOMAIN_INTERFACE_COMPLETER_MAC, - .help =3D N_("MAC address") - }, + VIRSH_DOMAIN_OPT_MAC(N_("MAC address"), VSH_OFLAG_REQ_OPT), VIRSH_COMMON_OPT_DOMAIN_PERSISTENT, VIRSH_COMMON_OPT_DOMAIN_CONFIG, VIRSH_COMMON_OPT_DOMAIN_LIVE, --=20 2.26.0