From nobody Mon Feb 9 08:56:34 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1604305649; cv=none; d=zohomail.com; s=zohoarc; b=NosfOnoKyYi06amgyoPThcsFX2g6R9txsmMnF2l/lDY+uH8ZorZtifMy6RrCl9fzcN6oDbh/piCO7OwXuHmfUt3kh55tlTtR7t/iWDQNYzSm+aqqWqTCKYVEfImtFUZPyKz6iol8mL6ggxxeyybGr6pdPEgC4pEkLvFftMpW6gk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1604305649; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=wyJSdDwzF17G3Ik9fhxcGLHc9a+w2dvW5EQLRMZfxvQ=; b=YnSb1WM9nhJeRIsd5aQ29bCHXLUnQizLlpdZztamRPQCbmcu7/M0ixaGBUQEuK1yzhOt66KWVpWWwoos3gaLXKUItfhhwznFtci/T/U1BH6aZPPY2o6G5OkC32KbV3okwjEwFsDmifkwiiDlp2xVD6mJc4pp1PYcMU4lthXjtl0= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 160430564980744.14186841683863; Mon, 2 Nov 2020 00:27:29 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-25-nSHiyFyoOc6VvT7qhwE1eg-1; Mon, 02 Nov 2020 03:27:25 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7549D186840D; Mon, 2 Nov 2020 08:27:17 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 54D1E73664; Mon, 2 Nov 2020 08:27:17 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 1F85C181A261; Mon, 2 Nov 2020 08:27:17 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0A28RCs9031293 for ; Mon, 2 Nov 2020 03:27:12 -0500 Received: by smtp.corp.redhat.com (Postfix) id 351521111A4F; Mon, 2 Nov 2020 08:27:12 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3016C1111A41 for ; Mon, 2 Nov 2020 08:27:10 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6A480801224 for ; Mon, 2 Nov 2020 08:27:10 +0000 (UTC) Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [62.140.7.102]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-550-TaAoZ_neNHWUKKADZDbgXg-1; Mon, 02 Nov 2020 03:27:08 -0500 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01lp2052.outbound.protection.outlook.com [104.47.1.52]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-36-WL-ekE-ONbG8B8Qtrk9j1Q-2; Mon, 02 Nov 2020 09:27:04 +0100 Received: from AM6PR04MB5782.eurprd04.prod.outlook.com (2603:10a6:20b:aa::17) by AM6PR0402MB3624.eurprd04.prod.outlook.com (2603:10a6:209:4::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.30; Mon, 2 Nov 2020 08:27:02 +0000 Received: from AM6PR04MB5782.eurprd04.prod.outlook.com ([fe80::b5ca:e454:9fad:8712]) by AM6PR04MB5782.eurprd04.prod.outlook.com ([fe80::b5ca:e454:9fad:8712%7]) with mapi id 15.20.3499.030; Mon, 2 Nov 2020 08:27:02 +0000 Received: from t440p.suse.asia (60.251.47.115) by AM9P191CA0007.EURP191.PROD.OUTLOOK.COM (2603:10a6:20b:21c::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.19 via Frontend Transport; Mon, 2 Nov 2020 08:26:58 +0000 X-MC-Unique: nSHiyFyoOc6VvT7qhwE1eg-1 X-MC-Unique: TaAoZ_neNHWUKKADZDbgXg-1 X-MC-Unique: WL-ekE-ONbG8B8Qtrk9j1Q-2 From: Lin Ma To: libvir-list@redhat.com Subject: [libvirt] [PATCH 10/19] virsh: Only return domains that have VNC display to vncdisplay command Date: Mon, 2 Nov 2020 16:26:12 +0800 Message-ID: <20201102082621.13228-11-lma@suse.com> In-Reply-To: <20201102082621.13228-1-lma@suse.com> References: <20201102082621.13228-1-lma@suse.com> X-Originating-IP: [60.251.47.115] X-ClientProxiedBy: AM9P191CA0007.EURP191.PROD.OUTLOOK.COM (2603:10a6:20b:21c::12) To AM6PR04MB5782.eurprd04.prod.outlook.com (2603:10a6:20b:aa::17) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1cdec77b-894b-49fb-b7e8-08d87f091171 X-MS-TrafficTypeDiagnostic: AM6PR0402MB3624: X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:346 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0 X-Microsoft-Antispam-Message-Info: y4lauW0uAiZQhK6maLGZgAWkli64imw8mbvQfpNz4hofRMYWWOKRPyAXl2T2k7P1P/iimEGqm5sWP0vNzLhsvu8UY+y/Dh8WY4adNd8zU/FzY9ppnhWW/fQgH6iv2QbNoc9b4uZ/pFbm0pbWqj9rSBYBLXx05ZFCKgS7p+SPBkx0DKdKfnfIXMVJMv6Kyj8uldj2ilvkeWp65cKDIoNLnG0b8uRSp10l8mZNTE9wGEYR4wKIy45+tKTr7hf9TbdlpKI7p9zQdXUOIWUyjQFhiGOVqQK2Qite4iioA/T2o2kckyojVCkJdfja6+L2QhuRuJMouSb1xYiLsZeka41CZg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR04MB5782.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(39860400002)(396003)(376002)(136003)(366004)(107886003)(6666004)(5660300002)(16526019)(66556008)(66946007)(66476007)(2616005)(956004)(8676002)(6506007)(186003)(316002)(450100002)(4326008)(52116002)(26005)(478600001)(8936002)(2906002)(36756003)(55236004)(86362001)(1076003)(6916009)(6486002)(83380400001)(6512007); DIR:OUT; SFP:1101 X-MS-Exchange-AntiSpam-MessageData: W0rN4dhcN55YhYJRAqOvwBEModsPHImNjdrVsU7XcszjJ4cx7Wus5wSRmBv3gQRl0DooLP4ZYbrvIQNRfykX0aenuUgt1X+V0EBgNA8FzucxznOIINGNdA8yztpmGt0pbGqD7cFVTUKGt5hPc+2MVpRvKKxJGiDgwgV5tmth/OJ0z2vTNvv/rlOb+C1Ks10vwAm/GH+QAPeKqSCDAZM0uvIzMOaD8jep3VvAfTXzN0Gbz90utHtWGtY46qfQPzQ10cvn3ufAhqIcoh+AD9G5ad/n30JScJxb6bjugIIrWOXXHBKLRVDJGaqUu85c6Ws9EpYG7+Md0Pkb0oPOeKl6hrbGAXLVRW/noIs4KNiIbWui3uyNWA8xbD7KdTSgGC6t2WGvZuRAxsV6u+FsoGySSon3ox7ItNK/vIFEBhmJm5JMRoMpFAWOndDs5/VOl2yuPzBJkmG4iirsG1UU/Sem8psleYAJraCOCOvl5QnP+MIHcmbvxtXbzq//X68YRFgnnY6CKwfUQ9akYCH4jsri4LWk1C6uNJOblAMOtTARoRfgqOtPvijtuPBwpOXM4tCQ8mT3LCxurZecy4vYudXbsX5Vp8yaQKiqPIp81Eze1Bw9h1RYEV9effnRKxON0vqMXO8oVeZArlE7/pmx+IH2OA== X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1cdec77b-894b-49fb-b7e8-08d87f091171 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB5782.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2020 08:27:00.0881 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VKCXgNWBQS72w0nqPhcIuvugE1/Fk6XyzUyDMH3mTV0b5iIaf4WFQmFnVOSPqs6F X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0402MB3624 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 0A28RCs9031293 X-loop: libvir-list@redhat.com Cc: mprivozn@redhat.com, Lin Ma X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Signed-off-by: Lin Ma --- tools/virsh-completer-domain.c | 3 ++- tools/virsh-domain.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/virsh-completer-domain.c b/tools/virsh-completer-domain.c index ab81a0dcfe..305711151f 100644 --- a/tools/virsh-completer-domain.c +++ b/tools/virsh-completer-domain.c @@ -52,7 +52,8 @@ virshDomainNameCompleter(vshControl *ctl, VIR_CONNECT_LIST_DOMAINS_SHUTOFF | VIR_CONNECT_LIST_DOMAINS_MANAGEDSAVE | VIR_CONNECT_LIST_DOMAINS_HAS_SNAPSHOT | - VIR_CONNECT_LIST_DOMAINS_HAS_CHECKPOINT, + VIR_CONNECT_LIST_DOMAINS_HAS_CHECKPOINT | + VIR_CONNECT_LIST_DOMAINS_HAS_VNC, NULL); =20 if (!priv->conn || virConnectIsAlive(priv->conn) <=3D 0) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 7189c8c826..5b9970fdf5 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -11759,7 +11759,8 @@ static const vshCmdInfo info_vncdisplay[] =3D { }; =20 static const vshCmdOptDef opts_vncdisplay[] =3D { - VIRSH_COMMON_OPT_DOMAIN_FULL(VIR_CONNECT_LIST_DOMAINS_ACTIVE), + VIRSH_COMMON_OPT_DOMAIN_FULL(VIR_CONNECT_LIST_DOMAINS_ACTIVE | + VIR_CONNECT_LIST_DOMAINS_HAS_VNC), {.name =3D NULL} }; =20 --=20 2.26.0