From nobody Mon Feb 9 02:51:14 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1604305656; cv=none; d=zohomail.com; s=zohoarc; b=U1CQEMwkKVvud2xsXId4ChVWkNsK91Xouj6+qLLEmj/VwGdHrNQnAzxTVWqrkutQ5ygwrIaW452Prvg4dxCVw5ZtwAF1M8R+UmnXxYoVPkPfjigjuN212lpYKNM9wuAFREBmCNAtl6XI9vjMZdf72dBs3ncRiogRBspxc53gyNc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1604305656; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=KJ3OomqzyNX1oxfaXrP+C8JQzRkMnMHvrzCbVIshKsA=; b=OTso6ewiap44Uhe1KDqC6YsjnCy2bzk3mCEMzKZdTx2igtnuFT9TLRz1Th7tGOwAQdWW9FsGouzRvs4aj1Hk9yDZbBU0vZbxyZR7EFND5OWWCb8VZq8TfTh/teF4djYU4VJa5o0/Kx46I6Kgac7htOV7274o00XUhcA+3p2xElE= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1604305656884689.4938221769368; Mon, 2 Nov 2020 00:27:36 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-476-_jpim7eJPqWoZRdDhALHXA-1; Mon, 02 Nov 2020 03:27:32 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 76B1A809DDF; Mon, 2 Nov 2020 08:27:25 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 538DA62A14; Mon, 2 Nov 2020 08:27:25 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 1AF7C181A870; Mon, 2 Nov 2020 08:27:25 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0A28RC6o031299 for ; Mon, 2 Nov 2020 03:27:13 -0500 Received: by smtp.corp.redhat.com (Postfix) id CC24B49C1A; Mon, 2 Nov 2020 08:27:12 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C60C347CF6 for ; Mon, 2 Nov 2020 08:27:09 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2509C8007A4 for ; Mon, 2 Nov 2020 08:27:09 +0000 (UTC) Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [51.163.158.102]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-383-zk2saNstNxmcfNhkRollLA-1; Mon, 02 Nov 2020 03:27:07 -0500 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01lp2057.outbound.protection.outlook.com [104.47.1.57]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-13-OeG7TrhpOFmkdzJo26J-iA-1; Mon, 02 Nov 2020 09:27:03 +0100 Received: from AM6PR04MB5782.eurprd04.prod.outlook.com (2603:10a6:20b:aa::17) by AM6PR0402MB3624.eurprd04.prod.outlook.com (2603:10a6:209:4::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.30; Mon, 2 Nov 2020 08:27:01 +0000 Received: from AM6PR04MB5782.eurprd04.prod.outlook.com ([fe80::b5ca:e454:9fad:8712]) by AM6PR04MB5782.eurprd04.prod.outlook.com ([fe80::b5ca:e454:9fad:8712%7]) with mapi id 15.20.3499.030; Mon, 2 Nov 2020 08:27:01 +0000 Received: from t440p.suse.asia (60.251.47.115) by AM9P191CA0007.EURP191.PROD.OUTLOOK.COM (2603:10a6:20b:21c::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.19 via Frontend Transport; Mon, 2 Nov 2020 08:26:56 +0000 X-MC-Unique: _jpim7eJPqWoZRdDhALHXA-1 X-MC-Unique: zk2saNstNxmcfNhkRollLA-1 X-MC-Unique: OeG7TrhpOFmkdzJo26J-iA-1 From: Lin Ma To: libvir-list@redhat.com Subject: [libvirt] [PATCH 09/19] virdomainobjlist: Add vnc into filter group to check the vnc existence of guest Date: Mon, 2 Nov 2020 16:26:11 +0800 Message-ID: <20201102082621.13228-10-lma@suse.com> In-Reply-To: <20201102082621.13228-1-lma@suse.com> References: <20201102082621.13228-1-lma@suse.com> X-Originating-IP: [60.251.47.115] X-ClientProxiedBy: AM9P191CA0007.EURP191.PROD.OUTLOOK.COM (2603:10a6:20b:21c::12) To AM6PR04MB5782.eurprd04.prod.outlook.com (2603:10a6:20b:aa::17) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 78ce83d2-bf2f-4b59-4f8d-08d87f091031 X-MS-TrafficTypeDiagnostic: AM6PR0402MB3624: X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1013 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0 X-Microsoft-Antispam-Message-Info: ZuIOFlC3LvWAIdNB92Nh50h5LDg+01Zet1iMjv2A4aar4obwjQTi+9dfLVzUtgBG19Ih+Y0GvIp4vg0buhNGxz5bxW+Iz4O1uN++TT2VM5NCyqO0hvcRpAx4fy/nipHBQ1CNcpZsy5A7ecIdOL7OWo0toW0758H1+jvzzJJ2+J5I8PvGG8jERAyH2WaeA5kVeuel/BeAmgPtuGXrddo/bNn498ogSMB5fEBpxW6ta9X1lV2MqiPqeB9uDB5UKj62jkJVRWZqkRFc4Mq7MSGn0x5FyTtwfSoSRO8zwHJRqT4YZndWgSH4mWKMdJzPyKPu X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR04MB5782.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(39860400002)(396003)(376002)(136003)(366004)(107886003)(6666004)(5660300002)(16526019)(66556008)(66946007)(66476007)(2616005)(956004)(8676002)(6506007)(186003)(316002)(450100002)(4326008)(52116002)(26005)(478600001)(8936002)(2906002)(36756003)(55236004)(86362001)(1076003)(6916009)(6486002)(83380400001)(6512007); DIR:OUT; SFP:1101 X-MS-Exchange-AntiSpam-MessageData: pu8xqEe3Lu2CxcyYCdVzU8spgFuM2L/ZLbKb8TCu8y8sjLp+3lb+1rVFfDsT03T1pJb9RLbANcgJ9yf0nAeBer82HmsKvQ1FpZsfwJ31FGILxmJ7WgW7WQLXxtRuUacnH9WFDRZ2HUcMZ8WFD10c9g/OUBgSB/M2/wQs5VHOgwjP8A//9mQD7h5jCciAaEf5RojPlCoHJrH/LZcJShmBlIuEDTitDoEhGztCDraJrrpaujsrzjXcxcWVmfOoPjxGNtIrB0wHg6xSM39jYefLqLT4dlwjwl+RguryKMvrezM0UrgStoSItbC8cpTzY9yjoQJPGXIQW/F8x4dmd+StZncJmrkK9ACa2WuXl7uF3Lc3uwfW1cqyGL9gzkXzmRfjZLX9vMekvof5hQfrBHZiu2f4C0PvLWe0k/P2TyxV1AfB51sIp90r2qJy//JJS8hGlT/AYua1JLd2WetHxssAIFGzZkkmILssci7xHYId4xKq5nk+0rTJyU16kUVTqMv0bds/q7uXJk71j1FCSG87EKNwrYlowZx5/iw8DHWKlKsytKPMPL1rs3YjNHNztcMOO2/DDF5KnZVwD02GnGMBmszZQMjG7n0J5gyaURjKd6FByLXCknIuxlp75w4YeIJVjPtzL/Swn0MD/TJy3kCWEQ== X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 78ce83d2-bf2f-4b59-4f8d-08d87f091031 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB5782.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2020 08:26:58.0303 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CiU1aiOe3VyxzxnCFtaWp1eBHuecyxYvgFj0YwbBjzKJ1E5SVnmtQJb9B11P+YeX X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0402MB3624 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 0A28RC6o031299 X-loop: libvir-list@redhat.com Cc: mprivozn@redhat.com, Lin Ma X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Signed-off-by: Lin Ma --- include/libvirt/libvirt-domain.h | 3 +++ src/conf/virdomainobjlist.c | 15 +++++++++++++++ src/conf/virdomainobjlist.h | 7 ++++++- 3 files changed, 24 insertions(+), 1 deletion(-) diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-dom= ain.h index b3310729bf..c138e8299c 100644 --- a/include/libvirt/libvirt-domain.h +++ b/include/libvirt/libvirt-domain.h @@ -1877,6 +1877,9 @@ typedef enum { =20 VIR_CONNECT_LIST_DOMAINS_HAS_CHECKPOINT =3D 1 << 14, VIR_CONNECT_LIST_DOMAINS_NO_CHECKPOINT =3D 1 << 15, + + VIR_CONNECT_LIST_DOMAINS_HAS_VNC =3D 1 << 16, + VIR_CONNECT_LIST_DOMAINS_NO_VNC =3D 1 << 17, } virConnectListAllDomainsFlags; =20 int virConnectListAllDomains (virConnectPtr conn, diff --git a/src/conf/virdomainobjlist.c b/src/conf/virdomainobjlist.c index e9a4b271df..5931669b5d 100644 --- a/src/conf/virdomainobjlist.c +++ b/src/conf/virdomainobjlist.c @@ -912,6 +912,21 @@ virDomainObjMatchFilter(virDomainObjPtr vm, return false; } =20 + /* filter by vnc existence */ + if (MATCH(VIR_CONNECT_LIST_DOMAINS_FILTERS_VNC)) { + int i; + bool hasVnc =3D false; + for (i =3D 0; i < vm->def->ngraphics; ++i) { + if (vm->def->graphics[i]->type =3D=3D VIR_DOMAIN_GRAPHICS_TYPE= _VNC) { + hasVnc =3D true; + break; + } + } + if (!((MATCH(VIR_CONNECT_LIST_DOMAINS_HAS_VNC) && hasVnc) || + (MATCH(VIR_CONNECT_LIST_DOMAINS_NO_VNC) && !hasVnc))) + return false; + } + return true; } #undef MATCH diff --git a/src/conf/virdomainobjlist.h b/src/conf/virdomainobjlist.h index 6150e13aa4..3a86e24100 100644 --- a/src/conf/virdomainobjlist.h +++ b/src/conf/virdomainobjlist.h @@ -124,6 +124,10 @@ int virDomainObjListForEach(virDomainObjListPtr doms, (VIR_CONNECT_LIST_DOMAINS_HAS_CHECKPOINT | \ VIR_CONNECT_LIST_DOMAINS_NO_CHECKPOINT) =20 +#define VIR_CONNECT_LIST_DOMAINS_FILTERS_VNC \ + (VIR_CONNECT_LIST_DOMAINS_HAS_VNC | \ + VIR_CONNECT_LIST_DOMAINS_NO_VNC) + #define VIR_CONNECT_LIST_DOMAINS_FILTERS_ALL \ (VIR_CONNECT_LIST_DOMAINS_FILTERS_ACTIVE | \ VIR_CONNECT_LIST_DOMAINS_FILTERS_PERSISTENT | \ @@ -131,7 +135,8 @@ int virDomainObjListForEach(virDomainObjListPtr doms, VIR_CONNECT_LIST_DOMAINS_FILTERS_MANAGEDSAVE | \ VIR_CONNECT_LIST_DOMAINS_FILTERS_AUTOSTART | \ VIR_CONNECT_LIST_DOMAINS_FILTERS_SNAPSHOT | \ - VIR_CONNECT_LIST_DOMAINS_FILTERS_CHECKPOINT) + VIR_CONNECT_LIST_DOMAINS_FILTERS_CHECKPOINT | \ + VIR_CONNECT_LIST_DOMAINS_FILTERS_VNC) =20 int virDomainObjListCollect(virDomainObjListPtr doms, virConnectPtr conn, --=20 2.26.0