From nobody Mon Feb 9 12:42:31 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1603849005; cv=none; d=zohomail.com; s=zohoarc; b=L+QFpO+hzNQ339OyDZ1Mel6sQbBuHPgjbv2s+4v4JBhm4ScsHL4TcutNUqQUIOFLcGDzPOoNvW5btE2QVCp9uIdbVW2E26o29tmoV+ukK0NQirDm8j+VNSG4ssY2u/xenSlnZ8Mvf/iAoCbJ3ZapIubfWR2nwgrvYSu6ANrKZkw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603849005; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=C4me0R6jD5gRBRSXqsucknRVb05gu/Rccxd/A2R57M8=; b=JDx+oYQ21fpRT0d2WDBe5tU+Sfr6N7l5vDZh2CP436v/ZP1IbbhcvyfYhbhtSK7Yy5PxbX0YjqgIkHwiciCUZ71GXnVpZDMiQK4NHCzNAW+ju2sd0GKD4s/lJ3CDylW3Rf3m2eSQ13IV0HRvPUhxrOs5c3pkCCMQkoDy1IdsIR4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1603849005700200.392109716361; Tue, 27 Oct 2020 18:36:45 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-274-Z-4vKWhIOna_sJGqvyuZTg-1; Tue, 27 Oct 2020 21:36:41 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 25A6C8030A2; Wed, 28 Oct 2020 01:36:31 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 01EDC6EF53; Wed, 28 Oct 2020 01:36:31 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id C109D181A894; Wed, 28 Oct 2020 01:36:30 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 09S1aDG1028311 for ; Tue, 27 Oct 2020 21:36:13 -0400 Received: by smtp.corp.redhat.com (Postfix) id CDCAB5C1DC; Wed, 28 Oct 2020 01:36:13 +0000 (UTC) Received: from vhost2.laine.org (ovpn-113-144.phx2.redhat.com [10.3.113.144]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8EDCE5C1C5 for ; Wed, 28 Oct 2020 01:36:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603849004; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=C4me0R6jD5gRBRSXqsucknRVb05gu/Rccxd/A2R57M8=; b=ioznJWNp/2ZPNQq7eRGLUW0piCWppYi0Q2Z97KWqMXVSMk3++KdnfQ5+EpFg5+aLnN5L/r 7ysU7ohb8KdifjTG5zc8iJA9wzQCKp/32wNgDlFhlMjxqnv8mFRE+UQnPGcFDtfyRzoNsT qDTm7ZAc6nQS6ppkKcstZlCW9+PK56s= X-MC-Unique: Z-4vKWhIOna_sJGqvyuZTg-1 From: Laine Stump To: libvir-list@redhat.com Subject: [PATCH 10/12] util: remove unused VIR_DIR_CLOSE() macro Date: Tue, 27 Oct 2020 21:35:56 -0400 Message-Id: <20201028013558.424925-11-laine@redhat.com> In-Reply-To: <20201028013558.424925-1-laine@redhat.com> References: <20201028013558.424925-1-laine@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Since every single use of DIR* was converted to use g_autoptr, this function is not currently needed. Even if someone comes up with a usage for a non-g_autoptr DIR* in the future, they can just use virDirClose(), since there is no longer a semantic difference between the two (VIR_DIR_CLOSE() previously had an extra & on the pointer so that it could be transparently passed as a DIR** to virDirClose(), but that was removed several commits back.) Signed-off-by: Laine Stump --- src/util/virfile.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/util/virfile.h b/src/util/virfile.h index 6973fbd54a..ba31a78e58 100644 --- a/src/util/virfile.h +++ b/src/util/virfile.h @@ -272,7 +272,6 @@ int virDirRead(DIR *dirp, struct dirent **ent, const ch= ar *dirname) void virDirClose(DIR *dirp) ATTRIBUTE_NONNULL(1); G_DEFINE_AUTOPTR_CLEANUP_FUNC(DIR, virDirClose); -#define VIR_DIR_CLOSE(dir) virDirClose(dir) =20 int virFileMakePath(const char *path) G_GNUC_WARN_UNUSED_RESULT; int virFileMakePathWithMode(const char *path, --=20 2.26.2