[PATCH 0/9] several small cleanups in virpci.c et. al.

Laine Stump posted 9 patches 3 years, 5 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20201021022609.2318322-1-laine@redhat.com
src/hypervisor/virhostdev.c |  10 +--
src/libvirt_private.syms    |   1 -
src/util/virnetdev.c        |   6 +-
src/util/virpci.c           | 146 ++++++++++++------------------------
src/util/virpci.h           |   4 -
5 files changed, 53 insertions(+), 114 deletions(-)
[PATCH 0/9] several small cleanups in virpci.c et. al.
Posted by Laine Stump 3 years, 5 months ago
These started with a couple small cleanups to functions I was going to
change the API for, but then I decided not to change the API, and just
didn't want to waste the effort spent cleaning them up.

Laine Stump (9):
  util: simplify virHostdevPCISysfsPath()
  util: simplify virPCIFile() and its callers
  util: simplify virPCIDriverDir() and its callers
  util: simplify virPCIProbeStubDriver()
  util: avoid manual VIR_FREE of a g_autofree pointer in virPCIGetName()
  util: use more g_autofree in virpci.c
  util: remove unneeded cleanup:/ret in virpci.c
  util: don't use virPCIGetSysfsFile()
  util: remove unused function virPCIGetSysfsFile()

 src/hypervisor/virhostdev.c |  10 +--
 src/libvirt_private.syms    |   1 -
 src/util/virnetdev.c        |   6 +-
 src/util/virpci.c           | 146 ++++++++++++------------------------
 src/util/virpci.h           |   4 -
 5 files changed, 53 insertions(+), 114 deletions(-)

-- 
2.26.2

Re: [PATCH 0/9] several small cleanups in virpci.c et. al.
Posted by Ján Tomko 3 years, 5 months ago
On a Tuesday in 2020, Laine Stump wrote:
>These started with a couple small cleanups to functions I was going to
>change the API for, but then I decided not to change the API, and just
>didn't want to waste the effort spent cleaning them up.
>

Thank you.

>Laine Stump (9):
>  util: simplify virHostdevPCISysfsPath()
>  util: simplify virPCIFile() and its callers
>  util: simplify virPCIDriverDir() and its callers
>  util: simplify virPCIProbeStubDriver()
>  util: avoid manual VIR_FREE of a g_autofree pointer in virPCIGetName()
>  util: use more g_autofree in virpci.c
>  util: remove unneeded cleanup:/ret in virpci.c
>  util: don't use virPCIGetSysfsFile()
>  util: remove unused function virPCIGetSysfsFile()
>
> src/hypervisor/virhostdev.c |  10 +--
> src/libvirt_private.syms    |   1 -
> src/util/virnetdev.c        |   6 +-
> src/util/virpci.c           | 146 ++++++++++++------------------------
> src/util/virpci.h           |   4 -

> 5 files changed, 53 insertions(+), 114 deletions(-)

Beautiful.

Jano

>
>-- 
>2.26.2
>
Re: [PATCH 0/9] several small cleanups in virpci.c et. al.
Posted by Erik Skultety 3 years, 5 months ago
On Tue, Oct 20, 2020 at 10:26:00PM -0400, Laine Stump wrote:
> These started with a couple small cleanups to functions I was going to
> change the API for, but then I decided not to change the API, and just
> didn't want to waste the effort spent cleaning them up.

Reviewed-by: Erik Skultety <eskultet@redhat.com>

Re: [PATCH 0/9] several small cleanups in virpci.c et. al.
Posted by Peter Krempa 3 years, 5 months ago
On Tue, Oct 20, 2020 at 22:26:00 -0400, Laine Stump wrote:
> These started with a couple small cleanups to functions I was going to
> change the API for, but then I decided not to change the API, and just
> didn't want to waste the effort spent cleaning them up.

Reviewed-by: Peter Krempa <pkrempa@redhat.com>