From nobody Sun Feb 8 03:15:36 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1602708305; cv=none; d=zohomail.com; s=zohoarc; b=Ohz9Mg+HnSwKJV/mHHKJm4V/XhSjhBMPOIBzysqaoX/XW2xlN3IiY/ZSh0IEiA8PpNXpNIvlXguTJGD7ipXew6A/fba32pF2tlIE8qVqXB//4jbSszlEOBYvkQSxxpaXO+aOuyP2Nm4Ar1kebDqW6e4x0KnYC19dW/aqacqu5uI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602708305; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=6geIV7VuBZmzCBHTlxlzhIz7NePa3vRL5ipYZPV/4bI=; b=L8RI/uhyIQVCzTQD5O79EPtkeMqNtyC2BKGplBbYNGe6tyhjPvhjt75uZCJ62JbDd22sBQqxdu8AqKErcY2fIjGOPQZarx66vgJiYQb2xLsImQvxeOXM1jY9bQSwQntJVXE2fgMqaau8nOLgmmQGXqmWCT8Cd4bwtNgJ0ux0a9A= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1602708305070984.9211953049074; Wed, 14 Oct 2020 13:45:05 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-210-pvTeZJYKNMaNsn6WKN0Sig-1; Wed, 14 Oct 2020 16:44:36 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5C5538030D7; Wed, 14 Oct 2020 20:44:31 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 39D2F5C1C2; Wed, 14 Oct 2020 20:44:31 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 0A175181A272; Wed, 14 Oct 2020 20:44:31 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 09EKhpNb028808 for ; Wed, 14 Oct 2020 16:43:51 -0400 Received: by smtp.corp.redhat.com (Postfix) id 3EB40151125; Wed, 14 Oct 2020 20:43:51 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast06.extmail.prod.ext.rdu2.redhat.com [10.11.55.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 399E91711DB for ; Wed, 14 Oct 2020 20:43:51 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2082B1823614 for ; Wed, 14 Oct 2020 20:43:51 +0000 (UTC) Received: from mail-il1-f172.google.com (mail-il1-f172.google.com [209.85.166.172]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-343-xMzvt4lGPPeJrXgE6KcfGw-1; Wed, 14 Oct 2020 16:43:48 -0400 Received: by mail-il1-f172.google.com with SMTP id j8so1107043ilk.0 for ; Wed, 14 Oct 2020 13:43:48 -0700 (PDT) Received: from rekt.ibmuc.com ([2804:431:c7c6:5a9b:54fc:df2a:8a5e:989b]) by smtp.gmail.com with ESMTPSA id i4sm492202ilc.27.2020.10.14.13.43.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Oct 2020 13:43:47 -0700 (PDT) X-MC-Unique: pvTeZJYKNMaNsn6WKN0Sig-1 X-MC-Unique: xMzvt4lGPPeJrXgE6KcfGw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6geIV7VuBZmzCBHTlxlzhIz7NePa3vRL5ipYZPV/4bI=; b=rBBzos/K20Gy1Co0+cm5i9PIuLfvYmA5H3pgKoZjnIyqnlPDRLgTiobDRlV4wvCOEE EUCale2O52lDYAf2TVMgbS7l038j6lPYCjZNHL2+N+/Ra2a6hRJmw9KTJfIqn0Y7QPoa 5SLSnYWa+0g2qroy4umHIZiXWolJhKkVhYSLhL1QdW7teU/J86UFLFvv03hEtYSZx9AD iptvL1Tm2i3LJME8Oi4laK1DLPtEFm8j8Q0PXzNQqz84CXgPpR9lv1Me9/yJEpYFeuFu IK0SrJiqrpy8vzzsTFddk4oY76MtX14VDd0Gx/G+CB8RFMd1feuryyHCP9sTj/EznV5I KRAg== X-Gm-Message-State: AOAM532B2moxbH1faQbs4kyLz2fzhMuIwnc/hxP09NXhmKN5rjwVFccn D3ZcrI2DDPDFwRSTVditcZ7TTXLQbH0= X-Google-Smtp-Source: ABdhPJx9ho9cmRuqnk8U6k+zzSX85vKo+2ssWX5jIq8xvdEqSFbn6izCmiBZpxUwjrUS+L4JMcvNwA== X-Received: by 2002:a92:cc0b:: with SMTP id s11mr799265ilp.51.1602708227659; Wed, 14 Oct 2020 13:43:47 -0700 (PDT) From: Daniel Henrique Barboza To: libvir-list@redhat.com Subject: [PATCH v1 17/24] qemu_command.c: move NUMA memory backing check to qemu_validate.c Date: Wed, 14 Oct 2020 17:43:00 -0300 Message-Id: <20201014204307.631746-18-danielhb413@gmail.com> In-Reply-To: <20201014204307.631746-1-danielhb413@gmail.com> References: <20201014204307.631746-1-danielhb413@gmail.com> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-loop: libvir-list@redhat.com Cc: Daniel Henrique Barboza X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Signed-off-by: Daniel Henrique Barboza --- src/qemu/qemu_command.c | 5 ----- src/qemu/qemu_validate.c | 15 +++++++++++++++ tests/qemuxml2xmltest.c | 2 +- 3 files changed, 16 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 34d57606f0..225d1d7491 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -7291,11 +7291,6 @@ qemuBuildNumaCommandLine(virQEMUDriverConfigPtr cfg, if (rc =3D=3D 0) needBackend =3D true; } - } else if (needBackend) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("NUMA without specified memory backing is not " - "supported with this QEMU binary")); - goto cleanup; } =20 if (!needBackend && diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index 7e6313b5c8..9bb7cddb40 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -701,6 +701,7 @@ qemuValidateDomainDefNuma(const virDomainDef *def, bool hasMemoryCap =3D virQEMUCapsGet(qemuCaps, QEMU_CAPS_OBJECT_MEMORY= _RAM) || virQEMUCapsGet(qemuCaps, QEMU_CAPS_OBJECT_MEMORY_F= ILE) || virQEMUCapsGet(qemuCaps, QEMU_CAPS_OBJECT_MEMORY_M= EMFD); + bool needBacking =3D false; =20 if (virDomainNumatuneHasPerNodeBinding(def->numa) && !hasMemoryCap) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", @@ -752,6 +753,20 @@ qemuValidateDomainDefNuma(const virDomainDef *def, return -1; } =20 + if (virDomainNumaHasHMAT(def->numa) || + !virQEMUCapsGetMachineNumaMemSupported(qemuCaps, + def->virtType, + def->os.machine)) { + needBacking =3D true; + } + + if (needBacking && !hasMemoryCap) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("NUMA without specified memory backing is not " + "supported with this QEMU binary")); + return -1; + } + return 0; } =20 diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c index 6c551f18ab..93287d0a55 100644 --- a/tests/qemuxml2xmltest.c +++ b/tests/qemuxml2xmltest.c @@ -1141,7 +1141,7 @@ mymain(void) DO_TEST("numatune-memnode-no-memory", QEMU_CAPS_OBJECT_MEMORY_FILE); DO_TEST("numatune-distances", QEMU_CAPS_NUMA, QEMU_CAPS_NUMA_DIST); DO_TEST("numatune-no-vcpu", QEMU_CAPS_NUMA); - DO_TEST("numatune-hmat", QEMU_CAPS_NUMA_HMAT); + DO_TEST("numatune-hmat", QEMU_CAPS_NUMA_HMAT, QEMU_CAPS_OBJECT_MEMORY_= RAM); =20 DO_TEST("bios-nvram", NONE); DO_TEST("bios-nvram-os-interleave", NONE); --=20 2.26.2