From nobody Thu Mar 28 22:47:40 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1602623705; cv=none; d=zohomail.com; s=zohoarc; b=E6QGxTArv3Kyh3geU30OhXou8BvRpi4iYqEX9eVwT2t/a0ufvPpNMDlrE6x2eKaecZz/RwzNhxl17vMYH0JkM6cnA8LqxtnMNOk5PXNG661tokvZp+R4HgREzV0WR8mTkCIJEr+shOUbESGLewXpHDWL2Ar+mTpcxTdC4DCf82A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602623705; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=iH9NpB5fKJ12v0lvebHXZPheTVBangTgcn3G2wsg3QA=; b=UE5wD/RUbnrynQ66I1841VtkN1b4FXdVkfl9OCh5eDi3kXQdO8ocwEGZUQqDxWNMWoQgUYZH5wNVPmkt9o1GnGfVzzn2wv+0iAOd5aHWnkkoOr8hc73BAVDowjAs6GFYP0p17VyHMPIbX18CLTAEz3b8GWHALMqtCXa2nlal8HE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1602623705550689.6539347701308; Tue, 13 Oct 2020 14:15:05 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-163-kEzkrQngO52a0G3pkoeNXg-1; Tue, 13 Oct 2020 17:15:02 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E5503108E1A6; Tue, 13 Oct 2020 21:14:54 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3DFC176643; Tue, 13 Oct 2020 21:14:54 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 1299B1832FB6; Tue, 13 Oct 2020 21:14:51 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 09DLEnJE007249 for ; Tue, 13 Oct 2020 17:14:49 -0400 Received: by smtp.corp.redhat.com (Postfix) id D3AD15D9D3; Tue, 13 Oct 2020 21:14:49 +0000 (UTC) Received: from himantopus.redhat.com (ovpn-112-134.phx2.redhat.com [10.3.112.134]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A5D445D9CD for ; Tue, 13 Oct 2020 21:14:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602623704; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=iH9NpB5fKJ12v0lvebHXZPheTVBangTgcn3G2wsg3QA=; b=iQZ4D7IRXwkgs6FV7dI6FsnRluA523JVViP0MlclLxsnhBkwtCscKykrw91+hcbY8oYMQ5 0PzMeF14GHUEKdJUfpLHxIASSwFbWS46KF+UwVD2y+Iw5PUpzxxYKJWMWS4XDMDif6aLvQ W8BVfiwXzhcL2cpRdLUO3Sm4muB2z1A= X-MC-Unique: kEzkrQngO52a0G3pkoeNXg-1 From: Jonathon Jongsma To: libvir-list@redhat.com Subject: [libvirt PATCH] qemu: remove some unnecessary local variables Date: Tue, 13 Oct 2020 16:14:46 -0500 Message-Id: <20201013211446.1323670-1-jjongsma@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" These variables seem to be left over from a previous refactoring and they don't add anything to the code. Signed-off-by: Jonathon Jongsma Reviewed-by: Laine Stump and pushed. --- src/qemu/qemu_hotplug.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 2c184b9ba0..79fc8baa5c 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -5502,7 +5502,6 @@ qemuDomainDetachPrepRedirdev(virDomainObjPtr vm, virDomainRedirdevDefPtr match, virDomainRedirdevDefPtr *detach) { - virDomainRedirdevDefPtr redirdev; ssize_t idx; =20 if ((idx =3D virDomainRedirdevDefFind(vm->def, match)) < 0) { @@ -5511,7 +5510,7 @@ qemuDomainDetachPrepRedirdev(virDomainObjPtr vm, return -1; } =20 - *detach =3D redirdev =3D vm->def->redirdevs[idx]; + *detach =3D vm->def->redirdevs[idx]; =20 return 0; } @@ -5523,12 +5522,11 @@ qemuDomainDetachPrepNet(virDomainObjPtr vm, virDomainNetDefPtr *detach) { int detachidx; - virDomainNetDefPtr net =3D NULL; =20 if ((detachidx =3D virDomainNetFindIdx(vm->def, match)) < 0) return -1; =20 - *detach =3D net =3D vm->def->nets[detachidx]; + *detach =3D vm->def->nets[detachidx]; =20 return 0; } @@ -5598,7 +5596,6 @@ qemuDomainDetachPrepRNG(virDomainObjPtr vm, virDomainRNGDefPtr *detach) { ssize_t idx; - virDomainRNGDefPtr rng; =20 if ((idx =3D virDomainRNGFind(vm->def, match)) < 0) { virReportError(VIR_ERR_DEVICE_MISSING, @@ -5608,7 +5605,7 @@ qemuDomainDetachPrepRNG(virDomainObjPtr vm, return -1; } =20 - *detach =3D rng =3D vm->def->rngs[idx]; + *detach =3D vm->def->rngs[idx]; =20 return 0; } @@ -5619,7 +5616,6 @@ qemuDomainDetachPrepMemory(virDomainObjPtr vm, virDomainMemoryDefPtr match, virDomainMemoryDefPtr *detach) { - virDomainMemoryDefPtr mem; int idx; =20 if (qemuDomainMemoryDeviceAlignSize(vm->def, match) < 0) @@ -5633,7 +5629,7 @@ qemuDomainDetachPrepMemory(virDomainObjPtr vm, return -1; } =20 - *detach =3D mem =3D vm->def->mems[idx]; + *detach =3D vm->def->mems[idx]; =20 return 0; } --=20 2.26.2