From nobody Mon Feb 9 02:12:17 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1602235624; cv=none; d=zohomail.com; s=zohoarc; b=W6drEVIFKxfA9lgSbwg3pjieMNtttwQVaWPCc1P3EZtMgDJH67pes1poZ8AwHVQWpXEm84Dn6T5QDztjxzbt/kAtenctggPmwjrBtjRVlLgtWCeG6HGGRgOTAEurQSnjBKb2lTgG60H0Xrv3ArAKLzyUfg65tTKejk9/NSQ9jiM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602235624; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=M86UzaRKNLBEkpH6kHn5Fv4hLmPaGkVX9k5ey8TPwpg=; b=dQ7Fkujr5vVZrGFBHrdtREPvKN5LqrWoLwxS8/XF6WnxstnNOsT1fYGtBg3vW+zsoKOPBjUQip/U3up82Gc6dc7icfv/QkcNgmZO9u1pZtuDmXLmBoQ7wTgIOElQyDXf1CaN/OeERAw72DSAjnPfzduKCSXTIG65LFTPYNbJbiY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1602235624295252.8145376480918; Fri, 9 Oct 2020 02:27:04 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-318-BQI6Bk_OOhmRmyZk0ujHUA-1; Fri, 09 Oct 2020 05:26:24 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 20971805F00; Fri, 9 Oct 2020 09:26:19 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F39896EF6E; Fri, 9 Oct 2020 09:26:18 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id C16A118408C2; Fri, 9 Oct 2020 09:26:18 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0999Q4fp009453 for ; Fri, 9 Oct 2020 05:26:04 -0400 Received: by smtp.corp.redhat.com (Postfix) id 44675196FE; Fri, 9 Oct 2020 09:26:04 +0000 (UTC) Received: from harajuku.usersys.redhat.com (unknown [10.40.195.23]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 55A222632B for ; Fri, 9 Oct 2020 09:26:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602235623; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=M86UzaRKNLBEkpH6kHn5Fv4hLmPaGkVX9k5ey8TPwpg=; b=V/FnFrdO4njMUg1AwtjKgN19gjVSBZvZvEaxNW3uJsmHpwJqlJDqhhbgpk/X6uEcIdNXbR CGcUcDe5a5M36OGWh70gPfnPs7UGscvQ2wJdT9GoCqUrdLXUbF2NM2HLm+daX1muzp25GH YTB4YSLhXH0hnZiOAebH/oyr4iNW8fI= X-MC-Unique: BQI6Bk_OOhmRmyZk0ujHUA-1 From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH v2 8/9] spec: Refactor qemu_kvm_arches definition Date: Fri, 9 Oct 2020 11:25:45 +0200 Message-Id: <20201009092546.15546-9-abologna@redhat.com> In-Reply-To: <20201009092546.15546-1-abologna@redhat.com> References: <20201009092546.15546-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" There's no need to set a default for it if we're going to override it immediately afterwards anyway, and setting with_qemu_tcg at the same time only makes things more confusing. Signed-off-by: Andrea Bolognani --- libvirt.spec.in | 25 ++++++++++++------------- 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 7ab62ebd63..a0cd5ce5af 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -17,31 +17,30 @@ %define _vpath_builddir %{_target_platform} %endif =20 +%define qemu_kvm_arches %{ix86} x86_64 %{power64} %{arm} aarch64 s= 390x +%if 0%{?rhel} + %define qemu_kvm_arches x86_64 %{power64} aarch64 s390x +%endif + # The hypervisor drivers that run in libvirtd %define with_qemu 0%{!?_without_qemu:1} %define with_lxc 0%{!?_without_lxc:1} %define with_libxl 0%{!?_without_libxl:1} %define with_vbox 0%{!?_without_vbox:1} =20 -%define with_qemu_tcg %{with_qemu} - -%define qemu_kvm_arches %{ix86} x86_64 - -%if 0%{?fedora} - %define qemu_kvm_arches %{ix86} x86_64 %{power64} s390x %{arm} aarch64 -%endif - -%if 0%{?rhel} - %define with_qemu_tcg 0 - %define qemu_kvm_arches x86_64 %{power64} aarch64 s390x -%endif - %ifarch %{qemu_kvm_arches} %define with_qemu_kvm %{with_qemu} %else %define with_qemu_kvm 0 %endif =20 +%define with_qemu_tcg %{with_qemu} + +# RHEL disables TCG on all architectures +%if 0%{?rhel} + %define with_qemu_tcg 0 +%endif + %if ! %{with_qemu_tcg} && ! %{with_qemu_kvm} %define with_qemu 0 %endif --=20 2.26.2