From nobody Mon Feb 9 09:33:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1602235590; cv=none; d=zohomail.com; s=zohoarc; b=gziMyw9EeR6q6rlEbusxd4cQLj9JJF2uASgbMERFH7zz/c46i6Up3L8n2g2vcM2wZrMTU9Jmzf+jxxeFAfHiiiBneLYjsZ2Tf/qmGAGzzWCeHmWgLHhpFqc+igjQNZqocXGtDQfGqoaCsWfjMEW0WIg24spp6BkXze2tzoNTxwU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602235590; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=337LU8lkID/BM/B9ISXP4YEA1rWDP5LDPsm4dK6SY7c=; b=DfMpyJFTJaYDYEl3myLApW4tk527M4QQ0NaC61KyQb1K63B6X+OTprfpaULHY9asEdCWC8JZ2IvH7Izsm+c65tUiJ3wN7IspmyN8LzMLNROafrOl5hNxYYfGpad0FsjgD8fPq7/BnPS84dOFYJb5z3eXoagq9akOJR5DfVopACo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1602235590658720.406668225282; Fri, 9 Oct 2020 02:26:30 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-534-Jvhw6iZQMam8Dg9XxfkFDA-1; Fri, 09 Oct 2020 05:26:27 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1265B8799F0; Fri, 9 Oct 2020 09:26:19 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E1AD826335; Fri, 9 Oct 2020 09:26:18 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id AF94D8C7D5; Fri, 9 Oct 2020 09:26:18 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0999PxNP009380 for ; Fri, 9 Oct 2020 05:25:59 -0400 Received: by smtp.corp.redhat.com (Postfix) id D755A196FE; Fri, 9 Oct 2020 09:25:59 +0000 (UTC) Received: from harajuku.usersys.redhat.com (unknown [10.40.195.23]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E6FD32632B for ; Fri, 9 Oct 2020 09:25:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602235589; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=337LU8lkID/BM/B9ISXP4YEA1rWDP5LDPsm4dK6SY7c=; b=FzLRZKUtFKiNBsiihHIZzw5q+IGDObfJMChYm1cXG/E8d/GoRM5Mcg0NLOYMuRUr3SR7jr X/FqSM4AK8wq2+52BrBuB8Vf9CzTz0NVl7mIiK8D6iClJlfcHxiZ4uN1dBAACmav87xob0 Wkdy5ASWJp2S6J9bQ5UCmxWjwMWUKGU= X-MC-Unique: Jvhw6iZQMam8Dg9XxfkFDA-1 From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH v2 5/9] spec: Introduce with_dmidecode Date: Fri, 9 Oct 2020 11:25:42 +0200 Message-Id: <20201009092546.15546-6-abologna@redhat.com> In-Reply-To: <20201009092546.15546-1-abologna@redhat.com> References: <20201009092546.15546-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" To keep things maintainable, we want to have architecture handling all in one spot instead of sprinkling %ifarch conditionals all over the place. Signed-off-by: Andrea Bolognani Reviewed-by: Neal Gompa --- libvirt.spec.in | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index d9fa27a5fe..ae6381fe3e 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -94,6 +94,7 @@ %define with_libssh2 0 %define with_wireshark 0 %define with_libssh 0 +%define with_dmidecode 0 =20 # Finally set the OS / architecture specific special cases =20 @@ -183,6 +184,10 @@ %endif %endif =20 +%ifarch %{ix86} x86_64 + %define with_dmidecode 0%{!?_without_dmidecode:1} +%endif + # Force QEMU to run as non-root %define qemu_user qemu %define qemu_group qemu @@ -435,7 +440,7 @@ Requires: iproute-tc %endif =20 Requires: polkit >=3D 0.112 -%ifarch %{ix86} x86_64 +%if %{with_dmidecode} # For virConnectGetSysinfo Requires: dmidecode %endif --=20 2.26.2